sid/NazaraEngine
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Buffer::Unmap no longer return boolean

Browse Source 
Made no sense: What do you want to do when your buffer doesn't unmap ?
Tt now throw a warning by itself in case of failure


Former-commit-id: f776af16787316bbe1d55686a1db2c2e0f79d210
This commit is contained in:
Lynix
2012-12-31 11:30:19 +01:00
parent c65f0e9f7e
commit 02f5385eaf
6 changed files with 11 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Nazara/Utility/Buffer.cpp
View File

@@ -293,9 +293,7 @@ bool NzBuffer::SetStorage(nzBufferStorage storage)
{
NazaraError("Failed to create buffer");
delete impl;
if (!m_impl->Unmap())
NazaraWarning("Failed to unmap buffer");
m_impl->Unmap();
return false;
}
@@ -305,9 +303,7 @@ bool NzBuffer::SetStorage(nzBufferStorage storage)
NazaraError("Failed to fill buffer");
impl->Destroy();
delete impl;
if (!m_impl->Unmap())
NazaraWarning("Failed to unmap buffer");
m_impl->Unmap();
return false;
}
@@ -322,7 +318,7 @@ bool NzBuffer::SetStorage(nzBufferStorage storage)
return true;
}
bool NzBuffer::Unmap() const
void NzBuffer::Unmap() const
{
#if NAZARA_UTILITY_SAFE
if (!m_impl)
@@ -332,7 +328,8 @@ bool NzBuffer::Unmap() const
}
#endif
return m_impl->Unmap();
if (!m_impl->Unmap())
NazaraWarning("Failed to unmap buffer (it's content is undefined)"); ///TODO: Unexpected ?
}
bool NzBuffer::IsSupported(nzBufferStorage storage)