Shader: Handle type as expressions

This commit is contained in:
Jérôme Leclercq 2022-02-08 17:03:34 +01:00
parent 5ce8120a0c
commit 402e16bd2b
53 changed files with 1746 additions and 1141 deletions

View File

@ -58,7 +58,6 @@ namespace Nz
struct Option struct Option
{ {
std::size_t index; std::size_t index;
ShaderAst::ExpressionType type;
}; };
private: private:

View File

@ -24,7 +24,8 @@ namespace Nz::ShaderAst
AstCloner(AstCloner&&) = delete; AstCloner(AstCloner&&) = delete;
~AstCloner() = default; ~AstCloner() = default;
template<typename T> AttributeValue<T> Clone(const AttributeValue<T>& attribute); template<typename T> ExpressionValue<T> Clone(const ExpressionValue<T>& expressionValue);
inline ExpressionValue<ExpressionType> Clone(const ExpressionValue<ExpressionType>& expressionValue);
ExpressionPtr Clone(Expression& statement); ExpressionPtr Clone(Expression& statement);
StatementPtr Clone(Statement& statement); StatementPtr Clone(Statement& statement);
@ -37,6 +38,7 @@ namespace Nz::ShaderAst
virtual ExpressionPtr CloneExpression(Expression& expr); virtual ExpressionPtr CloneExpression(Expression& expr);
virtual StatementPtr CloneStatement(Statement& statement); virtual StatementPtr CloneStatement(Statement& statement);
virtual ExpressionValue<ExpressionType> CloneType(const ExpressionValue<ExpressionType>& exprType);
virtual ExpressionPtr Clone(AccessIdentifierExpression& node); virtual ExpressionPtr Clone(AccessIdentifierExpression& node);
virtual ExpressionPtr Clone(AccessIndexExpression& node); virtual ExpressionPtr Clone(AccessIndexExpression& node);
@ -69,6 +71,7 @@ namespace Nz::ShaderAst
virtual StatementPtr Clone(MultiStatement& node); virtual StatementPtr Clone(MultiStatement& node);
virtual StatementPtr Clone(NoOpStatement& node); virtual StatementPtr Clone(NoOpStatement& node);
virtual StatementPtr Clone(ReturnStatement& node); virtual StatementPtr Clone(ReturnStatement& node);
virtual StatementPtr Clone(ScopedStatement& node);
virtual StatementPtr Clone(WhileStatement& node); virtual StatementPtr Clone(WhileStatement& node);
#define NAZARA_SHADERAST_NODE(NodeType) void Visit(NodeType& node) override; #define NAZARA_SHADERAST_NODE(NodeType) void Visit(NodeType& node) override;
@ -85,7 +88,7 @@ namespace Nz::ShaderAst
std::vector<StatementPtr> m_statementStack; std::vector<StatementPtr> m_statementStack;
}; };
template<typename T> AttributeValue<T> Clone(const AttributeValue<T>& attribute); template<typename T> ExpressionValue<T> Clone(const ExpressionValue<T>& attribute);
inline ExpressionPtr Clone(Expression& node); inline ExpressionPtr Clone(Expression& node);
inline StatementPtr Clone(Statement& node); inline StatementPtr Clone(Statement& node);
} }

View File

@ -8,20 +8,25 @@
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
template<typename T> template<typename T>
AttributeValue<T> AstCloner::Clone(const AttributeValue<T>& attribute) ExpressionValue<T> AstCloner::Clone(const ExpressionValue<T>& expressionValue)
{ {
if (!attribute.HasValue()) if (!expressionValue.HasValue())
return {}; return {};
if (attribute.IsExpression()) if (expressionValue.IsExpression())
return CloneExpression(attribute.GetExpression()); return CloneExpression(expressionValue.GetExpression());
else else
{ {
assert(attribute.IsResultingValue()); assert(expressionValue.IsResultingValue());
return attribute.GetResultingValue(); return expressionValue.GetResultingValue();
} }
} }
inline ExpressionValue<ExpressionType> AstCloner::Clone(const ExpressionValue<ExpressionType>& expressionValue)
{
return CloneType(expressionValue);
}
ExpressionPtr AstCloner::CloneExpression(const ExpressionPtr& expr) ExpressionPtr AstCloner::CloneExpression(const ExpressionPtr& expr)
{ {
if (!expr) if (!expr)
@ -40,7 +45,7 @@ namespace Nz::ShaderAst
template<typename T> template<typename T>
AttributeValue<T> Clone(const AttributeValue<T>& attribute) ExpressionValue<T> Clone(const ExpressionValue<T>& attribute)
{ {
AstCloner cloner; AstCloner cloner;
return cloner.Clone(attribute); return cloner.Clone(attribute);

View File

@ -21,7 +21,7 @@ namespace Nz::ShaderAst
template<typename T> bool Compare(const T& lhs, const T& rhs); template<typename T> bool Compare(const T& lhs, const T& rhs);
template<typename T, std::size_t S> bool Compare(const std::array<T, S>& lhs, const std::array<T, S>& rhs); template<typename T, std::size_t S> bool Compare(const std::array<T, S>& lhs, const std::array<T, S>& rhs);
template<typename T> bool Compare(const std::vector<T>& lhs, const std::vector<T>& rhs); template<typename T> bool Compare(const std::vector<T>& lhs, const std::vector<T>& rhs);
template<typename T> bool Compare(const AttributeValue<T>& lhs, const AttributeValue<T>& rhs); template<typename T> bool Compare(const ExpressionValue<T>& lhs, const ExpressionValue<T>& rhs);
inline bool Compare(const BranchStatement::ConditionalStatement& lhs, const BranchStatement::ConditionalStatement& rhs); inline bool Compare(const BranchStatement::ConditionalStatement& lhs, const BranchStatement::ConditionalStatement& rhs);
inline bool Compare(const DeclareExternalStatement::ExternalVar& lhs, const DeclareExternalStatement::ExternalVar& rhs); inline bool Compare(const DeclareExternalStatement::ExternalVar& lhs, const DeclareExternalStatement::ExternalVar& rhs);
inline bool Compare(const DeclareFunctionStatement::Parameter& lhs, const DeclareFunctionStatement::Parameter& rhs); inline bool Compare(const DeclareFunctionStatement::Parameter& lhs, const DeclareFunctionStatement::Parameter& rhs);
@ -59,6 +59,7 @@ namespace Nz::ShaderAst
inline bool Compare(const MultiStatement& lhs, const MultiStatement& rhs); inline bool Compare(const MultiStatement& lhs, const MultiStatement& rhs);
inline bool Compare(const NoOpStatement& lhs, const NoOpStatement& rhs); inline bool Compare(const NoOpStatement& lhs, const NoOpStatement& rhs);
inline bool Compare(const ReturnStatement& lhs, const ReturnStatement& rhs); inline bool Compare(const ReturnStatement& lhs, const ReturnStatement& rhs);
inline bool Compare(const ScopedStatement& lhs, const ScopedStatement& rhs);
inline bool Compare(const WhileStatement& lhs, const WhileStatement& rhs); inline bool Compare(const WhileStatement& lhs, const WhileStatement& rhs);
} }

View File

@ -78,7 +78,7 @@ namespace Nz::ShaderAst
} }
template<typename T> template<typename T>
bool Compare(const AttributeValue<T>& lhs, const AttributeValue<T>& rhs) bool Compare(const ExpressionValue<T>& lhs, const ExpressionValue<T>& rhs)
{ {
if (!Compare(lhs.HasValue(), rhs.HasValue())) if (!Compare(lhs.HasValue(), rhs.HasValue()))
return false; return false;
@ -519,6 +519,14 @@ namespace Nz::ShaderAst
return true; return true;
} }
bool Compare(const ScopedStatement& lhs, const ScopedStatement& rhs)
{
if (!Compare(lhs.statement, rhs.statement))
return false;
return true;
}
inline bool Compare(const WhileStatement& lhs, const WhileStatement& rhs) inline bool Compare(const WhileStatement& lhs, const WhileStatement& rhs)
{ {
if (!Compare(lhs.unroll, rhs.unroll)) if (!Compare(lhs.unroll, rhs.unroll))

View File

@ -13,7 +13,7 @@
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
class NAZARA_SHADER_API ExpressionVisitorExcept : public AstExpressionVisitor class NAZARA_SHADER_API AstExpressionVisitorExcept : public AstExpressionVisitor
{ {
public: public:
using AstExpressionVisitor::Visit; using AstExpressionVisitor::Visit;

View File

@ -58,6 +58,7 @@ NAZARA_SHADERAST_STATEMENT(ExpressionStatement)
NAZARA_SHADERAST_STATEMENT(MultiStatement) NAZARA_SHADERAST_STATEMENT(MultiStatement)
NAZARA_SHADERAST_STATEMENT(NoOpStatement) NAZARA_SHADERAST_STATEMENT(NoOpStatement)
NAZARA_SHADERAST_STATEMENT(ReturnStatement) NAZARA_SHADERAST_STATEMENT(ReturnStatement)
NAZARA_SHADERAST_STATEMENT(ScopedStatement)
NAZARA_SHADERAST_STATEMENT_LAST(WhileStatement) NAZARA_SHADERAST_STATEMENT_LAST(WhileStatement)
#undef NAZARA_SHADERAST_EXPRESSION #undef NAZARA_SHADERAST_EXPRESSION

View File

@ -57,6 +57,8 @@ namespace Nz::ShaderAst
template<typename TargetType> ExpressionPtr PropagateVec3Cast(TargetType v1, TargetType v2, TargetType v3); template<typename TargetType> ExpressionPtr PropagateVec3Cast(TargetType v1, TargetType v2, TargetType v3);
template<typename TargetType> ExpressionPtr PropagateVec4Cast(TargetType v1, TargetType v2, TargetType v3, TargetType v4); template<typename TargetType> ExpressionPtr PropagateVec4Cast(TargetType v1, TargetType v2, TargetType v3, TargetType v4);
StatementPtr Unscope(StatementPtr node);
private: private:
Options m_options; Options m_options;
}; };

View File

@ -51,6 +51,7 @@ namespace Nz::ShaderAst
void Visit(MultiStatement& node) override; void Visit(MultiStatement& node) override;
void Visit(NoOpStatement& node) override; void Visit(NoOpStatement& node) override;
void Visit(ReturnStatement& node) override; void Visit(ReturnStatement& node) override;
void Visit(ScopedStatement& node) override;
void Visit(WhileStatement& node) override; void Visit(WhileStatement& node) override;
}; };
} }

View File

@ -32,7 +32,7 @@ namespace Nz::ShaderAst
struct Callbacks struct Callbacks
{ {
std::function<void(ShaderStageType stageType, const std::string& functionName)> onEntryPointDeclaration; std::function<void(ShaderStageType stageType, const std::string& functionName)> onEntryPointDeclaration;
std::function<void(const std::string& optionName, const ExpressionType& optionType)> onOptionDeclaration; std::function<void(const std::string& optionName, const ExpressionValue<ExpressionType>& optionType)> onOptionDeclaration;
}; };
private: private:

View File

@ -54,12 +54,13 @@ namespace Nz::ShaderAst
void Serialize(MultiStatement& node); void Serialize(MultiStatement& node);
void Serialize(NoOpStatement& node); void Serialize(NoOpStatement& node);
void Serialize(ReturnStatement& node); void Serialize(ReturnStatement& node);
void Serialize(ScopedStatement& node);
void Serialize(WhileStatement& node); void Serialize(WhileStatement& node);
protected: protected:
template<typename T> void Attribute(AttributeValue<T>& attribute);
template<typename T> void Container(T& container); template<typename T> void Container(T& container);
template<typename T> void Enum(T& enumVal); template<typename T> void Enum(T& enumVal);
template<typename T> void ExprValue(ExpressionValue<T>& attribute);
template<typename T> void OptEnum(std::optional<T>& optVal); template<typename T> void OptEnum(std::optional<T>& optVal);
template<typename T> void OptVal(std::optional<T>& optVal); template<typename T> void OptVal(std::optional<T>& optVal);

View File

@ -3,12 +3,42 @@
// For conditions of distribution and use, see copyright notice in Config.hpp // For conditions of distribution and use, see copyright notice in Config.hpp
#include <Nazara/Shader/Ast/AstSerializer.hpp> #include <Nazara/Shader/Ast/AstSerializer.hpp>
#include <Nazara/Core/Algorithm.hpp>
#include <Nazara/Shader/Debug.hpp> #include <Nazara/Shader/Debug.hpp>
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
template<typename T> template<typename T>
void AstSerializerBase::Attribute(AttributeValue<T>& attribute) void AstSerializerBase::Container(T& container)
{
bool isWriting = IsWriting();
UInt32 size;
if (isWriting)
size = SafeCast<UInt32>(container.size());
Value(size);
if (!isWriting)
container.resize(size);
}
template<typename T>
void AstSerializerBase::Enum(T& enumVal)
{
bool isWriting = IsWriting();
UInt32 value;
if (isWriting)
value = SafeCast<UInt32>(enumVal);
Value(value);
if (!isWriting)
enumVal = static_cast<T>(value);
}
template<typename T>
void AstSerializerBase::ExprValue(ExpressionValue<T>& attribute)
{ {
UInt32 valueType; UInt32 valueType;
if (IsWriting()) if (IsWriting())
@ -55,6 +85,8 @@ namespace Nz::ShaderAst
T value; T value;
if constexpr (std::is_enum_v<T>) if constexpr (std::is_enum_v<T>)
Enum(value); Enum(value);
else if constexpr (std::is_same_v<T, ExpressionType>)
Type(value);
else else
Value(value); Value(value);
@ -65,6 +97,8 @@ namespace Nz::ShaderAst
T& value = const_cast<T&>(attribute.GetResultingValue()); //< not used for writing T& value = const_cast<T&>(attribute.GetResultingValue()); //< not used for writing
if constexpr (std::is_enum_v<T>) if constexpr (std::is_enum_v<T>)
Enum(value); Enum(value);
else if constexpr (std::is_same_v<T, ExpressionType>)
Type(value);
else else
Value(value); Value(value);
} }
@ -74,35 +108,6 @@ namespace Nz::ShaderAst
} }
} }
template<typename T>
void AstSerializerBase::Container(T& container)
{
bool isWriting = IsWriting();
UInt32 size;
if (isWriting)
size = UInt32(container.size());
Value(size);
if (!isWriting)
container.resize(size);
}
template<typename T>
void AstSerializerBase::Enum(T& enumVal)
{
bool isWriting = IsWriting();
UInt32 value;
if (isWriting)
value = static_cast<UInt32>(enumVal);
Value(value);
if (!isWriting)
enumVal = static_cast<T>(value);
}
template<typename T> template<typename T>
void AstSerializerBase::OptEnum(std::optional<T>& optVal) void AstSerializerBase::OptEnum(std::optional<T>& optVal)
{ {
@ -150,12 +155,12 @@ namespace Nz::ShaderAst
UInt32 fixedVal; UInt32 fixedVal;
if (isWriting) if (isWriting)
fixedVal = static_cast<UInt32>(val); fixedVal = SafeCast<UInt32>(val);
Value(fixedVal); Value(fixedVal);
if (!isWriting) if (!isWriting)
val = static_cast<std::size_t>(fixedVal); val = SafeCast<std::size_t>(fixedVal);
} }
inline ShaderAstSerializer::ShaderAstSerializer(ByteStream& stream) : inline ShaderAstSerializer::ShaderAstSerializer(ByteStream& stream) :

View File

@ -13,7 +13,7 @@
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
class NAZARA_SHADER_API StatementVisitorExcept : public AstStatementVisitor class NAZARA_SHADER_API AstStatementVisitorExcept : public AstStatementVisitor
{ {
public: public:
using AstStatementVisitor::Visit; using AstStatementVisitor::Visit;

View File

@ -0,0 +1,36 @@
// Copyright (C) 2022 Jérôme "Lynix" Leclercq (lynix680@gmail.com)
// This file is part of the "Nazara Engine - Shader module"
// For conditions of distribution and use, see copyright notice in Config.hpp
#pragma once
#ifndef NAZARA_SHADER_AST_ASTTYPES_HPP
#define NAZARA_SHADER_AST_ASTTYPES_HPP
#include <Nazara/Shader/Ast/ConstantValue.hpp>
#include <Nazara/Shader/Ast/ExpressionType.hpp>
#include <functional>
namespace Nz::ShaderAst
{
enum class TypeParameterCategory
{
ConstantValue,
FullType,
PrimitiveType,
StructType
};
struct PartialType;
using TypeParameter = std::variant<ConstantValue, ExpressionType, PartialType>;
struct PartialType
{
std::vector<TypeParameterCategory> parameters;
std::function<ExpressionType(const TypeParameter* parameters, std::size_t parameterCount)> buildFunc;
};
}
#endif // NAZARA_SHADER_AST_ASTTYPES_HPP

View File

@ -20,15 +20,15 @@ namespace Nz::ShaderAst
using ExpressionPtr = std::unique_ptr<Expression>; using ExpressionPtr = std::unique_ptr<Expression>;
template<typename T> template<typename T>
class AttributeValue class ExpressionValue
{ {
public: public:
AttributeValue() = default; ExpressionValue() = default;
AttributeValue(T value); ExpressionValue(T value);
AttributeValue(ExpressionPtr expr); ExpressionValue(ExpressionPtr expr);
AttributeValue(const AttributeValue&) = default; ExpressionValue(const ExpressionValue&) = default;
AttributeValue(AttributeValue&&) = default; ExpressionValue(ExpressionValue&&) noexcept = default;
~AttributeValue() = default; ~ExpressionValue() = default;
ExpressionPtr&& GetExpression() &&; ExpressionPtr&& GetExpression() &&;
const ExpressionPtr& GetExpression() const &; const ExpressionPtr& GetExpression() const &;
@ -39,14 +39,14 @@ namespace Nz::ShaderAst
bool HasValue() const; bool HasValue() const;
AttributeValue& operator=(const AttributeValue&) = default; ExpressionValue& operator=(const ExpressionValue&) = default;
AttributeValue& operator=(AttributeValue&&) = default; ExpressionValue& operator=(ExpressionValue&&) noexcept = default;
private: private:
std::variant<std::monostate, T, ExpressionPtr> m_value; std::variant<std::monostate, T, ExpressionPtr> m_value;
}; };
struct Attribute struct ExprValue
{ {
using Param = std::optional<ExpressionPtr>; using Param = std::optional<ExpressionPtr>;

View File

@ -10,20 +10,20 @@
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
template<typename T> template<typename T>
AttributeValue<T>::AttributeValue(T value) : ExpressionValue<T>::ExpressionValue(T value) :
m_value(std::move(value)) m_value(std::move(value))
{ {
} }
template<typename T> template<typename T>
AttributeValue<T>::AttributeValue(ExpressionPtr expr) ExpressionValue<T>::ExpressionValue(ExpressionPtr expr)
{ {
assert(expr); assert(expr);
m_value = std::move(expr); m_value = std::move(expr);
} }
template<typename T> template<typename T>
ExpressionPtr&& AttributeValue<T>::GetExpression() && ExpressionPtr&& ExpressionValue<T>::GetExpression() &&
{ {
if (!IsExpression()) if (!IsExpression())
throw std::runtime_error("excepted expression"); throw std::runtime_error("excepted expression");
@ -32,7 +32,7 @@ namespace Nz::ShaderAst
} }
template<typename T> template<typename T>
const ExpressionPtr& AttributeValue<T>::GetExpression() const & const ExpressionPtr& ExpressionValue<T>::GetExpression() const &
{ {
if (!IsExpression()) if (!IsExpression())
throw std::runtime_error("excepted expression"); throw std::runtime_error("excepted expression");
@ -42,7 +42,7 @@ namespace Nz::ShaderAst
} }
template<typename T> template<typename T>
const T& AttributeValue<T>::GetResultingValue() const const T& ExpressionValue<T>::GetResultingValue() const
{ {
if (!IsResultingValue()) if (!IsResultingValue())
throw std::runtime_error("excepted resulting value"); throw std::runtime_error("excepted resulting value");
@ -51,19 +51,19 @@ namespace Nz::ShaderAst
} }
template<typename T> template<typename T>
bool AttributeValue<T>::IsExpression() const bool ExpressionValue<T>::IsExpression() const
{ {
return std::holds_alternative<ExpressionPtr>(m_value); return std::holds_alternative<ExpressionPtr>(m_value);
} }
template<typename T> template<typename T>
bool AttributeValue<T>::IsResultingValue() const bool ExpressionValue<T>::IsResultingValue() const
{ {
return std::holds_alternative<T>(m_value); return std::holds_alternative<T>(m_value);
} }
template<typename T> template<typename T>
bool AttributeValue<T>::HasValue() const bool ExpressionValue<T>::HasValue() const
{ {
return !std::holds_alternative<std::monostate>(m_value); return !std::holds_alternative<std::monostate>(m_value);
} }

View File

@ -29,14 +29,22 @@ namespace Nz::ShaderAst
ArrayType& operator=(const ArrayType& array); ArrayType& operator=(const ArrayType& array);
ArrayType& operator=(ArrayType&&) noexcept = default; ArrayType& operator=(ArrayType&&) noexcept = default;
AttributeValue<UInt32> length; UInt32 length;
std::unique_ptr<ContainedType> containedType; std::unique_ptr<ContainedType> containedType;
bool operator==(const ArrayType& rhs) const; bool operator==(const ArrayType& rhs) const;
inline bool operator!=(const ArrayType& rhs) const; inline bool operator!=(const ArrayType& rhs) const;
}; };
struct IdentifierType //< Alias or struct struct FunctionType
{
std::size_t funcIndex;
inline bool operator==(const FunctionType& rhs) const;
inline bool operator!=(const FunctionType& rhs) const;
};
struct IdentifierType
{ {
std::string name; std::string name;
@ -44,6 +52,14 @@ namespace Nz::ShaderAst
inline bool operator!=(const IdentifierType& rhs) const; inline bool operator!=(const IdentifierType& rhs) const;
}; };
struct IntrinsicFunctionType
{
IntrinsicType intrinsic;
inline bool operator==(const IntrinsicFunctionType& rhs) const;
inline bool operator!=(const IntrinsicFunctionType& rhs) const;
};
struct MatrixType struct MatrixType
{ {
std::size_t columnCount; std::size_t columnCount;
@ -54,6 +70,22 @@ namespace Nz::ShaderAst
inline bool operator!=(const MatrixType& rhs) const; inline bool operator!=(const MatrixType& rhs) const;
}; };
struct NAZARA_SHADER_API MethodType
{
MethodType() = default;
MethodType(const MethodType& methodType);
MethodType(MethodType&&) noexcept = default;
MethodType& operator=(const MethodType& methodType);
MethodType& operator=(MethodType&&) noexcept = default;
std::unique_ptr<ContainedType> objectType;
std::size_t methodIndex;
bool operator==(const MethodType& rhs) const;
inline bool operator!=(const MethodType& rhs) const;
};
struct NoType struct NoType
{ {
inline bool operator==(const NoType& rhs) const; inline bool operator==(const NoType& rhs) const;
@ -77,9 +109,17 @@ namespace Nz::ShaderAst
inline bool operator!=(const StructType& rhs) const; inline bool operator!=(const StructType& rhs) const;
}; };
struct Type
{
std::size_t typeIndex;
inline bool operator==(const Type& rhs) const;
inline bool operator!=(const Type& rhs) const;
};
struct UniformType struct UniformType
{ {
std::variant<IdentifierType, StructType> containedType; StructType containedType;
inline bool operator==(const UniformType& rhs) const; inline bool operator==(const UniformType& rhs) const;
inline bool operator!=(const UniformType& rhs) const; inline bool operator!=(const UniformType& rhs) const;
@ -94,7 +134,7 @@ namespace Nz::ShaderAst
inline bool operator!=(const VectorType& rhs) const; inline bool operator!=(const VectorType& rhs) const;
}; };
using ExpressionType = std::variant<NoType, ArrayType, IdentifierType, PrimitiveType, MatrixType, SamplerType, StructType, UniformType, VectorType>; using ExpressionType = std::variant<NoType, ArrayType, FunctionType, IdentifierType, IntrinsicFunctionType, PrimitiveType, MatrixType, MethodType, SamplerType, StructType, Type, UniformType, VectorType>;
struct ContainedType struct ContainedType
{ {
@ -105,25 +145,29 @@ namespace Nz::ShaderAst
{ {
struct StructMember struct StructMember
{ {
AttributeValue<BuiltinEntry> builtin; ExpressionValue<BuiltinEntry> builtin;
AttributeValue<bool> cond; ExpressionValue<bool> cond;
AttributeValue<UInt32> locationIndex; ExpressionValue<UInt32> locationIndex;
ExpressionValue<ExpressionType> type;
std::string name; std::string name;
ExpressionType type;
}; };
AttributeValue<StructLayout> layout; ExpressionValue<StructLayout> layout;
std::string name; std::string name;
std::vector<StructMember> members; std::vector<StructMember> members;
}; };
inline bool IsArrayType(const ExpressionType& type); inline bool IsArrayType(const ExpressionType& type);
inline bool IsFunctionType(const ExpressionType& type);
inline bool IsIdentifierType(const ExpressionType& type); inline bool IsIdentifierType(const ExpressionType& type);
inline bool IsIntrinsicFunctionType(const ExpressionType& type);
inline bool IsMatrixType(const ExpressionType& type); inline bool IsMatrixType(const ExpressionType& type);
inline bool IsMethodType(const ExpressionType& type);
inline bool IsNoType(const ExpressionType& type); inline bool IsNoType(const ExpressionType& type);
inline bool IsPrimitiveType(const ExpressionType& type); inline bool IsPrimitiveType(const ExpressionType& type);
inline bool IsSamplerType(const ExpressionType& type); inline bool IsSamplerType(const ExpressionType& type);
inline bool IsStructType(const ExpressionType& type); inline bool IsStructType(const ExpressionType& type);
inline bool IsTypeExpression(const ExpressionType& type);
inline bool IsUniformType(const ExpressionType& type); inline bool IsUniformType(const ExpressionType& type);
inline bool IsVectorType(const ExpressionType& type); inline bool IsVectorType(const ExpressionType& type);
} }

View File

@ -14,6 +14,17 @@ namespace Nz::ShaderAst
} }
inline bool FunctionType::operator==(const FunctionType& rhs) const
{
return funcIndex == rhs.funcIndex;
}
inline bool FunctionType::operator!=(const FunctionType& rhs) const
{
return !operator==(rhs);
}
inline bool IdentifierType::operator==(const IdentifierType& rhs) const inline bool IdentifierType::operator==(const IdentifierType& rhs) const
{ {
return name == rhs.name; return name == rhs.name;
@ -25,6 +36,17 @@ namespace Nz::ShaderAst
} }
inline bool IntrinsicFunctionType::operator==(const IntrinsicFunctionType& rhs) const
{
return intrinsic == rhs.intrinsic;
}
inline bool IntrinsicFunctionType::operator!=(const IntrinsicFunctionType& rhs) const
{
return !operator==(rhs);
}
inline bool MatrixType::operator==(const MatrixType& rhs) const inline bool MatrixType::operator==(const MatrixType& rhs) const
{ {
return columnCount == rhs.columnCount && rowCount == rhs.rowCount && type == rhs.type; return columnCount == rhs.columnCount && rowCount == rhs.rowCount && type == rhs.type;
@ -36,6 +58,12 @@ namespace Nz::ShaderAst
} }
inline bool MethodType::operator!=(const MethodType& rhs) const
{
return !operator==(rhs);
}
inline bool NoType::operator==(const NoType& /*rhs*/) const inline bool NoType::operator==(const NoType& /*rhs*/) const
{ {
return true; return true;
@ -68,6 +96,18 @@ namespace Nz::ShaderAst
return !operator==(rhs); return !operator==(rhs);
} }
inline bool Type::operator==(const Type& rhs) const
{
return typeIndex == rhs.typeIndex;
}
inline bool Type::operator!=(const Type& rhs) const
{
return !operator==(rhs);
}
inline bool UniformType::operator==(const UniformType& rhs) const inline bool UniformType::operator==(const UniformType& rhs) const
{ {
return containedType == rhs.containedType; return containedType == rhs.containedType;
@ -90,21 +130,36 @@ namespace Nz::ShaderAst
} }
bool IsArrayType(const ExpressionType& type) inline bool IsArrayType(const ExpressionType& type)
{ {
return std::holds_alternative<ArrayType>(type); return std::holds_alternative<ArrayType>(type);
} }
inline bool IsFunctionType(const ExpressionType& type)
{
return std::holds_alternative<FunctionType>(type);
}
inline bool IsIdentifierType(const ExpressionType& type) inline bool IsIdentifierType(const ExpressionType& type)
{ {
return std::holds_alternative<IdentifierType>(type); return std::holds_alternative<IdentifierType>(type);
} }
inline bool IsIntrinsicFunctionType(const ExpressionType& type)
{
return std::holds_alternative<IntrinsicFunctionType>(type);
}
inline bool IsMatrixType(const ExpressionType& type) inline bool IsMatrixType(const ExpressionType& type)
{ {
return std::holds_alternative<MatrixType>(type); return std::holds_alternative<MatrixType>(type);
} }
inline bool IsMethodType(const ExpressionType& type)
{
return std::holds_alternative<MethodType>(type);
}
inline bool IsNoType(const ExpressionType& type) inline bool IsNoType(const ExpressionType& type)
{ {
return std::holds_alternative<NoType>(type); return std::holds_alternative<NoType>(type);
@ -125,6 +180,11 @@ namespace Nz::ShaderAst
return std::holds_alternative<StructType>(type); return std::holds_alternative<StructType>(type);
} }
bool IsTypeExpression(const ExpressionType& type)
{
return std::holds_alternative<Type>(type);
}
bool IsUniformType(const ExpressionType& type) bool IsUniformType(const ExpressionType& type)
{ {
return std::holds_alternative<UniformType>(type); return std::holds_alternative<UniformType>(type);

View File

@ -107,7 +107,7 @@ namespace Nz::ShaderAst
NodeType GetType() const override; NodeType GetType() const override;
void Visit(AstExpressionVisitor& visitor) override; void Visit(AstExpressionVisitor& visitor) override;
std::variant<std::string, std::size_t> targetFunction; ExpressionPtr targetFunction;
std::vector<ExpressionPtr> parameters; std::vector<ExpressionPtr> parameters;
}; };
@ -126,7 +126,7 @@ namespace Nz::ShaderAst
NodeType GetType() const override; NodeType GetType() const override;
void Visit(AstExpressionVisitor& visitor) override; void Visit(AstExpressionVisitor& visitor) override;
ExpressionType targetType; ExpressionValue<ExpressionType> targetType;
std::array<ExpressionPtr, 4> expressions; std::array<ExpressionPtr, 4> expressions;
}; };
@ -249,10 +249,10 @@ namespace Nz::ShaderAst
NodeType GetType() const override; NodeType GetType() const override;
void Visit(AstStatementVisitor& visitor) override; void Visit(AstStatementVisitor& visitor) override;
ExpressionValue<ExpressionType> type;
std::optional<std::size_t> constIndex; std::optional<std::size_t> constIndex;
std::string name; std::string name;
ExpressionPtr expression; ExpressionPtr expression;
ExpressionType type;
}; };
struct NAZARA_SHADER_API DeclareExternalStatement : Statement struct NAZARA_SHADER_API DeclareExternalStatement : Statement
@ -262,13 +262,13 @@ namespace Nz::ShaderAst
struct ExternalVar struct ExternalVar
{ {
AttributeValue<UInt32> bindingIndex; ExpressionValue<UInt32> bindingIndex;
AttributeValue<UInt32> bindingSet; ExpressionValue<UInt32> bindingSet;
ExpressionValue<ExpressionType> type;
std::string name; std::string name;
ExpressionType type;
}; };
AttributeValue<UInt32> bindingSet; ExpressionValue<UInt32> bindingSet;
std::optional<std::size_t> varIndex; std::optional<std::size_t> varIndex;
std::vector<ExternalVar> externalVars; std::vector<ExternalVar> externalVars;
}; };
@ -281,18 +281,18 @@ namespace Nz::ShaderAst
struct Parameter struct Parameter
{ {
std::string name; std::string name;
ExpressionType type; ExpressionValue<ExpressionType> type;
}; };
AttributeValue<DepthWriteMode> depthWrite; ExpressionValue<DepthWriteMode> depthWrite;
AttributeValue<bool> earlyFragmentTests; ExpressionValue<bool> earlyFragmentTests;
AttributeValue<ShaderStageType> entryStage; ExpressionValue<ShaderStageType> entryStage;
ExpressionValue<ExpressionType> returnType;
std::optional<std::size_t> funcIndex; std::optional<std::size_t> funcIndex;
std::optional<std::size_t> varIndex; std::optional<std::size_t> varIndex;
std::string name; std::string name;
std::vector<Parameter> parameters; std::vector<Parameter> parameters;
std::vector<StatementPtr> statements; std::vector<StatementPtr> statements;
ExpressionType returnType;
}; };
struct NAZARA_SHADER_API DeclareOptionStatement : Statement struct NAZARA_SHADER_API DeclareOptionStatement : Statement
@ -303,7 +303,7 @@ namespace Nz::ShaderAst
std::optional<std::size_t> optIndex; std::optional<std::size_t> optIndex;
std::string optName; std::string optName;
ExpressionPtr defaultValue; ExpressionPtr defaultValue;
ExpressionType optType; ExpressionValue<ExpressionType> optType;
}; };
struct NAZARA_SHADER_API DeclareStructStatement : Statement struct NAZARA_SHADER_API DeclareStructStatement : Statement
@ -323,7 +323,7 @@ namespace Nz::ShaderAst
std::optional<std::size_t> varIndex; std::optional<std::size_t> varIndex;
std::string varName; std::string varName;
ExpressionPtr initialExpression; ExpressionPtr initialExpression;
ExpressionType varType; ExpressionValue<ExpressionType> varType;
}; };
struct NAZARA_SHADER_API DiscardStatement : Statement struct NAZARA_SHADER_API DiscardStatement : Statement
@ -345,7 +345,7 @@ namespace Nz::ShaderAst
NodeType GetType() const override; NodeType GetType() const override;
void Visit(AstStatementVisitor& visitor) override; void Visit(AstStatementVisitor& visitor) override;
AttributeValue<LoopUnroll> unroll; ExpressionValue<LoopUnroll> unroll;
std::optional<std::size_t> varIndex; std::optional<std::size_t> varIndex;
std::string varName; std::string varName;
ExpressionPtr fromExpr; ExpressionPtr fromExpr;
@ -359,7 +359,7 @@ namespace Nz::ShaderAst
NodeType GetType() const override; NodeType GetType() const override;
void Visit(AstStatementVisitor& visitor) override; void Visit(AstStatementVisitor& visitor) override;
AttributeValue<LoopUnroll> unroll; ExpressionValue<LoopUnroll> unroll;
std::optional<std::size_t> varIndex; std::optional<std::size_t> varIndex;
std::string varName; std::string varName;
ExpressionPtr expression; ExpressionPtr expression;
@ -388,12 +388,20 @@ namespace Nz::ShaderAst
ExpressionPtr returnExpr; ExpressionPtr returnExpr;
}; };
struct NAZARA_SHADER_API ScopedStatement : Statement
{
NodeType GetType() const override;
void Visit(AstStatementVisitor& visitor) override;
StatementPtr statement;
};
struct NAZARA_SHADER_API WhileStatement : Statement struct NAZARA_SHADER_API WhileStatement : Statement
{ {
NodeType GetType() const override; NodeType GetType() const override;
void Visit(AstStatementVisitor& visitor) override; void Visit(AstStatementVisitor& visitor) override;
AttributeValue<LoopUnroll> unroll; ExpressionValue<LoopUnroll> unroll;
ExpressionPtr condition; ExpressionPtr condition;
StatementPtr body; StatementPtr body;
}; };

View File

@ -11,6 +11,7 @@
#include <Nazara/Core/Bitset.hpp> #include <Nazara/Core/Bitset.hpp>
#include <Nazara/Shader/Config.hpp> #include <Nazara/Shader/Config.hpp>
#include <Nazara/Shader/Ast/AstCloner.hpp> #include <Nazara/Shader/Ast/AstCloner.hpp>
#include <Nazara/Shader/Ast/AstTypes.hpp>
#include <unordered_map> #include <unordered_map>
#include <unordered_set> #include <unordered_set>
#include <vector> #include <vector>
@ -19,6 +20,8 @@ namespace Nz::ShaderAst
{ {
class NAZARA_SHADER_API SanitizeVisitor final : AstCloner class NAZARA_SHADER_API SanitizeVisitor final : AstCloner
{ {
friend class AstTypeExpressionVisitor;
public: public:
struct Options; struct Options;
@ -55,6 +58,7 @@ namespace Nz::ShaderAst
struct Identifier; struct Identifier;
using AstCloner::CloneExpression; using AstCloner::CloneExpression;
ExpressionValue<ExpressionType> CloneType(const ExpressionValue<ExpressionType>& exprType) override;
ExpressionPtr Clone(AccessIdentifierExpression& node) override; ExpressionPtr Clone(AccessIdentifierExpression& node) override;
ExpressionPtr Clone(AccessIndexExpression& node) override; ExpressionPtr Clone(AccessIndexExpression& node) override;
@ -84,50 +88,58 @@ namespace Nz::ShaderAst
StatementPtr Clone(ForStatement& node) override; StatementPtr Clone(ForStatement& node) override;
StatementPtr Clone(ForEachStatement& node) override; StatementPtr Clone(ForEachStatement& node) override;
StatementPtr Clone(MultiStatement& node) override; StatementPtr Clone(MultiStatement& node) override;
StatementPtr Clone(ScopedStatement& node) override;
StatementPtr Clone(WhileStatement& node) override; StatementPtr Clone(WhileStatement& node) override;
const Identifier* FindIdentifier(const std::string_view& identifierName) const; const Identifier* FindIdentifier(const std::string_view& identifierName) const;
template<typename F> const Identifier* FindIdentifier(const std::string_view& identifierName, F&& functor) const;
TypeParameter FindTypeParameter(const std::string_view& identifierName) const;
Expression& MandatoryExpr(const ExpressionPtr& node); Expression& MandatoryExpr(const ExpressionPtr& node) const;
Statement& MandatoryStatement(const StatementPtr& node); Statement& MandatoryStatement(const StatementPtr& node) const;
void TypeMustMatch(const ExpressionPtr& left, const ExpressionPtr& right);
void TypeMustMatch(const ExpressionType& left, const ExpressionType& right);
void PushScope(); void PushScope();
void PopScope(); void PopScope();
ExpressionPtr CacheResult(ExpressionPtr expression); ExpressionPtr CacheResult(ExpressionPtr expression);
template<typename T> const T& ComputeAttributeValue(AttributeValue<T>& attribute); ConstantValue ComputeConstantValue(Expression& expr) const;
ConstantValue ComputeConstantValue(Expression& expr); template<typename T> const T& ComputeExprValue(ExpressionValue<T>& attribute) const;
template<typename T> std::unique_ptr<T> Optimize(T& node); template<typename T> std::unique_ptr<T> Optimize(T& node) const;
std::size_t DeclareFunction(DeclareFunctionStatement& funcDecl);
void PropagateFunctionFlags(std::size_t funcIndex, FunctionFlags flags, Bitset<>& seen); void PropagateFunctionFlags(std::size_t funcIndex, FunctionFlags flags, Bitset<>& seen);
void RegisterBuiltin();
std::size_t RegisterConstant(std::string name, ConstantValue value); std::size_t RegisterConstant(std::string name, ConstantValue value);
FunctionData& RegisterFunction(std::size_t functionIndex); std::size_t RegisterFunction(std::string name, FunctionData funcData);
std::size_t RegisterIntrinsic(std::string name, IntrinsicType type); std::size_t RegisterIntrinsic(std::string name, IntrinsicType type);
std::size_t RegisterStruct(std::string name, StructDescription* description); std::size_t RegisterStruct(std::string name, StructDescription* description);
std::size_t RegisterType(std::string name, ExpressionType expressionType);
std::size_t RegisterType(std::string name, PartialType partialType);
std::size_t RegisterVariable(std::string name, ExpressionType type); std::size_t RegisterVariable(std::string name, ExpressionType type);
void ResolveFunctions(); void ResolveFunctions();
const ExpressionPtr& ResolveCondExpression(ConditionalExpression& node);
std::size_t ResolveStruct(const ExpressionType& exprType); std::size_t ResolveStruct(const ExpressionType& exprType);
std::size_t ResolveStruct(const IdentifierType& identifierType); std::size_t ResolveStruct(const IdentifierType& identifierType);
std::size_t ResolveStruct(const StructType& structType); std::size_t ResolveStruct(const StructType& structType);
std::size_t ResolveStruct(const UniformType& uniformType); std::size_t ResolveStruct(const UniformType& uniformType);
ExpressionType ResolveType(const ExpressionType& exprType); ExpressionType ResolveType(const ExpressionType& exprType);
ExpressionType ResolveType(const ExpressionValue<ExpressionType>& exprTypeValue);
void SanitizeIdentifier(std::string& identifier); void SanitizeIdentifier(std::string& identifier);
void TypeMustMatch(const ExpressionPtr& left, const ExpressionPtr& right) const;
void TypeMustMatch(const ExpressionType& left, const ExpressionType& right) const;
StatementPtr Unscope(StatementPtr node);
void Validate(WhileStatement& node); void Validate(WhileStatement& node);
void Validate(AccessIndexExpression& node); void Validate(AccessIndexExpression& node);
void Validate(AssignExpression& node); void Validate(AssignExpression& node);
void Validate(BinaryExpression& node); void Validate(BinaryExpression& node);
void Validate(CallFunctionExpression& node, const DeclareFunctionStatement* referenceDeclaration); void Validate(CallFunctionExpression& node);
void Validate(CastExpression& node); void Validate(CastExpression& node);
void Validate(DeclareVariableStatement& node); void Validate(DeclareVariableStatement& node);
void Validate(IntrinsicExpression& node); void Validate(IntrinsicExpression& node);
@ -141,7 +153,6 @@ namespace Nz::ShaderAst
Bitset<> calledByFunctions; Bitset<> calledByFunctions;
DeclareFunctionStatement* node; DeclareFunctionStatement* node;
FunctionFlags flags; FunctionFlags flags;
bool defined = false;
}; };
struct Identifier struct Identifier
@ -153,6 +164,7 @@ namespace Nz::ShaderAst
Function, Function,
Intrinsic, Intrinsic,
Struct, Struct,
Type,
Variable Variable
}; };

View File

@ -19,7 +19,7 @@
namespace Nz namespace Nz
{ {
class NAZARA_SHADER_API GlslWriter : public ShaderWriter, public ShaderAst::ExpressionVisitorExcept, public ShaderAst::StatementVisitorExcept class NAZARA_SHADER_API GlslWriter : public ShaderWriter, public ShaderAst::AstExpressionVisitorExcept, public ShaderAst::AstStatementVisitorExcept
{ {
public: public:
using BindingMapping = std::unordered_map<UInt64 /* set | binding */, unsigned /*glBinding*/>; using BindingMapping = std::unordered_map<UInt64 /* set | binding */, unsigned /*glBinding*/>;
@ -51,15 +51,20 @@ namespace Nz
private: private:
void Append(const ShaderAst::ArrayType& type); void Append(const ShaderAst::ArrayType& type);
void Append(const ShaderAst::ExpressionType& type);
void Append(ShaderAst::BuiltinEntry builtin); void Append(ShaderAst::BuiltinEntry builtin);
void Append(const ShaderAst::ExpressionType& type);
void Append(const ShaderAst::ExpressionValue<ShaderAst::ExpressionType>& type);
void Append(const ShaderAst::FunctionType& functionType);
void Append(const ShaderAst::IdentifierType& identifierType); void Append(const ShaderAst::IdentifierType& identifierType);
void Append(const ShaderAst::IntrinsicFunctionType& intrinsicFunctionType);
void Append(const ShaderAst::MatrixType& matrixType); void Append(const ShaderAst::MatrixType& matrixType);
void Append(const ShaderAst::MethodType& methodType);
void Append(ShaderAst::MemoryLayout layout); void Append(ShaderAst::MemoryLayout layout);
void Append(ShaderAst::NoType); void Append(ShaderAst::NoType);
void Append(ShaderAst::PrimitiveType type); void Append(ShaderAst::PrimitiveType type);
void Append(const ShaderAst::SamplerType& samplerType); void Append(const ShaderAst::SamplerType& samplerType);
void Append(const ShaderAst::StructType& structType); void Append(const ShaderAst::StructType& structType);
void Append(const ShaderAst::Type& type);
void Append(const ShaderAst::UniformType& uniformType); void Append(const ShaderAst::UniformType& uniformType);
void Append(const ShaderAst::VectorType& vecType); void Append(const ShaderAst::VectorType& vecType);
template<typename T> void Append(const T& param); template<typename T> void Append(const T& param);
@ -81,6 +86,8 @@ namespace Nz
void RegisterStruct(std::size_t structIndex, ShaderAst::StructDescription* desc); void RegisterStruct(std::size_t structIndex, ShaderAst::StructDescription* desc);
void RegisterVariable(std::size_t varIndex, std::string varName); void RegisterVariable(std::size_t varIndex, std::string varName);
void ScopeVisit(ShaderAst::Statement& node);
void Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired = false); void Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired = false);
void Visit(ShaderAst::AccessIdentifierExpression& node) override; void Visit(ShaderAst::AccessIdentifierExpression& node) override;
@ -107,6 +114,7 @@ namespace Nz
void Visit(ShaderAst::MultiStatement& node) override; void Visit(ShaderAst::MultiStatement& node) override;
void Visit(ShaderAst::NoOpStatement& node) override; void Visit(ShaderAst::NoOpStatement& node) override;
void Visit(ShaderAst::ReturnStatement& node) override; void Visit(ShaderAst::ReturnStatement& node) override;
void Visit(ShaderAst::ScopedStatement& node) override;
void Visit(ShaderAst::WhileStatement& node) override; void Visit(ShaderAst::WhileStatement& node) override;
static bool HasExplicitBinding(ShaderAst::StatementPtr& shader); static bool HasExplicitBinding(ShaderAst::StatementPtr& shader);

View File

@ -18,7 +18,7 @@
namespace Nz namespace Nz
{ {
class NAZARA_SHADER_API LangWriter : public ShaderWriter, public ShaderAst::ExpressionVisitorExcept, public ShaderAst::StatementVisitorExcept class NAZARA_SHADER_API LangWriter : public ShaderWriter, public ShaderAst::AstExpressionVisitorExcept, public ShaderAst::AstStatementVisitorExcept
{ {
public: public:
struct Environment; struct Environment;
@ -49,12 +49,17 @@ namespace Nz
void Append(const ShaderAst::ArrayType& type); void Append(const ShaderAst::ArrayType& type);
void Append(const ShaderAst::ExpressionType& type); void Append(const ShaderAst::ExpressionType& type);
void Append(const ShaderAst::ExpressionValue<ShaderAst::ExpressionType>& type);
void Append(const ShaderAst::FunctionType& functionType);
void Append(const ShaderAst::IdentifierType& identifierType); void Append(const ShaderAst::IdentifierType& identifierType);
void Append(const ShaderAst::IntrinsicFunctionType& intrinsicFunctionType);
void Append(const ShaderAst::MatrixType& matrixType); void Append(const ShaderAst::MatrixType& matrixType);
void Append(const ShaderAst::MethodType& methodType);
void Append(ShaderAst::NoType); void Append(ShaderAst::NoType);
void Append(ShaderAst::PrimitiveType type); void Append(ShaderAst::PrimitiveType type);
void Append(const ShaderAst::SamplerType& samplerType); void Append(const ShaderAst::SamplerType& samplerType);
void Append(const ShaderAst::StructType& structType); void Append(const ShaderAst::StructType& structType);
void Append(const ShaderAst::Type& type);
void Append(const ShaderAst::UniformType& uniformType); void Append(const ShaderAst::UniformType& uniformType);
void Append(const ShaderAst::VectorType& vecType); void Append(const ShaderAst::VectorType& vecType);
template<typename T> void Append(const T& param); template<typename T> void Append(const T& param);
@ -84,6 +89,8 @@ namespace Nz
void RegisterStruct(std::size_t structIndex, ShaderAst::StructDescription* desc); void RegisterStruct(std::size_t structIndex, ShaderAst::StructDescription* desc);
void RegisterVariable(std::size_t varIndex, std::string varName); void RegisterVariable(std::size_t varIndex, std::string varName);
void ScopeVisit(ShaderAst::Statement& node);
void Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired = false); void Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired = false);
void Visit(ShaderAst::AccessIdentifierExpression& node) override; void Visit(ShaderAst::AccessIdentifierExpression& node) override;
@ -114,6 +121,7 @@ namespace Nz
void Visit(ShaderAst::MultiStatement& node) override; void Visit(ShaderAst::MultiStatement& node) override;
void Visit(ShaderAst::NoOpStatement& node) override; void Visit(ShaderAst::NoOpStatement& node) override;
void Visit(ShaderAst::ReturnStatement& node) override; void Visit(ShaderAst::ReturnStatement& node) override;
void Visit(ShaderAst::ScopedStatement& node) override;
void Visit(ShaderAst::WhileStatement& node) override; void Visit(ShaderAst::WhileStatement& node) override;
struct State; struct State;

View File

@ -50,13 +50,14 @@ namespace Nz::ShaderBuilder
struct CallFunction struct CallFunction
{ {
inline std::unique_ptr<ShaderAst::CallFunctionExpression> operator()(std::string functionName, std::vector<ShaderAst::ExpressionPtr> parameters) const; inline std::unique_ptr<ShaderAst::CallFunctionExpression> operator()(std::string functionName, std::vector<ShaderAst::ExpressionPtr> parameters) const;
inline std::unique_ptr<ShaderAst::CallFunctionExpression> operator()(ShaderAst::ExpressionPtr functionExpr, std::vector<ShaderAst::ExpressionPtr> parameters) const;
}; };
struct Cast struct Cast
{ {
inline std::unique_ptr<ShaderAst::CastExpression> operator()(ShaderAst::ExpressionType targetType, ShaderAst::ExpressionPtr expression) const; inline std::unique_ptr<ShaderAst::CastExpression> operator()(ShaderAst::ExpressionValue<ShaderAst::ExpressionType> targetType, ShaderAst::ExpressionPtr expression) const;
inline std::unique_ptr<ShaderAst::CastExpression> operator()(ShaderAst::ExpressionType targetType, std::array<ShaderAst::ExpressionPtr, 4> expressions) const; inline std::unique_ptr<ShaderAst::CastExpression> operator()(ShaderAst::ExpressionValue<ShaderAst::ExpressionType> targetType, std::array<ShaderAst::ExpressionPtr, 4> expressions) const;
inline std::unique_ptr<ShaderAst::CastExpression> operator()(ShaderAst::ExpressionType targetType, std::vector<ShaderAst::ExpressionPtr> expressions) const; inline std::unique_ptr<ShaderAst::CastExpression> operator()(ShaderAst::ExpressionValue<ShaderAst::ExpressionType> targetType, std::vector<ShaderAst::ExpressionPtr> expressions) const;
}; };
struct ConditionalExpression struct ConditionalExpression
@ -78,20 +79,20 @@ namespace Nz::ShaderBuilder
struct DeclareConst struct DeclareConst
{ {
inline std::unique_ptr<ShaderAst::DeclareConstStatement> operator()(std::string name, ShaderAst::ExpressionPtr initialValue) const; inline std::unique_ptr<ShaderAst::DeclareConstStatement> operator()(std::string name, ShaderAst::ExpressionPtr initialValue) const;
inline std::unique_ptr<ShaderAst::DeclareConstStatement> operator()(std::string name, ShaderAst::ExpressionType type, ShaderAst::ExpressionPtr initialValue = nullptr) const; inline std::unique_ptr<ShaderAst::DeclareConstStatement> operator()(std::string name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> type, ShaderAst::ExpressionPtr initialValue = nullptr) const;
}; };
struct DeclareFunction struct DeclareFunction
{ {
inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::string name, ShaderAst::StatementPtr statement) const; inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::string name, ShaderAst::StatementPtr statement) const;
inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionType returnType = ShaderAst::NoType{}) const; inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> returnType = ShaderAst::ExpressionType{ ShaderAst::NoType{} }) const;
inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::optional<ShaderStageType> entryStage, std::string name, ShaderAst::StatementPtr statement) const; inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::optional<ShaderStageType> entryStage, std::string name, ShaderAst::StatementPtr statement) const;
inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::optional<ShaderStageType> entryStage, std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionType returnType = ShaderAst::NoType{}) const; inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> operator()(std::optional<ShaderStageType> entryStage, std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> returnType = ShaderAst::ExpressionType{ ShaderAst::NoType{} }) const;
}; };
struct DeclareOption struct DeclareOption
{ {
inline std::unique_ptr<ShaderAst::DeclareOptionStatement> operator()(std::string name, ShaderAst::ExpressionType type, ShaderAst::ExpressionPtr initialValue = nullptr) const; inline std::unique_ptr<ShaderAst::DeclareOptionStatement> operator()(std::string name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> type, ShaderAst::ExpressionPtr initialValue = nullptr) const;
}; };
struct DeclareStruct struct DeclareStruct
@ -102,7 +103,7 @@ namespace Nz::ShaderBuilder
struct DeclareVariable struct DeclareVariable
{ {
inline std::unique_ptr<ShaderAst::DeclareVariableStatement> operator()(std::string name, ShaderAst::ExpressionPtr initialValue) const; inline std::unique_ptr<ShaderAst::DeclareVariableStatement> operator()(std::string name, ShaderAst::ExpressionPtr initialValue) const;
inline std::unique_ptr<ShaderAst::DeclareVariableStatement> operator()(std::string name, ShaderAst::ExpressionType type, ShaderAst::ExpressionPtr initialValue = nullptr) const; inline std::unique_ptr<ShaderAst::DeclareVariableStatement> operator()(std::string name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> type, ShaderAst::ExpressionPtr initialValue = nullptr) const;
}; };
struct ExpressionStatement struct ExpressionStatement
@ -147,6 +148,11 @@ namespace Nz::ShaderBuilder
inline std::unique_ptr<ShaderAst::ReturnStatement> operator()(ShaderAst::ExpressionPtr expr = nullptr) const; inline std::unique_ptr<ShaderAst::ReturnStatement> operator()(ShaderAst::ExpressionPtr expr = nullptr) const;
}; };
struct Scoped
{
inline std::unique_ptr<ShaderAst::ScopedStatement> operator()(ShaderAst::StatementPtr statement) const;
};
struct Swizzle struct Swizzle
{ {
inline std::unique_ptr<ShaderAst::SwizzleExpression> operator()(ShaderAst::ExpressionPtr expression, std::array<UInt32, 4> swizzleComponents, std::size_t componentCount) const; inline std::unique_ptr<ShaderAst::SwizzleExpression> operator()(ShaderAst::ExpressionPtr expression, std::array<UInt32, 4> swizzleComponents, std::size_t componentCount) const;
@ -194,6 +200,7 @@ namespace Nz::ShaderBuilder
constexpr Impl::Multi MultiStatement; constexpr Impl::Multi MultiStatement;
constexpr Impl::NoParam<ShaderAst::NoOpStatement> NoOp; constexpr Impl::NoParam<ShaderAst::NoOpStatement> NoOp;
constexpr Impl::Return Return; constexpr Impl::Return Return;
constexpr Impl::Scoped Scoped;
constexpr Impl::Swizzle Swizzle; constexpr Impl::Swizzle Swizzle;
constexpr Impl::Unary Unary; constexpr Impl::Unary Unary;
constexpr Impl::Variable Variable; constexpr Impl::Variable Variable;

View File

@ -105,13 +105,22 @@ namespace Nz::ShaderBuilder
inline std::unique_ptr<ShaderAst::CallFunctionExpression> Impl::CallFunction::operator()(std::string functionName, std::vector<ShaderAst::ExpressionPtr> parameters) const inline std::unique_ptr<ShaderAst::CallFunctionExpression> Impl::CallFunction::operator()(std::string functionName, std::vector<ShaderAst::ExpressionPtr> parameters) const
{ {
auto callFunctionExpression = std::make_unique<ShaderAst::CallFunctionExpression>(); auto callFunctionExpression = std::make_unique<ShaderAst::CallFunctionExpression>();
callFunctionExpression->targetFunction = std::move(functionName); callFunctionExpression->targetFunction = ShaderBuilder::Identifier(std::move(functionName));
callFunctionExpression->parameters = std::move(parameters); callFunctionExpression->parameters = std::move(parameters);
return callFunctionExpression; return callFunctionExpression;
} }
inline std::unique_ptr<ShaderAst::CastExpression> Impl::Cast::operator()(ShaderAst::ExpressionType targetType, ShaderAst::ExpressionPtr expression) const inline std::unique_ptr<ShaderAst::CallFunctionExpression> Impl::CallFunction::operator()(ShaderAst::ExpressionPtr functionExpr, std::vector<ShaderAst::ExpressionPtr> parameters) const
{
auto callFunctionExpression = std::make_unique<ShaderAst::CallFunctionExpression>();
callFunctionExpression->targetFunction = std::move(functionExpr);
callFunctionExpression->parameters = std::move(parameters);
return callFunctionExpression;
}
inline std::unique_ptr<ShaderAst::CastExpression> Impl::Cast::operator()(ShaderAst::ExpressionValue<ShaderAst::ExpressionType> targetType, ShaderAst::ExpressionPtr expression) const
{ {
auto castNode = std::make_unique<ShaderAst::CastExpression>(); auto castNode = std::make_unique<ShaderAst::CastExpression>();
castNode->targetType = std::move(targetType); castNode->targetType = std::move(targetType);
@ -120,7 +129,7 @@ namespace Nz::ShaderBuilder
return castNode; return castNode;
} }
inline std::unique_ptr<ShaderAst::CastExpression> Impl::Cast::operator()(ShaderAst::ExpressionType targetType, std::array<ShaderAst::ExpressionPtr, 4> expressions) const inline std::unique_ptr<ShaderAst::CastExpression> Impl::Cast::operator()(ShaderAst::ExpressionValue<ShaderAst::ExpressionType> targetType, std::array<ShaderAst::ExpressionPtr, 4> expressions) const
{ {
auto castNode = std::make_unique<ShaderAst::CastExpression>(); auto castNode = std::make_unique<ShaderAst::CastExpression>();
castNode->expressions = std::move(expressions); castNode->expressions = std::move(expressions);
@ -129,7 +138,7 @@ namespace Nz::ShaderBuilder
return castNode; return castNode;
} }
inline std::unique_ptr<ShaderAst::CastExpression> Impl::Cast::operator()(ShaderAst::ExpressionType targetType, std::vector<ShaderAst::ExpressionPtr> expressions) const inline std::unique_ptr<ShaderAst::CastExpression> Impl::Cast::operator()(ShaderAst::ExpressionValue<ShaderAst::ExpressionType> targetType, std::vector<ShaderAst::ExpressionPtr> expressions) const
{ {
auto castNode = std::make_unique<ShaderAst::CastExpression>(); auto castNode = std::make_unique<ShaderAst::CastExpression>();
castNode->targetType = std::move(targetType); castNode->targetType = std::move(targetType);
@ -194,7 +203,7 @@ namespace Nz::ShaderBuilder
return declareConstNode; return declareConstNode;
} }
inline std::unique_ptr<ShaderAst::DeclareConstStatement> Impl::DeclareConst::operator()(std::string name, ShaderAst::ExpressionType type, ShaderAst::ExpressionPtr initialValue) const inline std::unique_ptr<ShaderAst::DeclareConstStatement> Impl::DeclareConst::operator()(std::string name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> type, ShaderAst::ExpressionPtr initialValue) const
{ {
auto declareConstNode = std::make_unique<ShaderAst::DeclareConstStatement>(); auto declareConstNode = std::make_unique<ShaderAst::DeclareConstStatement>();
declareConstNode->name = std::move(name); declareConstNode->name = std::move(name);
@ -213,7 +222,7 @@ namespace Nz::ShaderBuilder
return declareFunctionNode; return declareFunctionNode;
} }
inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> Impl::DeclareFunction::operator()(std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionType returnType) const inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> Impl::DeclareFunction::operator()(std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> returnType) const
{ {
auto declareFunctionNode = std::make_unique<ShaderAst::DeclareFunctionStatement>(); auto declareFunctionNode = std::make_unique<ShaderAst::DeclareFunctionStatement>();
declareFunctionNode->name = std::move(name); declareFunctionNode->name = std::move(name);
@ -236,7 +245,7 @@ namespace Nz::ShaderBuilder
return declareFunctionNode; return declareFunctionNode;
} }
inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> Impl::DeclareFunction::operator()(std::optional<ShaderStageType> entryStage, std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionType returnType) const inline std::unique_ptr<ShaderAst::DeclareFunctionStatement> Impl::DeclareFunction::operator()(std::optional<ShaderStageType> entryStage, std::string name, std::vector<ShaderAst::DeclareFunctionStatement::Parameter> parameters, std::vector<ShaderAst::StatementPtr> statements, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> returnType) const
{ {
auto declareFunctionNode = std::make_unique<ShaderAst::DeclareFunctionStatement>(); auto declareFunctionNode = std::make_unique<ShaderAst::DeclareFunctionStatement>();
declareFunctionNode->name = std::move(name); declareFunctionNode->name = std::move(name);
@ -250,7 +259,7 @@ namespace Nz::ShaderBuilder
return declareFunctionNode; return declareFunctionNode;
} }
inline std::unique_ptr<ShaderAst::DeclareOptionStatement> Impl::DeclareOption::operator()(std::string name, ShaderAst::ExpressionType type, ShaderAst::ExpressionPtr initialValue) const inline std::unique_ptr<ShaderAst::DeclareOptionStatement> Impl::DeclareOption::operator()(std::string name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> type, ShaderAst::ExpressionPtr initialValue) const
{ {
auto declareOptionNode = std::make_unique<ShaderAst::DeclareOptionStatement>(); auto declareOptionNode = std::make_unique<ShaderAst::DeclareOptionStatement>();
declareOptionNode->optName = std::move(name); declareOptionNode->optName = std::move(name);
@ -277,7 +286,7 @@ namespace Nz::ShaderBuilder
return declareVariableNode; return declareVariableNode;
} }
inline std::unique_ptr<ShaderAst::DeclareVariableStatement> Impl::DeclareVariable::operator()(std::string name, ShaderAst::ExpressionType type, ShaderAst::ExpressionPtr initialValue) const inline std::unique_ptr<ShaderAst::DeclareVariableStatement> Impl::DeclareVariable::operator()(std::string name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType> type, ShaderAst::ExpressionPtr initialValue) const
{ {
auto declareVariableNode = std::make_unique<ShaderAst::DeclareVariableStatement>(); auto declareVariableNode = std::make_unique<ShaderAst::DeclareVariableStatement>();
declareVariableNode->varName = std::move(name); declareVariableNode->varName = std::move(name);
@ -367,6 +376,14 @@ namespace Nz::ShaderBuilder
return returnNode; return returnNode;
} }
inline std::unique_ptr<ShaderAst::ScopedStatement> Impl::Scoped::operator()(ShaderAst::StatementPtr statement) const
{
auto scopedNode = std::make_unique<ShaderAst::ScopedStatement>();
scopedNode->statement = std::move(statement);
return scopedNode;
}
inline std::unique_ptr<ShaderAst::SwizzleExpression> Impl::Swizzle::operator()(ShaderAst::ExpressionPtr expression, std::array<UInt32, 4> swizzleComponents, std::size_t componentCount) const inline std::unique_ptr<ShaderAst::SwizzleExpression> Impl::Swizzle::operator()(ShaderAst::ExpressionPtr expression, std::array<UInt32, 4> swizzleComponents, std::size_t componentCount) const
{ {
assert(componentCount > 0); assert(componentCount > 0);

View File

@ -70,36 +70,31 @@ namespace Nz::ShaderLang
// Flow control // Flow control
const Token& Advance(); const Token& Advance();
void Consume(std::size_t count = 1); void Consume(std::size_t count = 1);
std::optional<ShaderAst::ExpressionType> DecodeType(const std::string& identifier);
void EnterScope();
const Token& Expect(const Token& token, TokenType type); const Token& Expect(const Token& token, TokenType type);
const Token& ExpectNot(const Token& token, TokenType type); const Token& ExpectNot(const Token& token, TokenType type);
const Token& Expect(TokenType type); const Token& Expect(TokenType type);
void LeaveScope();
bool IsVariableInScope(const std::string_view& identifier) const;
void RegisterVariable(std::string identifier);
const Token& Peek(std::size_t advance = 0); const Token& Peek(std::size_t advance = 0);
std::vector<ShaderAst::Attribute> ParseAttributes(); std::vector<ShaderAst::ExprValue> ParseAttributes();
void ParseVariableDeclaration(std::string& name, ShaderAst::ExpressionType& type, ShaderAst::ExpressionPtr& initialValue); void ParseVariableDeclaration(std::string& name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType>& type, ShaderAst::ExpressionPtr& initialValue);
// Statements // Statements
ShaderAst::StatementPtr ParseBranchStatement(); ShaderAst::StatementPtr ParseBranchStatement();
ShaderAst::StatementPtr ParseConstStatement(); ShaderAst::StatementPtr ParseConstStatement();
ShaderAst::StatementPtr ParseDiscardStatement(); ShaderAst::StatementPtr ParseDiscardStatement();
ShaderAst::StatementPtr ParseExternalBlock(std::vector<ShaderAst::Attribute> attributes = {}); ShaderAst::StatementPtr ParseExternalBlock(std::vector<ShaderAst::ExprValue> attributes = {});
ShaderAst::StatementPtr ParseForDeclaration(std::vector<ShaderAst::Attribute> attributes = {}); ShaderAst::StatementPtr ParseForDeclaration(std::vector<ShaderAst::ExprValue> attributes = {});
std::vector<ShaderAst::StatementPtr> ParseFunctionBody(); std::vector<ShaderAst::StatementPtr> ParseFunctionBody();
ShaderAst::StatementPtr ParseFunctionDeclaration(std::vector<ShaderAst::Attribute> attributes = {}); ShaderAst::StatementPtr ParseFunctionDeclaration(std::vector<ShaderAst::ExprValue> attributes = {});
ShaderAst::DeclareFunctionStatement::Parameter ParseFunctionParameter(); ShaderAst::DeclareFunctionStatement::Parameter ParseFunctionParameter();
ShaderAst::StatementPtr ParseOptionDeclaration(); ShaderAst::StatementPtr ParseOptionDeclaration();
ShaderAst::StatementPtr ParseReturnStatement(); ShaderAst::StatementPtr ParseReturnStatement();
ShaderAst::StatementPtr ParseSingleStatement(); ShaderAst::StatementPtr ParseSingleStatement();
ShaderAst::StatementPtr ParseStatement(); ShaderAst::StatementPtr ParseStatement();
std::vector<ShaderAst::StatementPtr> ParseStatementList(); std::vector<ShaderAst::StatementPtr> ParseStatementList();
ShaderAst::StatementPtr ParseStructDeclaration(std::vector<ShaderAst::Attribute> attributes = {}); ShaderAst::StatementPtr ParseStructDeclaration(std::vector<ShaderAst::ExprValue> attributes = {});
ShaderAst::StatementPtr ParseVariableDeclaration(); ShaderAst::StatementPtr ParseVariableDeclaration();
ShaderAst::StatementPtr ParseWhileStatement(std::vector<ShaderAst::Attribute> attributes); ShaderAst::StatementPtr ParseWhileStatement(std::vector<ShaderAst::ExprValue> attributes);
// Expressions // Expressions
ShaderAst::ExpressionPtr ParseBinOpRhs(int exprPrecedence, ShaderAst::ExpressionPtr lhs); ShaderAst::ExpressionPtr ParseBinOpRhs(int exprPrecedence, ShaderAst::ExpressionPtr lhs);
@ -115,8 +110,7 @@ namespace Nz::ShaderLang
ShaderAst::AttributeType ParseIdentifierAsAttributeType(); ShaderAst::AttributeType ParseIdentifierAsAttributeType();
const std::string& ParseIdentifierAsName(); const std::string& ParseIdentifierAsName();
ShaderAst::PrimitiveType ParsePrimitiveType(); ShaderAst::ExpressionPtr ParseType();
ShaderAst::ExpressionType ParseType();
static int GetTokenPrecedence(TokenType token); static int GetTokenPrecedence(TokenType token);
@ -124,8 +118,6 @@ namespace Nz::ShaderLang
{ {
std::size_t tokenCount; std::size_t tokenCount;
std::size_t tokenIndex = 0; std::size_t tokenIndex = 0;
std::vector<std::size_t> scopeSizes;
std::vector<std::string> identifiersInScope;
std::unique_ptr<ShaderAst::MultiStatement> root; std::unique_ptr<ShaderAst::MultiStatement> root;
const Token* tokens; const Token* tokens;
}; };

View File

@ -20,7 +20,7 @@ namespace Nz
{ {
class SpirvWriter; class SpirvWriter;
class NAZARA_SHADER_API SpirvAstVisitor : public ShaderAst::ExpressionVisitorExcept, public ShaderAst::StatementVisitorExcept class NAZARA_SHADER_API SpirvAstVisitor : public ShaderAst::AstExpressionVisitorExcept, public ShaderAst::AstStatementVisitorExcept
{ {
public: public:
struct EntryPoint; struct EntryPoint;
@ -38,8 +38,8 @@ namespace Nz
const Variable& GetVariable(std::size_t varIndex) const; const Variable& GetVariable(std::size_t varIndex) const;
using ExpressionVisitorExcept::Visit; using AstExpressionVisitorExcept::Visit;
using StatementVisitorExcept::Visit; using AstStatementVisitorExcept::Visit;
void Visit(ShaderAst::AccessIndexExpression& node) override; void Visit(ShaderAst::AccessIndexExpression& node) override;
void Visit(ShaderAst::AssignExpression& node) override; void Visit(ShaderAst::AssignExpression& node) override;
@ -60,6 +60,7 @@ namespace Nz
void Visit(ShaderAst::MultiStatement& node) override; void Visit(ShaderAst::MultiStatement& node) override;
void Visit(ShaderAst::NoOpStatement& node) override; void Visit(ShaderAst::NoOpStatement& node) override;
void Visit(ShaderAst::ReturnStatement& node) override; void Visit(ShaderAst::ReturnStatement& node) override;
void Visit(ShaderAst::ScopedStatement& node) override;
void Visit(ShaderAst::SwizzleExpression& node) override; void Visit(ShaderAst::SwizzleExpression& node) override;
void Visit(ShaderAst::UnaryExpression& node) override; void Visit(ShaderAst::UnaryExpression& node) override;
void Visit(ShaderAst::VariableExpression& node) override; void Visit(ShaderAst::VariableExpression& node) override;

View File

@ -19,7 +19,7 @@ namespace Nz
class SpirvBlock; class SpirvBlock;
class SpirvWriter; class SpirvWriter;
class NAZARA_SHADER_API SpirvExpressionLoad : public ShaderAst::ExpressionVisitorExcept class NAZARA_SHADER_API SpirvExpressionLoad : public ShaderAst::AstExpressionVisitorExcept
{ {
public: public:
inline SpirvExpressionLoad(SpirvWriter& writer, SpirvAstVisitor& visitor, SpirvBlock& block); inline SpirvExpressionLoad(SpirvWriter& writer, SpirvAstVisitor& visitor, SpirvBlock& block);
@ -29,7 +29,7 @@ namespace Nz
UInt32 Evaluate(ShaderAst::Expression& node); UInt32 Evaluate(ShaderAst::Expression& node);
using ExpressionVisitorExcept::Visit; using AstExpressionVisitorExcept::Visit;
void Visit(ShaderAst::AccessIndexExpression& node) override; void Visit(ShaderAst::AccessIndexExpression& node) override;
void Visit(ShaderAst::VariableExpression& node) override; void Visit(ShaderAst::VariableExpression& node) override;
@ -37,6 +37,15 @@ namespace Nz
SpirvExpressionLoad& operator=(SpirvExpressionLoad&&) = delete; SpirvExpressionLoad& operator=(SpirvExpressionLoad&&) = delete;
private: private:
struct PointerChainAccess
{
std::vector<UInt32> indices;
const ShaderAst::ExpressionType* exprType;
SpirvStorageClass storage;
UInt32 pointerId;
UInt32 pointedTypeId;
};
struct Pointer struct Pointer
{ {
SpirvStorageClass storage; SpirvStorageClass storage;
@ -46,13 +55,20 @@ namespace Nz
struct Value struct Value
{ {
UInt32 resultId; UInt32 valueId;
};
struct ValueExtraction
{
std::vector<UInt32> indices;
UInt32 typeId;
UInt32 valueId;
}; };
SpirvAstVisitor& m_visitor; SpirvAstVisitor& m_visitor;
SpirvBlock& m_block; SpirvBlock& m_block;
SpirvWriter& m_writer; SpirvWriter& m_writer;
std::variant<std::monostate, Pointer, Value> m_value; std::variant<std::monostate, ValueExtraction, Pointer, PointerChainAccess, Value> m_value;
}; };
} }

View File

@ -19,7 +19,7 @@ namespace Nz
class SpirvBlock; class SpirvBlock;
class SpirvWriter; class SpirvWriter;
class NAZARA_SHADER_API SpirvExpressionStore : public ShaderAst::ExpressionVisitorExcept class NAZARA_SHADER_API SpirvExpressionStore : public ShaderAst::AstExpressionVisitorExcept
{ {
public: public:
inline SpirvExpressionStore(SpirvWriter& writer, SpirvAstVisitor& visitor, SpirvBlock& block); inline SpirvExpressionStore(SpirvWriter& writer, SpirvAstVisitor& visitor, SpirvBlock& block);
@ -29,7 +29,7 @@ namespace Nz
void Store(ShaderAst::ExpressionPtr& node, UInt32 resultId); void Store(ShaderAst::ExpressionPtr& node, UInt32 resultId);
using ExpressionVisitorExcept::Visit; using AstExpressionVisitorExcept::Visit;
void Visit(ShaderAst::AccessIndexExpression& node) override; void Visit(ShaderAst::AccessIndexExpression& node) override;
void Visit(ShaderAst::SwizzleExpression& node) override; void Visit(ShaderAst::SwizzleExpression& node) override;
void Visit(ShaderAst::VariableExpression& node) override; void Visit(ShaderAst::VariableExpression& node) override;

View File

@ -184,8 +184,8 @@ namespace Nz
if (!uberShader->HasOption(optionName, &optionPtr)) if (!uberShader->HasOption(optionName, &optionPtr))
return InvalidOption; return InvalidOption;
if (optionPtr->type != ShaderAst::ExpressionType{ ShaderAst::PrimitiveType::Int32 }) //if (optionPtr->type != ShaderAst::ExpressionType{ ShaderAst::PrimitiveType::Int32 })
throw std::runtime_error("Location options must be of type i32"); // throw std::runtime_error("Location options must be of type i32");
return optionPtr->index; return optionPtr->index;
}; };

View File

@ -251,8 +251,8 @@ namespace Nz
if (!uberShader->HasOption(optionName, &optionPtr)) if (!uberShader->HasOption(optionName, &optionPtr))
return InvalidOption; return InvalidOption;
if (optionPtr->type != ShaderAst::ExpressionType{ ShaderAst::PrimitiveType::Int32 }) //if (optionPtr->type != ShaderAst::ExpressionType{ ShaderAst::PrimitiveType::Int32 })
throw std::runtime_error("Location options must be of type i32"); // throw std::runtime_error("Location options must be of type i32");
return optionPtr->index; return optionPtr->index;
}; };

View File

@ -10,7 +10,7 @@ option BillboardSizeRotLocation: i32 = -1;
// Vertex declaration related options // Vertex declaration related options
option ColorLocation: i32 = -1; option ColorLocation: i32 = -1;
option PosLocation: i32 = -1; option PosLocation: i32;
option UvLocation: i32 = -1; option UvLocation: i32 = -1;
const HasVertexColor = (ColorLocation >= 0); const HasVertexColor = (ColorLocation >= 0);

View File

@ -20,7 +20,7 @@ option BillboardSizeRotLocation: i32 = -1;
// Vertex declaration related options // Vertex declaration related options
option ColorLocation: i32 = -1; option ColorLocation: i32 = -1;
option NormalLocation: i32 = -1; option NormalLocation: i32 = -1;
option PosLocation: i32 = -1; option PosLocation: i32;
option TangentLocation: i32 = -1; option TangentLocation: i32 = -1;
option UvLocation: i32 = -1; option UvLocation: i32 = -1;

View File

@ -31,11 +31,10 @@ namespace Nz
supportedStageType |= stageType; supportedStageType |= stageType;
}; };
callbacks.onOptionDeclaration = [&](const std::string& optionName, const ShaderAst::ExpressionType& optionType) callbacks.onOptionDeclaration = [&](const std::string& optionName, const ShaderAst::ExpressionValue<ShaderAst::ExpressionType>& optionType)
{ {
m_optionIndexByName[optionName] = Option{ m_optionIndexByName[optionName] = Option{
optionCount, optionCount
optionType
}; };
optionCount++; optionCount++;

View File

@ -36,6 +36,20 @@ namespace Nz::ShaderAst
return PopStatement(); return PopStatement();
} }
ExpressionValue<ExpressionType> AstCloner::CloneType(const ExpressionValue<ExpressionType>& exprType)
{
if (!exprType.HasValue())
return {};
if (exprType.IsExpression())
return CloneExpression(exprType.GetExpression());
else
{
assert(exprType.IsResultingValue());
return exprType.GetResultingValue();
}
}
StatementPtr AstCloner::Clone(BranchStatement& node) StatementPtr AstCloner::Clone(BranchStatement& node)
{ {
auto clone = std::make_unique<BranchStatement>(); auto clone = std::make_unique<BranchStatement>();
@ -68,7 +82,7 @@ namespace Nz::ShaderAst
auto clone = std::make_unique<DeclareConstStatement>(); auto clone = std::make_unique<DeclareConstStatement>();
clone->constIndex = node.constIndex; clone->constIndex = node.constIndex;
clone->name = node.name; clone->name = node.name;
clone->type = node.type; clone->type = Clone(node.type);
clone->expression = CloneExpression(node.expression); clone->expression = CloneExpression(node.expression);
return clone; return clone;
@ -86,7 +100,7 @@ namespace Nz::ShaderAst
{ {
auto& cloneVar = clone->externalVars.emplace_back(); auto& cloneVar = clone->externalVars.emplace_back();
cloneVar.name = var.name; cloneVar.name = var.name;
cloneVar.type = var.type; cloneVar.type = Clone(var.type);
cloneVar.bindingIndex = Clone(var.bindingIndex); cloneVar.bindingIndex = Clone(var.bindingIndex);
cloneVar.bindingSet = Clone(var.bindingSet); cloneVar.bindingSet = Clone(var.bindingSet);
} }
@ -102,10 +116,17 @@ namespace Nz::ShaderAst
clone->entryStage = Clone(node.entryStage); clone->entryStage = Clone(node.entryStage);
clone->funcIndex = node.funcIndex; clone->funcIndex = node.funcIndex;
clone->name = node.name; clone->name = node.name;
clone->parameters = node.parameters; clone->returnType = Clone(node.returnType);
clone->returnType = node.returnType;
clone->varIndex = node.varIndex; clone->varIndex = node.varIndex;
clone->parameters.reserve(node.parameters.size());
for (auto& parameter : node.parameters)
{
auto& cloneParam = clone->parameters.emplace_back();
cloneParam.name = parameter.name;
cloneParam.type = Clone(parameter.type);
}
clone->statements.reserve(node.statements.size()); clone->statements.reserve(node.statements.size());
for (auto& statement : node.statements) for (auto& statement : node.statements)
clone->statements.push_back(CloneStatement(statement)); clone->statements.push_back(CloneStatement(statement));
@ -119,7 +140,7 @@ namespace Nz::ShaderAst
clone->defaultValue = CloneExpression(node.defaultValue); clone->defaultValue = CloneExpression(node.defaultValue);
clone->optIndex = node.optIndex; clone->optIndex = node.optIndex;
clone->optName = node.optName; clone->optName = node.optName;
clone->optType = node.optType; clone->optType = Clone(node.optType);
return clone; return clone;
} }
@ -137,7 +158,7 @@ namespace Nz::ShaderAst
{ {
auto& cloneMember = clone->description.members.emplace_back(); auto& cloneMember = clone->description.members.emplace_back();
cloneMember.name = member.name; cloneMember.name = member.name;
cloneMember.type = member.type; cloneMember.type = Clone(member.type);
cloneMember.builtin = Clone(member.builtin); cloneMember.builtin = Clone(member.builtin);
cloneMember.cond = Clone(member.cond); cloneMember.cond = Clone(member.cond);
cloneMember.locationIndex = Clone(member.locationIndex); cloneMember.locationIndex = Clone(member.locationIndex);
@ -151,7 +172,7 @@ namespace Nz::ShaderAst
auto clone = std::make_unique<DeclareVariableStatement>(); auto clone = std::make_unique<DeclareVariableStatement>();
clone->varIndex = node.varIndex; clone->varIndex = node.varIndex;
clone->varName = node.varName; clone->varName = node.varName;
clone->varType = node.varType; clone->varType = Clone(node.varType);
clone->initialExpression = CloneExpression(node.initialExpression); clone->initialExpression = CloneExpression(node.initialExpression);
return clone; return clone;
@ -217,6 +238,14 @@ namespace Nz::ShaderAst
return clone; return clone;
} }
StatementPtr AstCloner::Clone(ScopedStatement& node)
{
auto clone = std::make_unique<ScopedStatement>();
clone->statement = CloneStatement(node.statement);
return clone;
}
StatementPtr AstCloner::Clone(WhileStatement& node) StatementPtr AstCloner::Clone(WhileStatement& node)
{ {
auto clone = std::make_unique<WhileStatement>(); auto clone = std::make_unique<WhileStatement>();
@ -279,7 +308,7 @@ namespace Nz::ShaderAst
ExpressionPtr AstCloner::Clone(CallFunctionExpression& node) ExpressionPtr AstCloner::Clone(CallFunctionExpression& node)
{ {
auto clone = std::make_unique<CallFunctionExpression>(); auto clone = std::make_unique<CallFunctionExpression>();
clone->targetFunction = node.targetFunction; clone->targetFunction = CloneExpression(node.targetFunction);
clone->parameters.reserve(node.parameters.size()); clone->parameters.reserve(node.parameters.size());
for (auto& parameter : node.parameters) for (auto& parameter : node.parameters)
@ -309,7 +338,7 @@ namespace Nz::ShaderAst
ExpressionPtr AstCloner::Clone(CastExpression& node) ExpressionPtr AstCloner::Clone(CastExpression& node)
{ {
auto clone = std::make_unique<CastExpression>(); auto clone = std::make_unique<CastExpression>();
clone->targetType = node.targetType; clone->targetType = Clone(node.targetType);
std::size_t expressionCount = 0; std::size_t expressionCount = 0;
for (auto& expr : node.expressions) for (auto& expr : node.expressions)

View File

@ -7,7 +7,7 @@
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
#define NAZARA_SHADERAST_EXPRESSION(Node) void ExpressionVisitorExcept::Visit(ShaderAst::Node& /*node*/) \ #define NAZARA_SHADERAST_EXPRESSION(Node) void AstExpressionVisitorExcept::Visit(ShaderAst::Node& /*node*/) \
{ \ { \
throw std::runtime_error("unexpected " #Node " node"); \ throw std::runtime_error("unexpected " #Node " node"); \
} }

View File

@ -818,13 +818,13 @@ namespace Nz::ShaderAst
} }
ExpressionPtr optimized; ExpressionPtr optimized;
if (IsPrimitiveType(node.targetType)) if (IsPrimitiveType(node.targetType.GetResultingValue()))
{ {
if (expressionCount == 1 && expressions.front()->GetType() == NodeType::ConstantValueExpression) if (expressionCount == 1 && expressions.front()->GetType() == NodeType::ConstantValueExpression)
{ {
const ConstantValueExpression& constantExpr = static_cast<const ConstantValueExpression&>(*expressions.front()); const ConstantValueExpression& constantExpr = static_cast<const ConstantValueExpression&>(*expressions.front());
switch (std::get<PrimitiveType>(node.targetType)) switch (std::get<PrimitiveType>(node.targetType.GetResultingValue()))
{ {
case PrimitiveType::Boolean: optimized = PropagateSingleValueCast<bool>(constantExpr); break; case PrimitiveType::Boolean: optimized = PropagateSingleValueCast<bool>(constantExpr); break;
case PrimitiveType::Float32: optimized = PropagateSingleValueCast<float>(constantExpr); break; case PrimitiveType::Float32: optimized = PropagateSingleValueCast<float>(constantExpr); break;
@ -833,9 +833,9 @@ namespace Nz::ShaderAst
} }
} }
} }
else if (IsVectorType(node.targetType)) else if (IsVectorType(node.targetType.GetResultingValue()))
{ {
const auto& vecType = std::get<VectorType>(node.targetType); const auto& vecType = std::get<VectorType>(node.targetType.GetResultingValue());
// Decompose vector into values (cast(vec3, float) => cast(float, float, float, float)) // Decompose vector into values (cast(vec3, float) => cast(float, float, float, float))
std::vector<ConstantValue> constantValues; std::vector<ConstantValue> constantValues;
@ -916,7 +916,7 @@ namespace Nz::ShaderAst
if (optimized) if (optimized)
return optimized; return optimized;
auto cast = ShaderBuilder::Cast(node.targetType, std::move(expressions)); auto cast = ShaderBuilder::Cast(node.targetType.GetResultingValue(), std::move(expressions));
cast->cachedExpressionType = node.cachedExpressionType; cast->cachedExpressionType = node.cachedExpressionType;
return cast; return cast;
@ -946,7 +946,7 @@ namespace Nz::ShaderAst
if (statements.empty()) if (statements.empty())
{ {
// First condition is true, dismiss the branch // First condition is true, dismiss the branch
return AstCloner::Clone(*condStatement.statement); return Unscope(AstCloner::Clone(*condStatement.statement));
} }
else else
{ {
@ -967,7 +967,7 @@ namespace Nz::ShaderAst
{ {
// All conditions have been removed, replace by else statement or no-op // All conditions have been removed, replace by else statement or no-op
if (node.elseStatement) if (node.elseStatement)
return AstCloner::Clone(*node.elseStatement); return Unscope(AstCloner::Clone(*node.elseStatement));
else else
return ShaderBuilder::NoOp(); return ShaderBuilder::NoOp();
} }
@ -1243,4 +1243,15 @@ namespace Nz::ShaderAst
return optimized; return optimized;
} }
StatementPtr AstOptimizer::Unscope(StatementPtr node)
{
assert(node);
if (node->GetType() == NodeType::ScopedStatement)
return std::move(static_cast<ScopedStatement&>(*node).statement);
else
return node;
}
} }

View File

@ -202,6 +202,12 @@ namespace Nz::ShaderAst
node.returnExpr->Visit(*this); node.returnExpr->Visit(*this);
} }
void AstRecursiveVisitor::Visit(ScopedStatement& node)
{
if (node.statement)
node.statement->Visit(*this);
}
void AstRecursiveVisitor::Visit(WhileStatement& node) void AstRecursiveVisitor::Visit(WhileStatement& node)
{ {
if (node.condition) if (node.condition)

View File

@ -67,27 +67,7 @@ namespace Nz::ShaderAst
void AstSerializerBase::Serialize(CallFunctionExpression& node) void AstSerializerBase::Serialize(CallFunctionExpression& node)
{ {
UInt32 typeIndex; Node(node.targetFunction);
if (IsWriting())
typeIndex = UInt32(node.targetFunction.index());
Value(typeIndex);
// Waiting for template lambda in C++20
auto SerializeValue = [&](auto dummyType)
{
using T = std::decay_t<decltype(dummyType)>;
auto& value = (IsWriting()) ? std::get<T>(node.targetFunction) : node.targetFunction.emplace<T>();
Value(value);
};
static_assert(std::variant_size_v<decltype(node.targetFunction)> == 2);
switch (typeIndex)
{
case 0: SerializeValue(std::string()); break;
case 1: SerializeValue(std::size_t()); break;
}
Container(node.parameters); Container(node.parameters);
for (auto& param : node.parameters) for (auto& param : node.parameters)
@ -106,7 +86,7 @@ namespace Nz::ShaderAst
void AstSerializerBase::Serialize(CastExpression& node) void AstSerializerBase::Serialize(CastExpression& node)
{ {
Type(node.targetType); ExprValue(node.targetType);
for (auto& expr : node.expressions) for (auto& expr : node.expressions)
Node(expr); Node(expr);
} }
@ -215,15 +195,15 @@ namespace Nz::ShaderAst
{ {
OptVal(node.varIndex); OptVal(node.varIndex);
Attribute(node.bindingSet); ExprValue(node.bindingSet);
Container(node.externalVars); Container(node.externalVars);
for (auto& extVar : node.externalVars) for (auto& extVar : node.externalVars)
{ {
Value(extVar.name); Value(extVar.name);
Type(extVar.type); ExprValue(extVar.type);
Attribute(extVar.bindingIndex); ExprValue(extVar.bindingIndex);
Attribute(extVar.bindingSet); ExprValue(extVar.bindingSet);
} }
} }
@ -231,17 +211,17 @@ namespace Nz::ShaderAst
{ {
OptVal(node.constIndex); OptVal(node.constIndex);
Value(node.name); Value(node.name);
Type(node.type); ExprValue(node.type);
Node(node.expression); Node(node.expression);
} }
void AstSerializerBase::Serialize(DeclareFunctionStatement& node) void AstSerializerBase::Serialize(DeclareFunctionStatement& node)
{ {
Value(node.name); Value(node.name);
Type(node.returnType); ExprValue(node.returnType);
Attribute(node.depthWrite); ExprValue(node.depthWrite);
Attribute(node.earlyFragmentTests); ExprValue(node.earlyFragmentTests);
Attribute(node.entryStage); ExprValue(node.entryStage);
OptVal(node.funcIndex); OptVal(node.funcIndex);
OptVal(node.varIndex); OptVal(node.varIndex);
@ -249,7 +229,7 @@ namespace Nz::ShaderAst
for (auto& parameter : node.parameters) for (auto& parameter : node.parameters)
{ {
Value(parameter.name); Value(parameter.name);
Type(parameter.type); ExprValue(parameter.type);
} }
Container(node.statements); Container(node.statements);
@ -261,7 +241,7 @@ namespace Nz::ShaderAst
{ {
OptVal(node.optIndex); OptVal(node.optIndex);
Value(node.optName); Value(node.optName);
Type(node.optType); ExprValue(node.optType);
Node(node.defaultValue); Node(node.defaultValue);
} }
@ -270,16 +250,16 @@ namespace Nz::ShaderAst
OptVal(node.structIndex); OptVal(node.structIndex);
Value(node.description.name); Value(node.description.name);
Attribute(node.description.layout); ExprValue(node.description.layout);
Container(node.description.members); Container(node.description.members);
for (auto& member : node.description.members) for (auto& member : node.description.members)
{ {
Value(member.name); Value(member.name);
Type(member.type); ExprValue(member.type);
Attribute(member.builtin); ExprValue(member.builtin);
Attribute(member.cond); ExprValue(member.cond);
Attribute(member.locationIndex); ExprValue(member.locationIndex);
} }
} }
@ -287,7 +267,7 @@ namespace Nz::ShaderAst
{ {
OptVal(node.varIndex); OptVal(node.varIndex);
Value(node.varName); Value(node.varName);
Type(node.varType); ExprValue(node.varType);
Node(node.initialExpression); Node(node.initialExpression);
} }
@ -303,7 +283,7 @@ namespace Nz::ShaderAst
void AstSerializerBase::Serialize(ForStatement& node) void AstSerializerBase::Serialize(ForStatement& node)
{ {
Attribute(node.unroll); ExprValue(node.unroll);
Value(node.varName); Value(node.varName);
Node(node.fromExpr); Node(node.fromExpr);
Node(node.toExpr); Node(node.toExpr);
@ -313,7 +293,7 @@ namespace Nz::ShaderAst
void AstSerializerBase::Serialize(ForEachStatement& node) void AstSerializerBase::Serialize(ForEachStatement& node)
{ {
Attribute(node.unroll); ExprValue(node.unroll);
Value(node.varName); Value(node.varName);
Node(node.expression); Node(node.expression);
Node(node.statement); Node(node.statement);
@ -336,9 +316,14 @@ namespace Nz::ShaderAst
Node(node.returnExpr); Node(node.returnExpr);
} }
void AstSerializerBase::Serialize(ScopedStatement& node)
{
Node(node.statement);
}
void AstSerializerBase::Serialize(WhileStatement& node) void AstSerializerBase::Serialize(WhileStatement& node)
{ {
Attribute(node.unroll); ExprValue(node.unroll);
Node(node.condition); Node(node.condition);
Node(node.body); Node(node.body);
} }
@ -392,7 +377,7 @@ namespace Nz::ShaderAst
else if constexpr (std::is_same_v<T, PrimitiveType>) else if constexpr (std::is_same_v<T, PrimitiveType>)
{ {
m_stream << UInt8(1); m_stream << UInt8(1);
m_stream << UInt32(arg); Enum(arg);
} }
else if constexpr (std::is_same_v<T, IdentifierType>) else if constexpr (std::is_same_v<T, IdentifierType>)
{ {
@ -402,38 +387,59 @@ namespace Nz::ShaderAst
else if constexpr (std::is_same_v<T, MatrixType>) else if constexpr (std::is_same_v<T, MatrixType>)
{ {
m_stream << UInt8(3); m_stream << UInt8(3);
m_stream << UInt32(arg.columnCount); SizeT(arg.columnCount);
m_stream << UInt32(arg.rowCount); SizeT(arg.rowCount);
m_stream << UInt32(arg.type); Enum(arg.type);
} }
else if constexpr (std::is_same_v<T, SamplerType>) else if constexpr (std::is_same_v<T, SamplerType>)
{ {
m_stream << UInt8(4); m_stream << UInt8(4);
m_stream << UInt32(arg.dim); Enum(arg.dim);
m_stream << UInt32(arg.sampledType); Enum(arg.sampledType);
} }
else if constexpr (std::is_same_v<T, StructType>) else if constexpr (std::is_same_v<T, StructType>)
{ {
m_stream << UInt8(5); m_stream << UInt8(5);
m_stream << UInt32(arg.structIndex); SizeT(arg.structIndex);
} }
else if constexpr (std::is_same_v<T, UniformType>) else if constexpr (std::is_same_v<T, UniformType>)
{ {
m_stream << UInt8(6); m_stream << UInt8(6);
m_stream << std::get<IdentifierType>(arg.containedType).name; SizeT(arg.containedType.structIndex);
} }
else if constexpr (std::is_same_v<T, VectorType>) else if constexpr (std::is_same_v<T, VectorType>)
{ {
m_stream << UInt8(7); m_stream << UInt8(7);
m_stream << UInt32(arg.componentCount); SizeT(arg.componentCount);
m_stream << UInt32(arg.type); Enum(arg.type);
} }
else if constexpr (std::is_same_v<T, ArrayType>) else if constexpr (std::is_same_v<T, ArrayType>)
{ {
m_stream << UInt8(8); m_stream << UInt8(8);
Attribute(arg.length); Value(arg.length);
Type(arg.containedType->type); Type(arg.containedType->type);
} }
else if constexpr (std::is_same_v<T, ShaderAst::Type>)
{
m_stream << UInt8(9);
SizeT(arg.typeIndex);
}
else if constexpr (std::is_same_v<T, ShaderAst::FunctionType>)
{
m_stream << UInt8(10);
SizeT(arg.funcIndex);
}
else if constexpr (std::is_same_v<T, ShaderAst::IntrinsicFunctionType>)
{
m_stream << UInt8(11);
Enum(arg.intrinsic);
}
else if constexpr (std::is_same_v<T, ShaderAst::MethodType>)
{
m_stream << UInt8(12);
Type(arg.objectType->type);
SizeT(arg.methodIndex);
}
else else
static_assert(AlwaysFalse<T>::value, "non-exhaustive visitor"); static_assert(AlwaysFalse<T>::value, "non-exhaustive visitor");
}, type); }, type);
@ -618,10 +624,10 @@ namespace Nz::ShaderAst
case 3: //< MatrixType case 3: //< MatrixType
{ {
UInt32 columnCount, rowCount; std::size_t columnCount, rowCount;
PrimitiveType primitiveType; PrimitiveType primitiveType;
Value(columnCount); SizeT(columnCount);
Value(rowCount); SizeT(rowCount);
Enum(primitiveType); Enum(primitiveType);
type = MatrixType { type = MatrixType {
@ -659,12 +665,12 @@ namespace Nz::ShaderAst
case 6: //< UniformType case 6: //< UniformType
{ {
std::string containedType; std::size_t structIndex;
Value(containedType); SizeT(structIndex);
type = UniformType { type = UniformType {
IdentifierType { StructType {
containedType structIndex
} }
}; };
break; break;
@ -672,9 +678,9 @@ namespace Nz::ShaderAst
case 7: //< VectorType case 7: //< VectorType
{ {
UInt32 componentCount; std::size_t componentCount;
PrimitiveType componentType; PrimitiveType componentType;
Value(componentCount); SizeT(componentCount);
Enum(componentType); Enum(componentType);
type = VectorType{ type = VectorType{
@ -686,13 +692,13 @@ namespace Nz::ShaderAst
case 8: //< ArrayType case 8: //< ArrayType
{ {
AttributeValue<UInt32> length; UInt32 length;
ExpressionType containedType; ExpressionType containedType;
Attribute(length); Value(length);
Type(containedType); Type(containedType);
ArrayType arrayType; ArrayType arrayType;
arrayType.length = std::move(length); arrayType.length = length;
arrayType.containedType = std::make_unique<ContainedType>(); arrayType.containedType = std::make_unique<ContainedType>();
arrayType.containedType->type = std::move(containedType); arrayType.containedType->type = std::move(containedType);
@ -700,6 +706,52 @@ namespace Nz::ShaderAst
break; break;
} }
case 9: //< Type
{
std::size_t containedTypeIndex;
SizeT(containedTypeIndex);
type = ShaderAst::Type{
containedTypeIndex
};
}
case 10: //< FunctionType
{
std::size_t funcIndex;
SizeT(funcIndex);
type = FunctionType {
funcIndex
};
}
case 11: //< IntrinsicFunctionType
{
IntrinsicType intrinsicType;
Enum(intrinsicType);
type = IntrinsicFunctionType {
intrinsicType
};
}
case 12: //< MethodType
{
ExpressionType objectType;
Type(objectType);
std::size_t methodIndex;
SizeT(methodIndex);
MethodType methodType;
methodType.objectType = std::make_unique<ContainedType>();
methodType.objectType->type = std::move(objectType);
methodType.methodIndex = methodIndex;
type = std::move(methodType);
}
default: default:
break; break;
} }

View File

@ -7,7 +7,7 @@
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
#define NAZARA_SHADERAST_STATEMENT(Node) void StatementVisitorExcept::Visit(ShaderAst::Node& /*node*/) \ #define NAZARA_SHADERAST_STATEMENT(Node) void AstStatementVisitorExcept::Visit(ShaderAst::Node& /*node*/) \
{ \ { \
throw std::runtime_error("unexpected " #Node " node"); \ throw std::runtime_error("unexpected " #Node " node"); \
} }

View File

@ -9,11 +9,11 @@
namespace Nz::ShaderAst namespace Nz::ShaderAst
{ {
ArrayType::ArrayType(const ArrayType& array) ArrayType::ArrayType(const ArrayType& array) :
length(array.length)
{ {
assert(array.containedType); assert(array.containedType);
containedType = std::make_unique<ContainedType>(*array.containedType); containedType = std::make_unique<ContainedType>(*array.containedType);
length = Clone(array.length);
} }
ArrayType& ArrayType::operator=(const ArrayType& array) ArrayType& ArrayType::operator=(const ArrayType& array)
@ -21,7 +21,7 @@ namespace Nz::ShaderAst
assert(array.containedType); assert(array.containedType);
containedType = std::make_unique<ContainedType>(*array.containedType); containedType = std::make_unique<ContainedType>(*array.containedType);
length = Clone(array.length); length = array.length;
return *this; return *this;
} }
@ -34,9 +34,34 @@ namespace Nz::ShaderAst
if (containedType->type != rhs.containedType->type) if (containedType->type != rhs.containedType->type)
return false; return false;
if (!Compare(length, rhs.length)) if (length != rhs.length)
return false; return false;
return true; return true;
} }
MethodType::MethodType(const MethodType& methodType) :
methodIndex(methodType.methodIndex)
{
assert(methodType.objectType);
objectType = std::make_unique<ContainedType>(*methodType.objectType);
}
MethodType& MethodType::operator=(const MethodType& methodType)
{
assert(methodType.objectType);
methodIndex = methodType.methodIndex;
objectType = std::make_unique<ContainedType>(*methodType.objectType);
return *this;
}
bool MethodType::operator==(const MethodType& rhs) const
{
assert(objectType);
assert(rhs.objectType);
return objectType->type == rhs.objectType->type && methodIndex == rhs.methodIndex;
}
} }

File diff suppressed because it is too large Load Diff

View File

@ -43,7 +43,7 @@ namespace Nz
AstRecursiveVisitor::Visit(node); AstRecursiveVisitor::Visit(node);
assert(currentFunction); assert(currentFunction);
currentFunction->calledFunctions.UnboundedSet(std::get<std::size_t>(node.targetFunction)); currentFunction->calledFunctions.UnboundedSet(std::get<ShaderAst::FunctionType>(GetExpressionType(*node.targetFunction)).funcIndex);
} }
void Visit(ShaderAst::ConditionalExpression& /*node*/) override void Visit(ShaderAst::ConditionalExpression& /*node*/) override
@ -227,6 +227,24 @@ namespace Nz
throw std::runtime_error("unexpected ArrayType"); throw std::runtime_error("unexpected ArrayType");
} }
void GlslWriter::Append(ShaderAst::BuiltinEntry builtin)
{
switch (builtin)
{
case ShaderAst::BuiltinEntry::FragCoord:
Append("gl_FragCoord");
break;
case ShaderAst::BuiltinEntry::FragDepth:
Append("gl_FragDepth");
break;
case ShaderAst::BuiltinEntry::VertexPosition:
Append("gl_Position");
break;
}
}
void GlslWriter::Append(const ShaderAst::ExpressionType& type) void GlslWriter::Append(const ShaderAst::ExpressionType& type)
{ {
std::visit([&](auto&& arg) std::visit([&](auto&& arg)
@ -235,22 +253,14 @@ namespace Nz
}, type); }, type);
} }
void GlslWriter::Append(ShaderAst::BuiltinEntry builtin) void GlslWriter::Append(const ShaderAst::ExpressionValue<ShaderAst::ExpressionType>& type)
{ {
switch (builtin) Append(type.GetResultingValue());
{ }
case ShaderAst::BuiltinEntry::FragCoord:
Append("gl_FragCoord");
break;
case ShaderAst::BuiltinEntry::FragDepth: void GlslWriter::Append(const ShaderAst::FunctionType& /*functionType*/)
Append("gl_FragDepth"); {
break; throw std::runtime_error("unexpected function type");
case ShaderAst::BuiltinEntry::VertexPosition:
Append("gl_Position");
break;
}
} }
void GlslWriter::Append(const ShaderAst::IdentifierType& /*identifierType*/) void GlslWriter::Append(const ShaderAst::IdentifierType& /*identifierType*/)
@ -258,6 +268,11 @@ namespace Nz
throw std::runtime_error("unexpected identifier type"); throw std::runtime_error("unexpected identifier type");
} }
void GlslWriter::Append(const ShaderAst::IntrinsicFunctionType& /*intrinsicFunctionType*/)
{
throw std::runtime_error("unexpected intrinsic function type");
}
void GlslWriter::Append(const ShaderAst::MatrixType& matrixType) void GlslWriter::Append(const ShaderAst::MatrixType& matrixType)
{ {
if (matrixType.columnCount == matrixType.rowCount) if (matrixType.columnCount == matrixType.rowCount)
@ -274,6 +289,11 @@ namespace Nz
} }
} }
void GlslWriter::Append(const ShaderAst::MethodType& methodType)
{
throw std::runtime_error("unexpected method type");
}
void GlslWriter::Append(ShaderAst::PrimitiveType type) void GlslWriter::Append(ShaderAst::PrimitiveType type)
{ {
switch (type) switch (type)
@ -316,6 +336,11 @@ namespace Nz
Append(structDesc->name); Append(structDesc->name);
} }
void GlslWriter::Append(const ShaderAst::Type& /*type*/)
{
throw std::runtime_error("unexpected Type");
}
void GlslWriter::Append(const ShaderAst::UniformType& /*uniformType*/) void GlslWriter::Append(const ShaderAst::UniformType& /*uniformType*/)
{ {
throw std::runtime_error("unexpected UniformType"); throw std::runtime_error("unexpected UniformType");
@ -386,7 +411,7 @@ namespace Nz
first = false; first = false;
AppendVariableDeclaration(parameter.type, parameter.name); AppendVariableDeclaration(parameter.type.GetResultingValue(), parameter.name);
} }
AppendLine((forward) ? ");" : ")"); AppendLine((forward) ? ");" : ")");
} }
@ -506,13 +531,13 @@ namespace Nz
{ {
if (ShaderAst::IsArrayType(varType)) if (ShaderAst::IsArrayType(varType))
{ {
std::vector<const ShaderAst::AttributeValue<UInt32>*> lengths; std::vector<UInt32> lengths;
const ShaderAst::ExpressionType* exprType = &varType; const ShaderAst::ExpressionType* exprType = &varType;
while (ShaderAst::IsArrayType(*exprType)) while (ShaderAst::IsArrayType(*exprType))
{ {
const auto& arrayType = std::get<ShaderAst::ArrayType>(*exprType); const auto& arrayType = std::get<ShaderAst::ArrayType>(*exprType);
lengths.push_back(&arrayType.length); lengths.push_back(arrayType.length);
exprType = &arrayType.containedType->type; exprType = &arrayType.containedType->type;
} }
@ -520,17 +545,8 @@ namespace Nz
assert(!ShaderAst::IsArrayType(*exprType)); assert(!ShaderAst::IsArrayType(*exprType));
Append(*exprType, " ", varName); Append(*exprType, " ", varName);
for (const auto* lengthAttribute : lengths) for (UInt32 lengthAttribute : lengths)
{ Append("[", lengthAttribute, "]");
Append("[");
if (lengthAttribute->IsResultingValue())
Append(lengthAttribute->GetResultingValue());
else
lengthAttribute->GetExpression()->Visit(*this);
Append("]");
}
} }
else else
Append(varType, " ", varName); Append(varType, " ", varName);
@ -582,8 +598,8 @@ namespace Nz
const std::string& varName = parameter.name; const std::string& varName = parameter.name;
RegisterVariable(*node.varIndex, varName); RegisterVariable(*node.varIndex, varName);
assert(IsStructType(parameter.type)); assert(IsStructType(parameter.type.GetResultingValue()));
std::size_t structIndex = std::get<ShaderAst::StructType>(parameter.type).structIndex; std::size_t structIndex = std::get<ShaderAst::StructType>(parameter.type.GetResultingValue()).structIndex;
const ShaderAst::StructDescription* structDesc = Retrieve(m_currentState->structs, structIndex); const ShaderAst::StructDescription* structDesc = Retrieve(m_currentState->structs, structIndex);
AppendLine(structDesc->name, " ", varName, ";"); AppendLine(structDesc->name, " ", varName, ";");
@ -631,7 +647,7 @@ namespace Nz
Append("layout(location = "); Append("layout(location = ");
Append(member.locationIndex.GetResultingValue()); Append(member.locationIndex.GetResultingValue());
Append(") ", keyword, " "); Append(") ", keyword, " ");
AppendVariableDeclaration(member.type, targetPrefix + member.name); AppendVariableDeclaration(member.type.GetResultingValue(), targetPrefix + member.name);
AppendLine(";"); AppendLine(";");
fields.push_back({ fields.push_back({
@ -651,9 +667,9 @@ namespace Nz
{ {
assert(node.parameters.size() == 1); assert(node.parameters.size() == 1);
auto& parameter = node.parameters.front(); auto& parameter = node.parameters.front();
assert(std::holds_alternative<ShaderAst::StructType>(parameter.type)); assert(std::holds_alternative<ShaderAst::StructType>(parameter.type.GetResultingValue()));
std::size_t inputStructIndex = std::get<ShaderAst::StructType>(parameter.type).structIndex; std::size_t inputStructIndex = std::get<ShaderAst::StructType>(parameter.type.GetResultingValue()).structIndex;
inputStruct = Retrieve(m_currentState->structs, inputStructIndex); inputStruct = Retrieve(m_currentState->structs, inputStructIndex);
AppendCommentSection("Inputs"); AppendCommentSection("Inputs");
@ -666,10 +682,10 @@ namespace Nz
AppendLine(); AppendLine();
} }
if (!IsNoType(node.returnType)) if (node.returnType.HasValue())
{ {
assert(std::holds_alternative<ShaderAst::StructType>(node.returnType)); assert(std::holds_alternative<ShaderAst::StructType>(node.returnType.GetResultingValue()));
std::size_t outputStructIndex = std::get<ShaderAst::StructType>(node.returnType).structIndex; std::size_t outputStructIndex = std::get<ShaderAst::StructType>(node.returnType.GetResultingValue()).structIndex;
const ShaderAst::StructDescription* outputStruct = Retrieve(m_currentState->structs, outputStructIndex); const ShaderAst::StructDescription* outputStruct = Retrieve(m_currentState->structs, outputStructIndex);
@ -690,6 +706,18 @@ namespace Nz
m_currentState->variableNames.emplace(varIndex, std::move(varName)); m_currentState->variableNames.emplace(varIndex, std::move(varName));
} }
void GlslWriter::ScopeVisit(ShaderAst::Statement& node)
{
if (node.GetType() != ShaderAst::NodeType::ScopedStatement)
{
EnterScope();
node.Visit(*this);
LeaveScope(true);
}
else
node.Visit(*this);
}
void GlslWriter::Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired) void GlslWriter::Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired)
{ {
bool enclose = encloseIfRequired && (GetExpressionCategory(*expr) != ShaderAst::ExpressionCategory::LValue); bool enclose = encloseIfRequired && (GetExpressionCategory(*expr) != ShaderAst::ExpressionCategory::LValue);
@ -722,12 +750,10 @@ namespace Nz
assert(!IsStructType(exprType)); assert(!IsStructType(exprType));
// Array access // Array access
for (ShaderAst::ExpressionPtr& expr : node.indices) assert(node.indices.size() == 1);
{ Append("[");
Append("["); Visit(node.indices.front());
Visit(expr); Append("]");
Append("]");
}
} }
void GlslWriter::Visit(ShaderAst::AssignExpression& node) void GlslWriter::Visit(ShaderAst::AssignExpression& node)
@ -775,8 +801,8 @@ namespace Nz
void GlslWriter::Visit(ShaderAst::CallFunctionExpression& node) void GlslWriter::Visit(ShaderAst::CallFunctionExpression& node)
{ {
assert(std::holds_alternative<std::size_t>(node.targetFunction)); std::size_t functionIndex = std::get<ShaderAst::FunctionType>(GetExpressionType(*node.targetFunction)).funcIndex;
const std::string& targetName = Retrieve(m_currentState->previsitor.functions, std::get<std::size_t>(node.targetFunction)).name; const std::string& targetName = Retrieve(m_currentState->previsitor.functions, functionIndex).name;
Append(targetName, "("); Append(targetName, "(");
for (std::size_t i = 0; i < node.parameters.size(); ++i) for (std::size_t i = 0; i < node.parameters.size(); ++i)
@ -946,9 +972,7 @@ namespace Nz
statement.condition->Visit(*this); statement.condition->Visit(*this);
AppendLine(")"); AppendLine(")");
EnterScope(); ScopeVisit(*statement.statement);
statement.statement->Visit(*this);
LeaveScope();
first = false; first = false;
} }
@ -957,9 +981,7 @@ namespace Nz
{ {
AppendLine("else"); AppendLine("else");
EnterScope(); ScopeVisit(*node.elseStatement);
node.elseStatement->Visit(*this);
LeaveScope();
} }
} }
@ -976,13 +998,10 @@ namespace Nz
for (const auto& externalVar : node.externalVars) for (const auto& externalVar : node.externalVars)
{ {
bool isStd140 = false; bool isStd140 = false;
if (IsUniformType(externalVar.type)) if (IsUniformType(externalVar.type.GetResultingValue()))
{ {
auto& uniform = std::get<ShaderAst::UniformType>(externalVar.type); auto& uniform = std::get<ShaderAst::UniformType>(externalVar.type.GetResultingValue());
assert(std::holds_alternative<ShaderAst::StructType>(uniform.containedType)); ShaderAst::StructDescription* structInfo = Retrieve(m_currentState->structs, uniform.containedType.structIndex);
std::size_t structIndex = std::get<ShaderAst::StructType>(uniform.containedType).structIndex;
ShaderAst::StructDescription* structInfo = Retrieve(m_currentState->structs, structIndex);
if (structInfo->layout.HasValue()) if (structInfo->layout.HasValue())
isStd140 = structInfo->layout.GetResultingValue() == StructLayout::Std140; isStd140 = structInfo->layout.GetResultingValue() == StructLayout::Std140;
} }
@ -1018,18 +1037,15 @@ namespace Nz
Append("uniform "); Append("uniform ");
if (IsUniformType(externalVar.type)) if (IsUniformType(externalVar.type.GetResultingValue()))
{ {
Append("_NzBinding_"); Append("_NzBinding_");
AppendLine(externalVar.name); AppendLine(externalVar.name);
EnterScope(); EnterScope();
{ {
auto& uniform = std::get<ShaderAst::UniformType>(externalVar.type); auto& uniform = std::get<ShaderAst::UniformType>(externalVar.type.GetResultingValue());
assert(std::holds_alternative<ShaderAst::StructType>(uniform.containedType)); auto& structDesc = Retrieve(m_currentState->structs, uniform.containedType.structIndex);
std::size_t structIndex = std::get<ShaderAst::StructType>(uniform.containedType).structIndex;
auto& structDesc = Retrieve(m_currentState->structs, structIndex);
bool first = true; bool first = true;
for (const auto& member : structDesc->members) for (const auto& member : structDesc->members)
@ -1042,7 +1058,7 @@ namespace Nz
first = false; first = false;
AppendVariableDeclaration(member.type, member.name); AppendVariableDeclaration(member.type.GetResultingValue(), member.name);
Append(";"); Append(";");
} }
} }
@ -1052,11 +1068,11 @@ namespace Nz
Append(externalVar.name); Append(externalVar.name);
} }
else else
AppendVariableDeclaration(externalVar.type, externalVar.name); AppendVariableDeclaration(externalVar.type.GetResultingValue(), externalVar.name);
AppendLine(";"); AppendLine(";");
if (IsUniformType(externalVar.type)) if (IsUniformType(externalVar.type.GetResultingValue()))
AppendLine(); AppendLine();
RegisterVariable(varIndex++, externalVar.name); RegisterVariable(varIndex++, externalVar.name);
@ -1138,7 +1154,7 @@ namespace Nz
first = false; first = false;
AppendVariableDeclaration(member.type, member.name); AppendVariableDeclaration(member.type.GetResultingValue(), member.name);
Append(";"); Append(";");
} }
} }
@ -1151,7 +1167,7 @@ namespace Nz
assert(node.varIndex); assert(node.varIndex);
RegisterVariable(*node.varIndex, node.varName); RegisterVariable(*node.varIndex, node.varName);
AppendVariableDeclaration(node.varType, node.varName); AppendVariableDeclaration(node.varType.GetResultingValue(), node.varName);
if (node.initialExpression) if (node.initialExpression)
{ {
Append(" = "); Append(" = ");
@ -1239,15 +1255,20 @@ namespace Nz
} }
} }
void GlslWriter::Visit(ShaderAst::ScopedStatement& node)
{
EnterScope();
node.statement->Visit(*this);
LeaveScope(true);
}
void GlslWriter::Visit(ShaderAst::WhileStatement& node) void GlslWriter::Visit(ShaderAst::WhileStatement& node)
{ {
Append("while ("); Append("while (");
node.condition->Visit(*this); node.condition->Visit(*this);
AppendLine(")"); AppendLine(")");
EnterScope(); ScopeVisit(*node.body);
node.body->Visit(*this);
LeaveScope();
} }
bool GlslWriter::HasExplicitBinding(ShaderAst::StatementPtr& shader) bool GlslWriter::HasExplicitBinding(ShaderAst::StatementPtr& shader)

View File

@ -29,63 +29,63 @@ namespace Nz
struct LangWriter::BindingAttribute struct LangWriter::BindingAttribute
{ {
const ShaderAst::AttributeValue<UInt32>& bindingIndex; const ShaderAst::ExpressionValue<UInt32>& bindingIndex;
inline bool HasValue() const { return bindingIndex.HasValue(); } inline bool HasValue() const { return bindingIndex.HasValue(); }
}; };
struct LangWriter::BuiltinAttribute struct LangWriter::BuiltinAttribute
{ {
const ShaderAst::AttributeValue<ShaderAst::BuiltinEntry>& builtin; const ShaderAst::ExpressionValue<ShaderAst::BuiltinEntry>& builtin;
inline bool HasValue() const { return builtin.HasValue(); } inline bool HasValue() const { return builtin.HasValue(); }
}; };
struct LangWriter::DepthWriteAttribute struct LangWriter::DepthWriteAttribute
{ {
const ShaderAst::AttributeValue<ShaderAst::DepthWriteMode>& writeMode; const ShaderAst::ExpressionValue<ShaderAst::DepthWriteMode>& writeMode;
inline bool HasValue() const { return writeMode.HasValue(); } inline bool HasValue() const { return writeMode.HasValue(); }
}; };
struct LangWriter::EarlyFragmentTestsAttribute struct LangWriter::EarlyFragmentTestsAttribute
{ {
const ShaderAst::AttributeValue<bool>& earlyFragmentTests; const ShaderAst::ExpressionValue<bool>& earlyFragmentTests;
inline bool HasValue() const { return earlyFragmentTests.HasValue(); } inline bool HasValue() const { return earlyFragmentTests.HasValue(); }
}; };
struct LangWriter::EntryAttribute struct LangWriter::EntryAttribute
{ {
const ShaderAst::AttributeValue<ShaderStageType>& stageType; const ShaderAst::ExpressionValue<ShaderStageType>& stageType;
inline bool HasValue() const { return stageType.HasValue(); } inline bool HasValue() const { return stageType.HasValue(); }
}; };
struct LangWriter::LayoutAttribute struct LangWriter::LayoutAttribute
{ {
const ShaderAst::AttributeValue<StructLayout>& layout; const ShaderAst::ExpressionValue<StructLayout>& layout;
inline bool HasValue() const { return layout.HasValue(); } inline bool HasValue() const { return layout.HasValue(); }
}; };
struct LangWriter::LocationAttribute struct LangWriter::LocationAttribute
{ {
const ShaderAst::AttributeValue<UInt32>& locationIndex; const ShaderAst::ExpressionValue<UInt32>& locationIndex;
inline bool HasValue() const { return locationIndex.HasValue(); } inline bool HasValue() const { return locationIndex.HasValue(); }
}; };
struct LangWriter::SetAttribute struct LangWriter::SetAttribute
{ {
const ShaderAst::AttributeValue<UInt32>& setIndex; const ShaderAst::ExpressionValue<UInt32>& setIndex;
inline bool HasValue() const { return setIndex.HasValue(); } inline bool HasValue() const { return setIndex.HasValue(); }
}; };
struct LangWriter::UnrollAttribute struct LangWriter::UnrollAttribute
{ {
const ShaderAst::AttributeValue<ShaderAst::LoopUnroll>& unroll; const ShaderAst::ExpressionValue<ShaderAst::LoopUnroll>& unroll;
inline bool HasValue() const { return unroll.HasValue(); } inline bool HasValue() const { return unroll.HasValue(); }
}; };
@ -126,14 +126,7 @@ namespace Nz
void LangWriter::Append(const ShaderAst::ArrayType& type) void LangWriter::Append(const ShaderAst::ArrayType& type)
{ {
Append("array[", type.containedType->type, ", "); Append("array[", type.containedType->type, ", ", type.length, "]");
if (type.length.IsResultingValue())
Append(type.length.GetResultingValue());
else
type.length.GetExpression()->Visit(*this);
Append("]");
} }
void LangWriter::Append(const ShaderAst::ExpressionType& type) void LangWriter::Append(const ShaderAst::ExpressionType& type)
@ -144,11 +137,26 @@ namespace Nz
}, type); }, type);
} }
void LangWriter::Append(const ShaderAst::ExpressionValue<ShaderAst::ExpressionType>& type)
{
Append(type.GetResultingValue());
}
void LangWriter::Append(const ShaderAst::FunctionType& /*functionType*/)
{
throw std::runtime_error("unexpected function type");
}
void LangWriter::Append(const ShaderAst::IdentifierType& /*identifierType*/) void LangWriter::Append(const ShaderAst::IdentifierType& /*identifierType*/)
{ {
throw std::runtime_error("unexpected identifier type"); throw std::runtime_error("unexpected identifier type");
} }
void LangWriter::Append(const ShaderAst::IntrinsicFunctionType& /*functionType*/)
{
throw std::runtime_error("unexpected intrinsic function type");
}
void LangWriter::Append(const ShaderAst::MatrixType& matrixType) void LangWriter::Append(const ShaderAst::MatrixType& matrixType)
{ {
if (matrixType.columnCount == matrixType.rowCount) if (matrixType.columnCount == matrixType.rowCount)
@ -167,6 +175,11 @@ namespace Nz
Append("[", matrixType.type, "]"); Append("[", matrixType.type, "]");
} }
void LangWriter::Append(const ShaderAst::MethodType& /*functionType*/)
{
throw std::runtime_error("unexpected method type");
}
void LangWriter::Append(ShaderAst::PrimitiveType type) void LangWriter::Append(ShaderAst::PrimitiveType type)
{ {
switch (type) switch (type)
@ -201,14 +214,14 @@ namespace Nz
Append(structDesc->name); Append(structDesc->name);
} }
void LangWriter::Append(const ShaderAst::Type& /*type*/)
{
throw std::runtime_error("unexpected type?");
}
void LangWriter::Append(const ShaderAst::UniformType& uniformType) void LangWriter::Append(const ShaderAst::UniformType& uniformType)
{ {
Append("uniform["); Append("uniform[", uniformType.containedType, "]");
std::visit([&](auto&& arg)
{
Append(arg);
}, uniformType.containedType);
Append("]");
} }
void LangWriter::Append(const ShaderAst::VectorType& vecType) void LangWriter::Append(const ShaderAst::VectorType& vecType)
@ -411,6 +424,10 @@ namespace Nz
{ {
switch (entry.layout.GetResultingValue()) switch (entry.layout.GetResultingValue())
{ {
case StructLayout::Packed:
Append("packed");
break;
case StructLayout::Std140: case StructLayout::Std140:
Append("std140"); Append("std140");
break; break;
@ -558,6 +575,18 @@ namespace Nz
m_currentState->variableNames.emplace(varIndex, std::move(varName)); m_currentState->variableNames.emplace(varIndex, std::move(varName));
} }
void LangWriter::ScopeVisit(ShaderAst::Statement& node)
{
if (node.GetType() != ShaderAst::NodeType::ScopedStatement)
{
EnterScope();
node.Visit(*this);
LeaveScope(true);
}
else
node.Visit(*this);
}
void LangWriter::Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired) void LangWriter::Visit(ShaderAst::ExpressionPtr& expr, bool encloseIfRequired)
{ {
bool enclose = encloseIfRequired && (GetExpressionCategory(*expr) != ShaderAst::ExpressionCategory::LValue); bool enclose = encloseIfRequired && (GetExpressionCategory(*expr) != ShaderAst::ExpressionCategory::LValue);
@ -590,12 +619,19 @@ namespace Nz
assert(!IsStructType(exprType)); assert(!IsStructType(exprType));
// Array access // Array access
Append("[");
bool first = true;
for (ShaderAst::ExpressionPtr& expr : node.indices) for (ShaderAst::ExpressionPtr& expr : node.indices)
{ {
Append("["); if (!first)
Append(", ");
expr->Visit(*this); expr->Visit(*this);
Append("]"); first = false;
} }
Append("]");
} }
void LangWriter::Visit(ShaderAst::AssignExpression& node) void LangWriter::Visit(ShaderAst::AssignExpression& node)
@ -628,9 +664,7 @@ namespace Nz
statement.condition->Visit(*this); statement.condition->Visit(*this);
AppendLine(")"); AppendLine(")");
EnterScope(); ScopeVisit(*statement.statement);
statement.statement->Visit(*this);
LeaveScope();
first = false; first = false;
} }
@ -639,9 +673,7 @@ namespace Nz
{ {
AppendLine("else"); AppendLine("else");
EnterScope(); ScopeVisit(*node.elseStatement);
node.elseStatement->Visit(*this);
LeaveScope();
} }
} }
@ -800,8 +832,12 @@ namespace Nz
RegisterVariable(varIndex++, node.parameters[i].name); RegisterVariable(varIndex++, node.parameters[i].name);
} }
Append(")"); Append(")");
if (!IsNoType(node.returnType)) if (node.returnType.HasValue())
Append(" -> ", node.returnType); {
const ShaderAst::ExpressionType& returnType = node.returnType.GetResultingValue();
if (!IsNoType(returnType))
Append(" -> ", returnType);
}
AppendLine(); AppendLine();
EnterScope(); EnterScope();
@ -896,9 +932,7 @@ namespace Nz
AppendLine(); AppendLine();
EnterScope(); ScopeVisit(*node.statement);
node.statement->Visit(*this);
LeaveScope();
} }
void LangWriter::Visit(ShaderAst::ForEachStatement& node) void LangWriter::Visit(ShaderAst::ForEachStatement& node)
@ -911,9 +945,7 @@ namespace Nz
node.expression->Visit(*this); node.expression->Visit(*this);
AppendLine(); AppendLine();
EnterScope(); ScopeVisit(*node.statement);
node.statement->Visit(*this);
LeaveScope();
} }
void LangWriter::Visit(ShaderAst::IntrinsicExpression& node) void LangWriter::Visit(ShaderAst::IntrinsicExpression& node)
@ -1001,6 +1033,13 @@ namespace Nz
Append("return;"); Append("return;");
} }
void LangWriter::Visit(ShaderAst::ScopedStatement& node)
{
EnterScope();
node.statement->Visit(*this);
LeaveScope(true);
}
void LangWriter::Visit(ShaderAst::SwizzleExpression& node) void LangWriter::Visit(ShaderAst::SwizzleExpression& node)
{ {
Visit(node.expression, true); Visit(node.expression, true);
@ -1043,9 +1082,7 @@ namespace Nz
node.condition->Visit(*this); node.condition->Visit(*this);
AppendLine(")"); AppendLine(")");
EnterScope(); ScopeVisit(*node.body);
node.body->Visit(*this);
LeaveScope();
} }
void LangWriter::AppendHeader() void LangWriter::AppendHeader()

View File

@ -20,13 +20,6 @@ namespace Nz::ShaderLang
{ "unchanged", ShaderAst::DepthWriteMode::Unchanged }, { "unchanged", ShaderAst::DepthWriteMode::Unchanged },
}; };
std::unordered_map<std::string, ShaderAst::PrimitiveType> s_identifierToBasicType = {
{ "bool", ShaderAst::PrimitiveType::Boolean },
{ "i32", ShaderAst::PrimitiveType::Int32 },
{ "f32", ShaderAst::PrimitiveType::Float32 },
{ "u32", ShaderAst::PrimitiveType::UInt32 }
};
std::unordered_map<std::string, ShaderAst::AttributeType> s_identifierToAttributeType = { std::unordered_map<std::string, ShaderAst::AttributeType> s_identifierToAttributeType = {
{ "binding", ShaderAst::AttributeType::Binding }, { "binding", ShaderAst::AttributeType::Binding },
{ "builtin", ShaderAst::AttributeType::Builtin }, { "builtin", ShaderAst::AttributeType::Builtin },
@ -71,7 +64,7 @@ namespace Nz::ShaderLang
} }
template<typename T> template<typename T>
void HandleUniqueAttribute(const std::string_view& attributeName, ShaderAst::AttributeValue<T>& targetAttribute, ShaderAst::Attribute::Param&& param, bool requireValue = true) void HandleUniqueAttribute(const std::string_view& attributeName, ShaderAst::ExpressionValue<T>& targetAttribute, ShaderAst::ExprValue::Param&& param, bool requireValue = true)
{ {
if (targetAttribute.HasValue()) if (targetAttribute.HasValue())
throw AttributeError{ "attribute " + std::string(attributeName) + " must be present once" }; throw AttributeError{ "attribute " + std::string(attributeName) + " must be present once" };
@ -83,7 +76,7 @@ namespace Nz::ShaderLang
} }
template<typename T> template<typename T>
void HandleUniqueStringAttribute(const std::string_view& attributeName, const std::unordered_map<std::string, T>& map, ShaderAst::AttributeValue<T>& targetAttribute, ShaderAst::Attribute::Param&& param, std::optional<T> defaultValue = {}) void HandleUniqueStringAttribute(const std::string_view& attributeName, const std::unordered_map<std::string, T>& map, ShaderAst::ExpressionValue<T>& targetAttribute, ShaderAst::ExprValue::Param&& param, std::optional<T> defaultValue = {})
{ {
if (targetAttribute.HasValue()) if (targetAttribute.HasValue())
throw AttributeError{ "attribute " + std::string(attributeName) + " must be present once" }; throw AttributeError{ "attribute " + std::string(attributeName) + " must be present once" };
@ -123,9 +116,7 @@ namespace Nz::ShaderLang
m_context = &context; m_context = &context;
std::vector<ShaderAst::Attribute> attributes; std::vector<ShaderAst::ExprValue> attributes;
EnterScope();
bool reachedEndOfStream = false; bool reachedEndOfStream = false;
while (!reachedEndOfStream) while (!reachedEndOfStream)
@ -179,8 +170,6 @@ namespace Nz::ShaderLang
} }
} }
LeaveScope();
return std::move(context.root); return std::move(context.root);
} }
@ -198,161 +187,6 @@ namespace Nz::ShaderLang
m_context->tokenIndex += count; m_context->tokenIndex += count;
} }
std::optional<ShaderAst::ExpressionType> Parser::DecodeType(const std::string& identifier)
{
if (auto it = s_identifierToBasicType.find(identifier); it != s_identifierToBasicType.end())
{
Consume();
return it->second;
}
//FIXME: Handle this better
if (identifier == "array")
{
Consume();
Expect(Advance(), TokenType::OpenSquareBracket); //< [
ShaderAst::ArrayType arrayType;
arrayType.containedType = std::make_unique<ShaderAst::ContainedType>();
arrayType.containedType->type = ParseType();
Expect(Advance(), TokenType::Comma); //< ,
arrayType.length = ParseExpression();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return arrayType;
}
else if (identifier == "mat4")
{
Consume();
ShaderAst::MatrixType matrixType;
matrixType.columnCount = 4;
matrixType.rowCount = 4;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
matrixType.type = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return matrixType;
}
else if (identifier == "mat3")
{
Consume();
ShaderAst::MatrixType matrixType;
matrixType.columnCount = 3;
matrixType.rowCount = 3;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
matrixType.type = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return matrixType;
}
else if (identifier == "mat2")
{
Consume();
ShaderAst::MatrixType matrixType;
matrixType.columnCount = 2;
matrixType.rowCount = 2;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
matrixType.type = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return matrixType;
}
else if (identifier == "sampler2D")
{
Consume();
ShaderAst::SamplerType samplerType;
samplerType.dim = ImageType::E2D;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
samplerType.sampledType = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return samplerType;
}
else if (identifier == "samplerCube")
{
Consume();
ShaderAst::SamplerType samplerType;
samplerType.dim = ImageType::Cubemap;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
samplerType.sampledType = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return samplerType;
}
else if (identifier == "uniform")
{
Consume();
ShaderAst::UniformType uniformType;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
uniformType.containedType = ShaderAst::IdentifierType{ ParseIdentifierAsName() };
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return uniformType;
}
else if (identifier == "vec2")
{
Consume();
ShaderAst::VectorType vectorType;
vectorType.componentCount = 2;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
vectorType.type = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return vectorType;
}
else if (identifier == "vec3")
{
Consume();
ShaderAst::VectorType vectorType;
vectorType.componentCount = 3;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
vectorType.type = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return vectorType;
}
else if (identifier == "vec4")
{
Consume();
ShaderAst::VectorType vectorType;
vectorType.componentCount = 4;
Expect(Advance(), TokenType::OpenSquareBracket); //< [
vectorType.type = ParsePrimitiveType();
Expect(Advance(), TokenType::ClosingSquareBracket); //< ]
return vectorType;
}
else
return std::nullopt;
}
void Parser::EnterScope()
{
m_context->scopeSizes.push_back(m_context->identifiersInScope.size());
}
const Token& Parser::Expect(const Token& token, TokenType type) const Token& Parser::Expect(const Token& token, TokenType type)
{ {
if (token.type != type) if (token.type != type)
@ -377,33 +211,15 @@ namespace Nz::ShaderLang
return token; return token;
} }
void Parser::LeaveScope()
{
assert(!m_context->scopeSizes.empty());
m_context->identifiersInScope.resize(m_context->scopeSizes.back());
m_context->scopeSizes.pop_back();
}
bool Parser::IsVariableInScope(const std::string_view& identifier) const
{
return std::find(m_context->identifiersInScope.rbegin(), m_context->identifiersInScope.rend(), identifier) != m_context->identifiersInScope.rend();
}
void Parser::RegisterVariable(std::string identifier)
{
assert(!m_context->scopeSizes.empty());
m_context->identifiersInScope.push_back(std::move(identifier));
}
const Token& Parser::Peek(std::size_t advance) const Token& Parser::Peek(std::size_t advance)
{ {
assert(m_context->tokenIndex + advance < m_context->tokenCount); assert(m_context->tokenIndex + advance < m_context->tokenCount);
return m_context->tokens[m_context->tokenIndex + advance]; return m_context->tokens[m_context->tokenIndex + advance];
} }
std::vector<ShaderAst::Attribute> Parser::ParseAttributes() std::vector<ShaderAst::ExprValue> Parser::ParseAttributes()
{ {
std::vector<ShaderAst::Attribute> attributes; std::vector<ShaderAst::ExprValue> attributes;
Expect(Advance(), TokenType::OpenSquareBracket); Expect(Advance(), TokenType::OpenSquareBracket);
@ -431,7 +247,7 @@ namespace Nz::ShaderLang
ShaderAst::AttributeType attributeType = ParseIdentifierAsAttributeType(); ShaderAst::AttributeType attributeType = ParseIdentifierAsAttributeType();
ShaderAst::Attribute::Param arg; ShaderAst::ExprValue::Param arg;
if (Peek().type == TokenType::OpenParenthesis) if (Peek().type == TokenType::OpenParenthesis)
{ {
Consume(); Consume();
@ -454,7 +270,7 @@ namespace Nz::ShaderLang
return attributes; return attributes;
} }
void Parser::ParseVariableDeclaration(std::string& name, ShaderAst::ExpressionType& type, ShaderAst::ExpressionPtr& initialValue) void Parser::ParseVariableDeclaration(std::string& name, ShaderAst::ExpressionValue<ShaderAst::ExpressionType>& type, ShaderAst::ExpressionPtr& initialValue)
{ {
name = ParseIdentifierAsName(); name = ParseIdentifierAsName();
@ -464,10 +280,8 @@ namespace Nz::ShaderLang
type = ParseType(); type = ParseType();
} }
else
type = ShaderAst::NoType{};
if (IsNoType(type) || Peek().type == TokenType::Assign) if (!type.HasValue() || Peek().type == TokenType::Assign)
{ {
Expect(Advance(), TokenType::Assign); Expect(Advance(), TokenType::Assign);
initialValue = ParseExpression(); initialValue = ParseExpression();
@ -522,11 +336,10 @@ namespace Nz::ShaderLang
case TokenType::Identifier: case TokenType::Identifier:
{ {
std::string constName; std::string constName;
ShaderAst::ExpressionType constType; ShaderAst::ExpressionValue<ShaderAst::ExpressionType> constType;
ShaderAst::ExpressionPtr initialValue; ShaderAst::ExpressionPtr initialValue;
ParseVariableDeclaration(constName, constType, initialValue); ParseVariableDeclaration(constName, constType, initialValue);
RegisterVariable(constName);
return ShaderBuilder::DeclareConst(std::move(constName), std::move(constType), std::move(initialValue)); return ShaderBuilder::DeclareConst(std::move(constName), std::move(constType), std::move(initialValue));
} }
@ -552,14 +365,14 @@ namespace Nz::ShaderLang
return ShaderBuilder::Discard(); return ShaderBuilder::Discard();
} }
ShaderAst::StatementPtr Parser::ParseExternalBlock(std::vector<ShaderAst::Attribute> attributes) ShaderAst::StatementPtr Parser::ParseExternalBlock(std::vector<ShaderAst::ExprValue> attributes)
{ {
Expect(Advance(), TokenType::External); Expect(Advance(), TokenType::External);
Expect(Advance(), TokenType::OpenCurlyBracket); Expect(Advance(), TokenType::OpenCurlyBracket);
std::unique_ptr<ShaderAst::DeclareExternalStatement> externalStatement = std::make_unique<ShaderAst::DeclareExternalStatement>(); std::unique_ptr<ShaderAst::DeclareExternalStatement> externalStatement = std::make_unique<ShaderAst::DeclareExternalStatement>();
ShaderAst::AttributeValue<bool> condition; ShaderAst::ExpressionValue<bool> condition;
for (auto&& [attributeType, arg] : attributes) for (auto&& [attributeType, arg] : attributes)
{ {
@ -624,8 +437,6 @@ namespace Nz::ShaderLang
extVar.name = ParseIdentifierAsName(); extVar.name = ParseIdentifierAsName();
Expect(Advance(), TokenType::Colon); Expect(Advance(), TokenType::Colon);
extVar.type = ParseType(); extVar.type = ParseType();
RegisterVariable(extVar.name);
} }
Expect(Advance(), TokenType::ClosingCurlyBracket); Expect(Advance(), TokenType::ClosingCurlyBracket);
@ -636,7 +447,7 @@ namespace Nz::ShaderLang
return externalStatement; return externalStatement;
} }
ShaderAst::StatementPtr Parser::ParseForDeclaration(std::vector<ShaderAst::Attribute> attributes) ShaderAst::StatementPtr Parser::ParseForDeclaration(std::vector<ShaderAst::ExprValue> attributes)
{ {
Expect(Advance(), TokenType::For); Expect(Advance(), TokenType::For);
@ -710,7 +521,7 @@ namespace Nz::ShaderLang
return ParseStatementList(); return ParseStatementList();
} }
ShaderAst::StatementPtr Parser::ParseFunctionDeclaration(std::vector<ShaderAst::Attribute> attributes) ShaderAst::StatementPtr Parser::ParseFunctionDeclaration(std::vector<ShaderAst::ExprValue> attributes)
{ {
Expect(Advance(), TokenType::FunctionDeclaration); Expect(Advance(), TokenType::FunctionDeclaration);
@ -738,24 +549,18 @@ namespace Nz::ShaderLang
Expect(Advance(), TokenType::ClosingParenthesis); Expect(Advance(), TokenType::ClosingParenthesis);
ShaderAst::ExpressionType returnType; ShaderAst::ExpressionValue<ShaderAst::ExpressionType> returnType;
if (Peek().type == TokenType::Arrow) if (Peek().type == TokenType::Arrow)
{ {
Consume(); Consume();
returnType = ParseType(); returnType = ParseType();
} }
EnterScope();
for (const auto& parameter : parameters)
RegisterVariable(parameter.name);
std::vector<ShaderAst::StatementPtr> functionBody = ParseFunctionBody(); std::vector<ShaderAst::StatementPtr> functionBody = ParseFunctionBody();
LeaveScope();
auto func = ShaderBuilder::DeclareFunction(std::move(functionName), std::move(parameters), std::move(functionBody), std::move(returnType)); auto func = ShaderBuilder::DeclareFunction(std::move(functionName), std::move(parameters), std::move(functionBody), std::move(returnType));
ShaderAst::AttributeValue<bool> condition; ShaderAst::ExpressionValue<bool> condition;
for (auto&& [attributeType, arg] : attributes) for (auto&& [attributeType, arg] : attributes)
{ {
@ -794,7 +599,7 @@ namespace Nz::ShaderLang
Expect(Advance(), TokenType::Colon); Expect(Advance(), TokenType::Colon);
ShaderAst::ExpressionType parameterType = ParseType(); ShaderAst::ExpressionPtr parameterType = ParseType();
return { parameterName, std::move(parameterType) }; return { parameterName, std::move(parameterType) };
} }
@ -807,7 +612,7 @@ namespace Nz::ShaderLang
Expect(Advance(), TokenType::Colon); Expect(Advance(), TokenType::Colon);
ShaderAst::ExpressionType optionType = ParseType(); ShaderAst::ExpressionPtr optionType = ParseType();
ShaderAst::ExpressionPtr initialValue; ShaderAst::ExpressionPtr initialValue;
if (Peek().type == TokenType::Assign) if (Peek().type == TokenType::Assign)
@ -837,7 +642,7 @@ namespace Nz::ShaderLang
ShaderAst::StatementPtr Parser::ParseSingleStatement() ShaderAst::StatementPtr Parser::ParseSingleStatement()
{ {
std::vector<ShaderAst::Attribute> attributes; std::vector<ShaderAst::ExprValue> attributes;
ShaderAst::StatementPtr statement; ShaderAst::StatementPtr statement;
do do
{ {
@ -912,15 +717,13 @@ namespace Nz::ShaderLang
ShaderAst::StatementPtr Parser::ParseStatement() ShaderAst::StatementPtr Parser::ParseStatement()
{ {
if (Peek().type == TokenType::OpenCurlyBracket) if (Peek().type == TokenType::OpenCurlyBracket)
return ShaderBuilder::MultiStatement(ParseStatementList()); return ShaderBuilder::Scoped(ShaderBuilder::MultiStatement(ParseStatementList()));
else else
return ParseSingleStatement(); return ParseSingleStatement();
} }
std::vector<ShaderAst::StatementPtr> Parser::ParseStatementList() std::vector<ShaderAst::StatementPtr> Parser::ParseStatementList()
{ {
EnterScope();
Expect(Advance(), TokenType::OpenCurlyBracket); Expect(Advance(), TokenType::OpenCurlyBracket);
std::vector<ShaderAst::StatementPtr> statements; std::vector<ShaderAst::StatementPtr> statements;
@ -931,19 +734,17 @@ namespace Nz::ShaderLang
} }
Consume(); //< Consume closing curly bracket Consume(); //< Consume closing curly bracket
LeaveScope();
return statements; return statements;
} }
ShaderAst::StatementPtr Parser::ParseStructDeclaration(std::vector<ShaderAst::Attribute> attributes) ShaderAst::StatementPtr Parser::ParseStructDeclaration(std::vector<ShaderAst::ExprValue> attributes)
{ {
Expect(Advance(), TokenType::Struct); Expect(Advance(), TokenType::Struct);
ShaderAst::StructDescription description; ShaderAst::StructDescription description;
description.name = ParseIdentifierAsName(); description.name = ParseIdentifierAsName();
ShaderAst::AttributeValue<bool> condition; ShaderAst::ExpressionValue<bool> condition;
for (auto&& [attributeType, attributeParam] : attributes) for (auto&& [attributeType, attributeParam] : attributes)
{ {
@ -1065,16 +866,15 @@ namespace Nz::ShaderLang
Expect(Advance(), TokenType::Let); Expect(Advance(), TokenType::Let);
std::string variableName; std::string variableName;
ShaderAst::ExpressionType variableType; ShaderAst::ExpressionValue<ShaderAst::ExpressionType> variableType;
ShaderAst::ExpressionPtr expression; ShaderAst::ExpressionPtr expression;
ParseVariableDeclaration(variableName, variableType, expression); ParseVariableDeclaration(variableName, variableType, expression);
RegisterVariable(variableName);
return ShaderBuilder::DeclareVariable(std::move(variableName), std::move(variableType), std::move(expression)); return ShaderBuilder::DeclareVariable(std::move(variableName), std::move(variableType), std::move(expression));
} }
ShaderAst::StatementPtr Parser::ParseWhileStatement(std::vector<ShaderAst::Attribute> attributes) ShaderAst::StatementPtr Parser::ParseWhileStatement(std::vector<ShaderAst::ExprValue> attributes)
{ {
Expect(Advance(), TokenType::While); Expect(Advance(), TokenType::While);
@ -1133,19 +933,6 @@ namespace Nz::ShaderLang
accessMemberNode->identifiers.push_back(ParseIdentifierAsName()); accessMemberNode->identifiers.push_back(ParseIdentifierAsName());
} while (Peek().type == TokenType::Dot); } while (Peek().type == TokenType::Dot);
// FIXME
if (!accessMemberNode->identifiers.empty() && accessMemberNode->identifiers.front() == "Sample")
{
if (Peek().type == TokenType::OpenParenthesis)
{
auto parameters = ParseParameters();
parameters.insert(parameters.begin(), std::move(accessMemberNode->expr));
lhs = ShaderBuilder::Intrinsic(ShaderAst::IntrinsicType::SampleTexture, std::move(parameters));
break;
}
}
lhs = std::move(accessMemberNode); lhs = std::move(accessMemberNode);
} }
else else
@ -1160,10 +947,10 @@ namespace Nz::ShaderLang
Consume(); Consume();
indexNode->indices.push_back(ParseExpression()); indexNode->indices.push_back(ParseExpression());
Expect(Advance(), TokenType::ClosingSquareBracket);
} }
while (Peek().type == TokenType::OpenSquareBracket); while (Peek().type == TokenType::Comma);
Expect(Advance(), TokenType::ClosingSquareBracket);
lhs = std::move(indexNode); lhs = std::move(indexNode);
} }
@ -1171,6 +958,15 @@ namespace Nz::ShaderLang
currentTokenType = Peek().type; currentTokenType = Peek().type;
} }
if (currentTokenType == TokenType::OpenParenthesis)
{
// Function call
auto parameters = ParseParameters();
lhs = ShaderBuilder::CallFunction(std::move(lhs), std::move(parameters));
c = true;
}
if (c) if (c)
continue; continue;
@ -1302,23 +1098,7 @@ namespace Nz::ShaderLang
return ParseFloatingPointExpression(); return ParseFloatingPointExpression();
case TokenType::Identifier: case TokenType::Identifier:
{ return ParseIdentifier();
const std::string& identifier = std::get<std::string>(token.data);
// Is it a cast?
std::optional<ShaderAst::ExpressionType> exprType = DecodeType(identifier);
if (exprType)
return ShaderBuilder::Cast(std::move(*exprType), ParseParameters());
if (Peek(1).type == TokenType::OpenParenthesis)
{
// Function call
Consume();
return ShaderBuilder::CallFunction(identifier, ParseParameters());
}
else
return ParseIdentifier();
}
case TokenType::IntegerValue: case TokenType::IntegerValue:
return ParseIntegerExpression(); return ParseIntegerExpression();
@ -1370,28 +1150,10 @@ namespace Nz::ShaderLang
const std::string& Parser::ParseIdentifierAsName() const std::string& Parser::ParseIdentifierAsName()
{ {
const Token& identifierToken = Expect(Advance(), TokenType::Identifier); const Token& identifierToken = Expect(Advance(), TokenType::Identifier);
const std::string& identifier = std::get<std::string>(identifierToken.data); return std::get<std::string>(identifierToken.data);
auto it = s_identifierToBasicType.find(identifier);
if (it != s_identifierToBasicType.end())
throw ReservedKeyword{};
return identifier;
} }
ShaderAst::PrimitiveType Parser::ParsePrimitiveType() ShaderAst::ExpressionPtr Parser::ParseType()
{
const Token& identifierToken = Expect(Advance(), TokenType::Identifier);
const std::string& identifier = std::get<std::string>(identifierToken.data);
auto it = s_identifierToBasicType.find(identifier);
if (it == s_identifierToBasicType.end())
throw UnknownType{};
return it->second;
}
ShaderAst::ExpressionType Parser::ParseType()
{ {
// Handle () as no type // Handle () as no type
if (Peek().type == TokenType::OpenParenthesis) if (Peek().type == TokenType::OpenParenthesis)
@ -1399,20 +1161,10 @@ namespace Nz::ShaderLang
Consume(); Consume();
Expect(Advance(), TokenType::ClosingParenthesis); Expect(Advance(), TokenType::ClosingParenthesis);
return ShaderAst::NoType{}; return ShaderBuilder::Constant(ShaderAst::NoValue{});
} }
const Token& identifierToken = Expect(Peek(), TokenType::Identifier); return ParseExpression();
const std::string& identifier = std::get<std::string>(identifierToken.data);
auto type = DecodeType(identifier);
if (!type)
{
Consume();
return ShaderAst::IdentifierType{ identifier };
}
return *std::move(type);
} }
int Parser::GetTokenPrecedence(TokenType token) int Parser::GetTokenPrecedence(TokenType token)
@ -1433,6 +1185,7 @@ namespace Nz::ShaderLang
case TokenType::NotEqual: return 50; case TokenType::NotEqual: return 50;
case TokenType::Plus: return 60; case TokenType::Plus: return 60;
case TokenType::OpenSquareBracket: return 100; case TokenType::OpenSquareBracket: return 100;
case TokenType::OpenParenthesis: return 100;
default: return -1; default: return -1;
} }
} }

View File

@ -400,8 +400,7 @@ namespace Nz
void SpirvAstVisitor::Visit(ShaderAst::CallFunctionExpression& node) void SpirvAstVisitor::Visit(ShaderAst::CallFunctionExpression& node)
{ {
assert(std::holds_alternative<std::size_t>(node.targetFunction)); std::size_t functionIndex = std::get<ShaderAst::FunctionType>(GetExpressionType(*node.targetFunction)).funcIndex;
std::size_t functionIndex = std::get<std::size_t>(node.targetFunction);
UInt32 funcId = 0; UInt32 funcId = 0;
for (const auto& [funcIndex, func] : m_funcData) for (const auto& [funcIndex, func] : m_funcData)
@ -443,7 +442,7 @@ namespace Nz
void SpirvAstVisitor::Visit(ShaderAst::CastExpression& node) void SpirvAstVisitor::Visit(ShaderAst::CastExpression& node)
{ {
const ShaderAst::ExpressionType& targetExprType = node.targetType; const ShaderAst::ExpressionType& targetExprType = node.targetType.GetResultingValue();
if (IsPrimitiveType(targetExprType)) if (IsPrimitiveType(targetExprType))
{ {
ShaderAst::PrimitiveType targetType = std::get<ShaderAst::PrimitiveType>(targetExprType); ShaderAst::PrimitiveType targetType = std::get<ShaderAst::PrimitiveType>(targetExprType);
@ -584,7 +583,7 @@ namespace Nz
std::size_t varIndex = *node.varIndex; std::size_t varIndex = *node.varIndex;
for (auto&& extVar : node.externalVars) for (auto&& extVar : node.externalVars)
RegisterExternalVariable(varIndex++, extVar.type); RegisterExternalVariable(varIndex++, extVar.type.GetResultingValue());
} }
void SpirvAstVisitor::Visit(ShaderAst::DeclareFunctionStatement& node) void SpirvAstVisitor::Visit(ShaderAst::DeclareFunctionStatement& node)
@ -674,7 +673,7 @@ namespace Nz
{ {
const auto& func = m_funcData[m_funcIndex]; const auto& func = m_funcData[m_funcIndex];
UInt32 typeId = m_writer.GetTypeId(node.varType); UInt32 typeId = m_writer.GetTypeId(node.varType.GetResultingValue());
assert(node.varIndex); assert(node.varIndex);
auto varIt = func.varIndexToVarId.find(*node.varIndex); auto varIt = func.varIndexToVarId.find(*node.varIndex);
@ -932,6 +931,11 @@ namespace Nz
m_currentBlock->Append(SpirvOp::OpReturn); m_currentBlock->Append(SpirvOp::OpReturn);
} }
void SpirvAstVisitor::Visit(ShaderAst::ScopedStatement& node)
{
node.statement->Visit(*this);
}
void SpirvAstVisitor::Visit(ShaderAst::SwizzleExpression& node) void SpirvAstVisitor::Visit(ShaderAst::SwizzleExpression& node)
{ {
const ShaderAst::ExpressionType& swizzledExpressionType = GetExpressionType(*node.expression); const ShaderAst::ExpressionType& swizzledExpressionType = GetExpressionType(*node.expression);

View File

@ -513,7 +513,7 @@ namespace Nz
for (const Structure::Member& member : structData.members) for (const Structure::Member& member : structData.members)
{ {
member.offset = std::visit([&](auto&& arg) -> std::size_t member.offset = SafeCast<UInt32>(std::visit([&](auto&& arg) -> std::size_t
{ {
using T = std::decay_t<decltype(arg)>; using T = std::decay_t<decltype(arg)>;
@ -601,7 +601,7 @@ namespace Nz
throw std::runtime_error("unexpected void as struct member"); throw std::runtime_error("unexpected void as struct member");
else else
static_assert(AlwaysFalse<T>::value, "non-exhaustive visitor"); static_assert(AlwaysFalse<T>::value, "non-exhaustive visitor");
}, member.type->type); }, member.type->type));
} }
return structOffsets; return structOffsets;
@ -671,7 +671,7 @@ namespace Nz
return std::make_shared<Type>(Array{ return std::make_shared<Type>(Array{
builtContainedType, builtContainedType,
BuildConstant(type.length.GetResultingValue()), BuildConstant(type.length),
arrayStride arrayStride
}); });
} }
@ -802,7 +802,7 @@ namespace Nz
auto& sMembers = sType.members.emplace_back(); auto& sMembers = sType.members.emplace_back();
sMembers.name = member.name; sMembers.name = member.name;
sMembers.type = BuildType(member.type); sMembers.type = BuildType(member.type.GetResultingValue());
} }
m_internal->isInBlockStruct = wasInBlock; m_internal->isInBlockStruct = wasInBlock;
@ -817,8 +817,7 @@ namespace Nz
auto SpirvConstantCache::BuildType(const ShaderAst::UniformType& type) const -> TypePtr auto SpirvConstantCache::BuildType(const ShaderAst::UniformType& type) const -> TypePtr
{ {
assert(std::holds_alternative<ShaderAst::StructType>(type.containedType)); return BuildType(type.containedType);
return BuildType(std::get<ShaderAst::StructType>(type.containedType));
} }
UInt32 SpirvConstantCache::GetId(const Constant& c) UInt32 SpirvConstantCache::GetId(const Constant& c)
@ -918,12 +917,12 @@ namespace Nz
return fieldOffsets.AddFieldArray(TypeToStructFieldType(type), arrayLength); return fieldOffsets.AddFieldArray(TypeToStructFieldType(type), arrayLength);
} }
std::size_t SpirvConstantCache::RegisterArrayField(FieldOffsets& fieldOffsets, const Function& type, std::size_t arrayLength) const std::size_t SpirvConstantCache::RegisterArrayField(FieldOffsets& /*fieldOffsets*/, const Function& /*type*/, std::size_t /*arrayLength*/) const
{ {
throw std::runtime_error("unexpected Function"); throw std::runtime_error("unexpected Function");
} }
std::size_t SpirvConstantCache::RegisterArrayField(FieldOffsets& fieldOffsets, const Image& type, std::size_t arrayLength) const std::size_t SpirvConstantCache::RegisterArrayField(FieldOffsets& /*fieldOffsets*/, const Image& /*type*/, std::size_t /*arrayLength*/) const
{ {
throw std::runtime_error("unexpected Image"); throw std::runtime_error("unexpected Image");
} }

View File

@ -30,9 +30,46 @@ namespace Nz
return resultId; return resultId;
}, },
[this](const PointerChainAccess& pointerChainAccess) -> UInt32
{
UInt32 pointerType = m_writer.RegisterPointerType(*pointerChainAccess.exprType, pointerChainAccess.storage); //< FIXME: We shouldn't register this so late
UInt32 pointerId = m_visitor.AllocateResultId();
m_block.AppendVariadic(SpirvOp::OpAccessChain, [&](const auto& appender)
{
appender(pointerType);
appender(pointerId);
appender(pointerChainAccess.pointerId);
for (UInt32 id : pointerChainAccess.indices)
appender(id);
});
UInt32 resultId = m_visitor.AllocateResultId();
m_block.Append(SpirvOp::OpLoad, m_writer.GetTypeId(*pointerChainAccess.exprType), resultId, pointerId);
return resultId;
},
[](const Value& value) -> UInt32 [](const Value& value) -> UInt32
{ {
return value.resultId; return value.valueId;
},
[this](const ValueExtraction& extractedValue) -> UInt32
{
UInt32 resultId = m_visitor.AllocateResultId();
m_block.AppendVariadic(SpirvOp::OpCompositeExtract, [&](const auto& appender)
{
appender(extractedValue.typeId);
appender(resultId);
appender(extractedValue.valueId);
for (UInt32 id : extractedValue.indices)
appender(id);
});
return resultId;
}, },
[](std::monostate) -> UInt32 [](std::monostate) -> UInt32
{ {
@ -47,48 +84,42 @@ namespace Nz
const ShaderAst::ExpressionType& exprType = GetExpressionType(node); const ShaderAst::ExpressionType& exprType = GetExpressionType(node);
UInt32 resultId = m_visitor.AllocateResultId();
UInt32 typeId = m_writer.GetTypeId(exprType); UInt32 typeId = m_writer.GetTypeId(exprType);
assert(node.indices.size() == 1);
UInt32 indexId = m_visitor.EvaluateExpression(node.indices.front());
std::visit(overloaded std::visit(overloaded
{ {
[&](const Pointer& pointer) [&](const Pointer& pointer)
{ {
UInt32 pointerType = m_writer.RegisterPointerType(exprType, pointer.storage); //< FIXME PointerChainAccess pointerChainAccess;
pointerChainAccess.exprType = &exprType;
pointerChainAccess.indices = { indexId };
pointerChainAccess.pointedTypeId = pointer.pointedTypeId;
pointerChainAccess.pointerId = pointer.pointerId;
pointerChainAccess.storage = pointer.storage;
StackArray<UInt32> indexIds = NazaraStackArrayNoInit(UInt32, node.indices.size()); m_value = std::move(pointerChainAccess);
for (std::size_t i = 0; i < node.indices.size(); ++i) },
indexIds[i] = m_visitor.EvaluateExpression(node.indices[i]); [&](PointerChainAccess& pointerChainAccess)
{
m_block.AppendVariadic(SpirvOp::OpAccessChain, [&](const auto& appender) pointerChainAccess.exprType = &exprType;
{ pointerChainAccess.indices.push_back(indexId);
appender(pointerType);
appender(resultId);
appender(pointer.pointerId);
for (UInt32 id : indexIds)
appender(id);
});
m_value = Pointer { pointer.storage, resultId, typeId };
}, },
[&](const Value& value) [&](const Value& value)
{ {
StackArray<UInt32> indexIds = NazaraStackArrayNoInit(UInt32, node.indices.size()); ValueExtraction extractedValue;
for (std::size_t i = 0; i < node.indices.size(); ++i) extractedValue.indices = { indexId };
indexIds[i] = m_visitor.EvaluateExpression(node.indices[i]); extractedValue.typeId = typeId;
extractedValue.valueId = value.valueId;
m_block.AppendVariadic(SpirvOp::OpCompositeExtract, [&](const auto& appender) m_value = std::move(extractedValue);
{ },
appender(typeId); [&](ValueExtraction& extractedValue)
appender(resultId); {
appender(value.resultId); extractedValue.indices.push_back(indexId);
extractedValue.typeId = typeId;
for (UInt32 id : indexIds)
appender(id);
});
m_value = Value { resultId };
}, },
[](std::monostate) [](std::monostate)
{ {

View File

@ -100,19 +100,10 @@ namespace Nz
UInt32 resultId = m_visitor.AllocateResultId(); UInt32 resultId = m_visitor.AllocateResultId();
UInt32 pointerType = m_writer.RegisterPointerType(exprType, pointer.storage); //< FIXME UInt32 pointerType = m_writer.RegisterPointerType(exprType, pointer.storage); //< FIXME
StackArray<UInt32> indexIds = NazaraStackArrayNoInit(UInt32, node.indices.size()); assert(node.indices.size() == 1);
for (std::size_t i = 0; i < node.indices.size(); ++i) UInt32 indexId = m_visitor.EvaluateExpression(node.indices.front());
indexIds[i] = m_visitor.EvaluateExpression(node.indices[i]);
m_block.AppendVariadic(SpirvOp::OpAccessChain, [&](const auto& appender) m_block.Append(SpirvOp::OpAccessChain, pointerType, resultId, pointer.pointerId, indexId);
{
appender(pointerType);
appender(resultId);
appender(pointer.pointerId);
for (UInt32 id : indexIds)
appender(id);
});
m_value = Pointer { pointer.storage, resultId }; m_value = Pointer { pointer.storage, resultId };
}, },
@ -147,6 +138,8 @@ namespace Nz
{ {
// Swizzle the swizzle, keep common components // Swizzle the swizzle, keep common components
std::array<UInt32, 4> newIndices; std::array<UInt32, 4> newIndices;
newIndices.fill(0); //< keep compiler happy
for (std::size_t i = 0; i < node.componentCount; ++i) for (std::size_t i = 0; i < node.componentCount; ++i)
{ {
assert(node.components[i] < swizzledPointer.componentCount); assert(node.components[i] < swizzledPointer.componentCount);

View File

@ -144,17 +144,18 @@ namespace Nz
SpirvConstantCache::Variable variable; SpirvConstantCache::Variable variable;
variable.debugName = extVar.name; variable.debugName = extVar.name;
if (ShaderAst::IsSamplerType(extVar.type)) const ShaderAst::ExpressionType& extVarType = extVar.type.GetResultingValue();
if (ShaderAst::IsSamplerType(extVarType))
{ {
variable.storageClass = SpirvStorageClass::UniformConstant; variable.storageClass = SpirvStorageClass::UniformConstant;
variable.type = m_constantCache.BuildPointerType(extVar.type, variable.storageClass); variable.type = m_constantCache.BuildPointerType(extVarType, variable.storageClass);
} }
else else
{ {
assert(ShaderAst::IsUniformType(extVar.type)); assert(ShaderAst::IsUniformType(extVarType));
const auto& uniformType = std::get<ShaderAst::UniformType>(extVar.type); const auto& uniformType = std::get<ShaderAst::UniformType>(extVarType);
assert(std::holds_alternative<ShaderAst::StructType>(uniformType.containedType)); const auto& structType = uniformType.containedType;
const auto& structType = std::get<ShaderAst::StructType>(uniformType.containedType);
assert(structType.structIndex < declaredStructs.size()); assert(structType.structIndex < declaredStructs.size());
const auto& type = m_constantCache.BuildType(*declaredStructs[structType.structIndex], { SpirvDecoration::Block }); const auto& type = m_constantCache.BuildType(*declaredStructs[structType.structIndex], { SpirvDecoration::Block });
@ -188,16 +189,27 @@ namespace Nz
{ {
std::vector<ShaderAst::ExpressionType> parameterTypes; std::vector<ShaderAst::ExpressionType> parameterTypes;
for (auto& parameter : node.parameters) for (auto& parameter : node.parameters)
parameterTypes.push_back(parameter.type); parameterTypes.push_back(parameter.type.GetResultingValue());
funcData.returnTypeId = m_constantCache.Register(*m_constantCache.BuildType(node.returnType)); if (node.returnType.HasValue())
funcData.funcTypeId = m_constantCache.Register(*m_constantCache.BuildFunctionType(node.returnType, parameterTypes)); {
const auto& returnType = node.returnType.GetResultingValue();
funcData.returnTypeId = m_constantCache.Register(*m_constantCache.BuildType(returnType));
funcData.funcTypeId = m_constantCache.Register(*m_constantCache.BuildFunctionType(returnType, parameterTypes));
}
else
{
funcData.returnTypeId = m_constantCache.Register(*m_constantCache.BuildType(ShaderAst::NoType{}));
funcData.funcTypeId = m_constantCache.Register(*m_constantCache.BuildFunctionType(ShaderAst::NoType{}, parameterTypes));
}
for (auto& parameter : node.parameters) for (auto& parameter : node.parameters)
{ {
const auto& parameterType = parameter.type.GetResultingValue();
auto& funcParam = funcData.parameters.emplace_back(); auto& funcParam = funcData.parameters.emplace_back();
funcParam.pointerTypeId = m_constantCache.Register(*m_constantCache.BuildPointerType(parameter.type, SpirvStorageClass::Function)); funcParam.pointerTypeId = m_constantCache.Register(*m_constantCache.BuildPointerType(parameterType, SpirvStorageClass::Function));
funcParam.typeId = m_constantCache.Register(*m_constantCache.BuildType(parameter.type)); funcParam.typeId = m_constantCache.Register(*m_constantCache.BuildType(parameterType));
} }
} }
else else
@ -235,9 +247,11 @@ namespace Nz
{ {
assert(node.parameters.size() == 1); assert(node.parameters.size() == 1);
auto& parameter = node.parameters.front(); auto& parameter = node.parameters.front();
assert(std::holds_alternative<ShaderAst::StructType>(parameter.type)); const auto& parameterType = parameter.type.GetResultingValue();
std::size_t structIndex = std::get<ShaderAst::StructType>(parameter.type).structIndex; assert(std::holds_alternative<ShaderAst::StructType>(parameterType));
std::size_t structIndex = std::get<ShaderAst::StructType>(parameterType).structIndex;
const ShaderAst::StructDescription* structDesc = declaredStructs[structIndex]; const ShaderAst::StructDescription* structDesc = declaredStructs[structIndex];
std::size_t memberIndex = 0; std::size_t memberIndex = 0;
@ -250,7 +264,7 @@ namespace Nz
{ {
inputs.push_back({ inputs.push_back({
m_constantCache.Register(*m_constantCache.BuildConstant(Int32(memberIndex))), m_constantCache.Register(*m_constantCache.BuildConstant(Int32(memberIndex))),
m_constantCache.Register(*m_constantCache.BuildPointerType(member.type, SpirvStorageClass::Function)), m_constantCache.Register(*m_constantCache.BuildPointerType(member.type.GetResultingValue(), SpirvStorageClass::Function)),
varId varId
}); });
} }
@ -259,18 +273,20 @@ namespace Nz
} }
inputStruct = EntryPoint::InputStruct{ inputStruct = EntryPoint::InputStruct{
m_constantCache.Register(*m_constantCache.BuildPointerType(parameter.type, SpirvStorageClass::Function)), m_constantCache.Register(*m_constantCache.BuildPointerType(parameterType, SpirvStorageClass::Function)),
m_constantCache.Register(*m_constantCache.BuildType(parameter.type)) m_constantCache.Register(*m_constantCache.BuildType(parameter.type.GetResultingValue()))
}; };
} }
std::optional<UInt32> outputStructId; std::optional<UInt32> outputStructId;
std::vector<EntryPoint::Output> outputs; std::vector<EntryPoint::Output> outputs;
if (!IsNoType(node.returnType)) if (node.returnType.HasValue())
{ {
assert(std::holds_alternative<ShaderAst::StructType>(node.returnType)); const ShaderAst::ExpressionType& returnType = node.returnType.GetResultingValue();
std::size_t structIndex = std::get<ShaderAst::StructType>(node.returnType).structIndex; assert(std::holds_alternative<ShaderAst::StructType>(returnType));
std::size_t structIndex = std::get<ShaderAst::StructType>(returnType).structIndex;
const ShaderAst::StructDescription* structDesc = declaredStructs[structIndex]; const ShaderAst::StructDescription* structDesc = declaredStructs[structIndex];
std::size_t memberIndex = 0; std::size_t memberIndex = 0;
@ -283,7 +299,7 @@ namespace Nz
{ {
outputs.push_back({ outputs.push_back({
Int32(memberIndex), Int32(memberIndex),
m_constantCache.Register(*m_constantCache.BuildType(member.type)), m_constantCache.Register(*m_constantCache.BuildType(member.type.GetResultingValue())),
varId varId
}); });
} }
@ -291,7 +307,7 @@ namespace Nz
memberIndex++; memberIndex++;
} }
outputStructId = m_constantCache.Register(*m_constantCache.BuildType(node.returnType)); outputStructId = m_constantCache.Register(*m_constantCache.BuildType(returnType));
} }
funcData.entryPointData = EntryPoint{ funcData.entryPointData = EntryPoint{
@ -334,7 +350,7 @@ namespace Nz
func.varIndexToVarId[*node.varIndex] = func.variables.size(); func.varIndexToVarId[*node.varIndex] = func.variables.size();
auto& var = func.variables.emplace_back(); auto& var = func.variables.emplace_back();
var.typeId = m_constantCache.Register(*m_constantCache.BuildPointerType(node.varType, SpirvStorageClass::Function)); var.typeId = m_constantCache.Register(*m_constantCache.BuildPointerType(node.varType.GetResultingValue(), SpirvStorageClass::Function));
} }
void Visit(ShaderAst::IdentifierExpression& node) override void Visit(ShaderAst::IdentifierExpression& node) override
@ -408,7 +424,7 @@ namespace Nz
variable.debugName = builtin.debugName; variable.debugName = builtin.debugName;
variable.funcId = funcIndex; variable.funcId = funcIndex;
variable.storageClass = storageClass; variable.storageClass = storageClass;
variable.type = m_constantCache.BuildPointerType(member.type, storageClass); variable.type = m_constantCache.BuildPointerType(member.type.GetResultingValue(), storageClass);
UInt32 varId = m_constantCache.Register(variable); UInt32 varId = m_constantCache.Register(variable);
builtinDecorations[varId] = builtinDecoration; builtinDecorations[varId] = builtinDecoration;
@ -421,7 +437,7 @@ namespace Nz
variable.debugName = member.name; variable.debugName = member.name;
variable.funcId = funcIndex; variable.funcId = funcIndex;
variable.storageClass = storageClass; variable.storageClass = storageClass;
variable.type = m_constantCache.BuildPointerType(member.type, storageClass); variable.type = m_constantCache.BuildPointerType(member.type.GetResultingValue(), storageClass);
UInt32 varId = m_constantCache.Register(variable); UInt32 varId = m_constantCache.Register(variable);
locationDecorations[varId] = member.locationIndex.GetResultingValue(); locationDecorations[varId] = member.locationIndex.GetResultingValue();
@ -643,9 +659,12 @@ namespace Nz
parameterTypes.reserve(functionNode.parameters.size()); parameterTypes.reserve(functionNode.parameters.size());
for (const auto& parameter : functionNode.parameters) for (const auto& parameter : functionNode.parameters)
parameterTypes.push_back(parameter.type); parameterTypes.push_back(parameter.type.GetResultingValue());
return m_currentState->constantTypeCache.BuildFunctionType(functionNode.returnType, parameterTypes); if (functionNode.returnType.HasValue())
return m_currentState->constantTypeCache.BuildFunctionType(functionNode.returnType.GetResultingValue(), parameterTypes);
else
return m_currentState->constantTypeCache.BuildFunctionType(ShaderAst::NoType{}, parameterTypes);
} }
UInt32 SpirvWriter::GetConstantId(const ShaderAst::ConstantValue& value) const UInt32 SpirvWriter::GetConstantId(const ShaderAst::ConstantValue& value) const

View File

@ -38,7 +38,7 @@ external
auto secondAccess = Nz::ShaderBuilder::AccessMember(std::move(firstAccess), { "field" }); auto secondAccess = Nz::ShaderBuilder::AccessMember(std::move(firstAccess), { "field" });
auto swizzle = Nz::ShaderBuilder::Swizzle(std::move(secondAccess), { 2u }); auto swizzle = Nz::ShaderBuilder::Swizzle(std::move(secondAccess), { 2u });
auto varDecl = Nz::ShaderBuilder::DeclareVariable("result", Nz::ShaderAst::PrimitiveType::Float32, std::move(swizzle)); auto varDecl = Nz::ShaderBuilder::DeclareVariable("result", Nz::ShaderAst::ExpressionType{ Nz::ShaderAst::PrimitiveType::Float32 }, std::move(swizzle));
multiStatement.statements.push_back(Nz::ShaderBuilder::DeclareFunction(Nz::ShaderStageType::Vertex, "main", std::move(varDecl))); multiStatement.statements.push_back(Nz::ShaderBuilder::DeclareFunction(Nz::ShaderStageType::Vertex, "main", std::move(varDecl)));
@ -75,7 +75,7 @@ OpFunctionEnd)");
auto access = Nz::ShaderBuilder::AccessMember(std::move(ubo), { "s", "field" }); auto access = Nz::ShaderBuilder::AccessMember(std::move(ubo), { "s", "field" });
auto swizzle = Nz::ShaderBuilder::Swizzle(std::move(access), { 2u }); auto swizzle = Nz::ShaderBuilder::Swizzle(std::move(access), { 2u });
auto varDecl = Nz::ShaderBuilder::DeclareVariable("result", Nz::ShaderAst::PrimitiveType::Float32, std::move(swizzle)); auto varDecl = Nz::ShaderBuilder::DeclareVariable("result", Nz::ShaderAst::ExpressionType{ Nz::ShaderAst::PrimitiveType::Float32 }, std::move(swizzle));
multiStatement.statements.push_back(Nz::ShaderBuilder::DeclareFunction(Nz::ShaderStageType::Vertex, "main", std::move(varDecl))); multiStatement.statements.push_back(Nz::ShaderBuilder::DeclareFunction(Nz::ShaderStageType::Vertex, "main", std::move(varDecl)));

View File

@ -315,7 +315,6 @@ OpULessThan
OpLoopMerge OpLoopMerge
OpBranchConditional OpBranchConditional
OpLabel OpLabel
OpAccessChain
OpLoad OpLoad
OpAccessChain OpAccessChain
OpLoad OpLoad

View File

@ -33,6 +33,7 @@ fn main()
fn main() fn main()
{ {
let output: f32 = 42.000000; let output: f32 = 42.000000;
}
)"); )");
} }

View File

@ -150,8 +150,8 @@ OpFunctionEnd)");
[entry(frag)] [entry(frag)]
fn main() fn main()
{ {
let vec = max(2.0, 1.0).xxx; let v = max(2.0, 1.0).xxx;
let vec2 = min(2.0, 1.0).xxx; let v2 = min(2.0, 1.0).xxx;
} }
)"; )";
@ -161,9 +161,9 @@ fn main()
void main() void main()
{ {
float cachedResult = max(2.000000, 1.000000); float cachedResult = max(2.000000, 1.000000);
vec3 vec = vec3(cachedResult, cachedResult, cachedResult); vec3 v = vec3(cachedResult, cachedResult, cachedResult);
float cachedResult_2 = min(2.000000, 1.000000); float cachedResult_2 = min(2.000000, 1.000000);
vec3 vec2_ = vec3(cachedResult_2, cachedResult_2, cachedResult_2); vec3 v2 = vec3(cachedResult_2, cachedResult_2, cachedResult_2);
} }
)"); )");
@ -171,8 +171,8 @@ void main()
[entry(frag)] [entry(frag)]
fn main() fn main()
{ {
let vec: vec3[f32] = (max(2.000000, 1.000000)).xxx; let v: vec3[f32] = (max(2.000000, 1.000000)).xxx;
let vec2: vec3[f32] = (min(2.000000, 1.000000)).xxx; let v2: vec3[f32] = (min(2.000000, 1.000000)).xxx;
} }
)"); )");