sid
/
NazaraEngine
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NzHardwareBuffer::Fill now call glBufferSubData instead of glMapBuffer is the locked size is under 32k

This commit is contained in:
Lynix 2012-05-03 00:26:06 +02:00
parent 63a220a349
commit 5d816122c8
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Nazara/Renderer/HardwareBuffer.cpp
View File

@ -140,15 +140,17 @@ bool NzHardwareBuffer::Fill(const void* data, unsigned int offset, unsigned int
if (previous != m_buffer) if (previous != m_buffer)
glBindBuffer(bufferTarget[m_type], m_buffer); glBindBuffer(bufferTarget[m_type], m_buffer);
// Il semblerait que glBufferSubData soit plus performant que glMapBuffer(Range) en dessous d'un certain seuil // Il semblerait que glBuffer(Sub)Data soit plus performant que glMapBuffer(Range) en dessous d'un certain seuil
/*if (size < 32*1024) // http://www.stevestreeting.com/2007/03/17/glmapbuffer-vs-glbuffersubdata-the-return/
if (size < 32*1024)
{ {
if (size == m_parent->GetLength()) // http://www.opengl.org/wiki/Vertex_Specification_Best_Practices
glBufferData(bufferTarget[m_type], m_parent->GetSize(), data, bufferUsage[m_parent->GetStorage()]); if (size == m_parent->GetLength()) // Discard
else glBufferData(bufferTarget[m_type], m_parent->GetSize(), nullptr, bufferUsage[m_parent->GetStorage()]);
glBufferSubData(bufferTarget[m_type], offset, size, data);
glBufferSubData(bufferTarget[m_type], offset, size, data);
} }
else*/ else
{ {
nzUInt8* ptr = lockBuffer(m_type, (size == m_parent->GetSize()) ? nzBufferLock_DiscardAndWrite : nzBufferLock_WriteOnly, offset, size); nzUInt8* ptr = lockBuffer(m_type, (size == m_parent->GetSize()) ? nzBufferLock_DiscardAndWrite : nzBufferLock_WriteOnly, offset, size);
if (!ptr) if (!ptr)