From 754a3d3614fecdf1a3f80a7b55b2179c3c622baa Mon Sep 17 00:00:00 2001 From: SirLynix Date: Sat, 23 Dec 2023 14:36:04 +0100 Subject: [PATCH] Update unit tests for angle normalization change introduced in 6dc27e7948c12c44cd05d23fffba6c12f2565a65 --- .../UnitTests/Engine/Math/AlgorithmMathTest.cpp | 16 ++++++++-------- tests/UnitTests/Engine/Math/AngleTest.cpp | 7 +++++-- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/tests/UnitTests/Engine/Math/AlgorithmMathTest.cpp b/tests/UnitTests/Engine/Math/AlgorithmMathTest.cpp index 399095155..8cb360ae6 100644 --- a/tests/UnitTests/Engine/Math/AlgorithmMathTest.cpp +++ b/tests/UnitTests/Engine/Math/AlgorithmMathTest.cpp @@ -150,14 +150,14 @@ TEST_CASE("MultiplyAdd", "[MATH][ALGORITHM]") TEST_CASE("NormalizeAngle", "[MATH][ALGORITHM]") { - SECTION("-90 should be normalized to +270") + SECTION("270 should be normalized to -90") { - REQUIRE(Nz::DegreeAnglef(-90.f).Normalize() == Nz::DegreeAnglef(270.f)); + REQUIRE(Nz::DegreeAnglef(270.f).Normalize() == Nz::DegreeAnglef(-90.f)); } - SECTION("-540 should be normalized to +180") + SECTION("-540 should be normalized to -180") { - REQUIRE(Nz::DegreeAnglef(-540.f).Normalize() == Nz::DegreeAnglef(180.f)); + REQUIRE(Nz::DegreeAnglef(-540.f).Normalize() == Nz::DegreeAnglef(-180.f)); } SECTION("0 should remain 0") @@ -180,14 +180,14 @@ TEST_CASE("NormalizeAngle", "[MATH][ALGORITHM]") REQUIRE(Nz::DegreeAnglef(450.f).Normalize() == Nz::DegreeAnglef(90.f)); } - SECTION("-90 should be normalized to +270") + SECTION("-270 should be normalized to +90") { - REQUIRE(Nz::DegreeAnglef(-90).Normalize() == Nz::DegreeAnglef(270)); + REQUIRE(Nz::DegreeAnglef(-270).Normalize() == Nz::DegreeAnglef(90)); } - SECTION("-540 should be normalized to +180") + SECTION("-540 should be normalized to -180") { - REQUIRE(Nz::DegreeAnglef(-540).Normalize() == Nz::DegreeAnglef(180)); + REQUIRE(Nz::DegreeAnglef(-540).Normalize() == Nz::DegreeAnglef(-180)); } SECTION("0 should remain 0") diff --git a/tests/UnitTests/Engine/Math/AngleTest.cpp b/tests/UnitTests/Engine/Math/AngleTest.cpp index 8ced83347..e8f92c0ea 100644 --- a/tests/UnitTests/Engine/Math/AngleTest.cpp +++ b/tests/UnitTests/Engine/Math/AngleTest.cpp @@ -194,8 +194,9 @@ SCENARIO("Angle", "[MATH][ANGLE]") THEN("It should be equal to a normalized version of itself") { - Nz::RadianAnglef expectedResult(Nz::Pi); + Nz::RadianAnglef expectedResult(-Nz::Pi); + INFO(angle); CHECK(angle.ApproxEqual(expectedResult)); } } @@ -213,6 +214,7 @@ SCENARIO("Angle", "[MATH][ANGLE]") { Nz::RadianAnglef expectedResult(0.f); + INFO(angle); CHECK(angle.ApproxEqual(expectedResult)); } } @@ -228,8 +230,9 @@ SCENARIO("Angle", "[MATH][ANGLE]") THEN("It should be equal to a normalized version of itself") { - Nz::TurnAnglef expectedResult(0.5f); + Nz::TurnAnglef expectedResult(-0.5f); + INFO(angle); CHECK(angle.ApproxEqual(expectedResult)); } }