sid/NazaraEngine
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimize out a lot of std::string construction and allocations (#415)

Browse Source 
Update CommandLineParameters.hpp

Update CommandLineParametersTests.cpp

Update WebContext.hpp

xmake check-files -f

Fix MaterialPassRegistry
This commit is contained in:
Jérôme Leclercq
2023-12-30 14:50:57 +01:00
committed by GitHub
parent f7c9060364
commit 79ec135af7
57 changed files with 219 additions and 210 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
include/Nazara/Utility/Formats/MTLParser.inl
View File

@@ -7,9 +7,9 @@
namespace Nz
{
inline MTLParser::Material* MTLParser::AddMaterial(const std::string& matName)
inline MTLParser::Material* MTLParser::AddMaterial(std::string matName)
{
return &m_materials[matName];
return &m_materials[std::move(matName)];
}
inline void MTLParser::Clear()
@@ -17,7 +17,7 @@ namespace Nz
m_materials.clear();
}
inline const MTLParser::Material* MTLParser::GetMaterial(const std::string& materialName) const
inline const MTLParser::Material* MTLParser::GetMaterial(std::string_view materialName) const
{
auto it = m_materials.find(materialName);
if (it != m_materials.end())
@@ -26,7 +26,7 @@ namespace Nz
return nullptr;
}
inline const std::unordered_map<std::string, MTLParser::Material>& MTLParser::GetMaterials() const
inline auto MTLParser::GetMaterials() const -> const std::unordered_map<std::string, Material, StringHash<>, std::equal_to<>>&
{
return m_materials;
}
@@ -51,7 +51,7 @@ namespace Nz
Emit('\n');
}
inline void MTLParser::Error(const std::string& message)
inline void MTLParser::Error(std::string_view message)
{
NazaraErrorFmt("{0} at line #{1}", message, m_lineCount);
}
@@ -62,7 +62,7 @@ namespace Nz
m_outputStream.str({});
}
inline void MTLParser::Warning(const std::string& message)
inline void MTLParser::Warning(std::string_view message)
{
NazaraWarningFmt("{0} at line #{1}", message, m_lineCount);
}