sid/NazaraEngine
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Math: Replace M_PI defines with template constexpr constants

Browse Source
This commit is contained in:
Jérôme Leclercq
2021-06-05 16:35:15 +02:00
parent df8b4b59e3
commit bd1f5214b8
9 changed files with 27 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/Engine/Math/AlgorithmMathTest.cpp
View File

@@ -61,7 +61,7 @@ TEST_CASE("DegreeToRadian", "[MATH][ALGORITHM]")
{
SECTION("Convert 45.f degree to radian")
{
REQUIRE(Nz::DegreeToRadian(45.f) == Approx(M_PI / 4));
REQUIRE(Nz::DegreeToRadian(45.f) == Approx(Nz::Pi<float> / 4.f));
}
}
@@ -323,7 +323,7 @@ TEST_CASE("RadianToDegree", "[MATH][ALGORITHM]")
{
SECTION("PI / 4 to degree")
{
REQUIRE(Nz::RadianToDegree(M_PI / 4) == Approx(45.f));
REQUIRE(Nz::RadianToDegree(Nz::Pi<float> / 4.f) == Approx(45.f));
}
}

12
tests/Engine/Math/AngleTest.cpp
View File

@@ -25,7 +25,7 @@ SCENARIO("Angle", "[MATH][ANGLE]")
THEN("It should be equal to pi/2")
{
Nz::RadianAnglef expectedResult(float(M_PI_2));
Nz::RadianAnglef expectedResult(Nz::HalfPi<float>);
CHECK(radAngle == expectedResult);
CHECK(angle.ToRadianAngle() == expectedResult);
@@ -104,9 +104,9 @@ SCENARIO("Angle", "[MATH][ANGLE]")
}
}
GIVEN("A radian angle of -M_PI")
GIVEN("A radian angle of -Pi")
{
Nz::RadianAnglef angle(float(-M_PI));
Nz::RadianAnglef angle(-Nz::Pi<float>);
WHEN("We convert it to radians")
{
@@ -172,7 +172,7 @@ SCENARIO("Angle", "[MATH][ANGLE]")
GIVEN("A radian angle of 7pi")
{
Nz::RadianAnglef angle(float(7 * M_PI));
Nz::RadianAnglef angle(7.f * Nz::Pi<float>);
WHEN("We normalize it")
{
@@ -180,7 +180,7 @@ SCENARIO("Angle", "[MATH][ANGLE]")
THEN("It should be equal to a normalized version of itself")
{
Nz::RadianAnglef expectedResult(float(M_PI));
Nz::RadianAnglef expectedResult(Nz::Pi<float>);
CHECK(angle == expectedResult);
}
@@ -189,7 +189,7 @@ SCENARIO("Angle", "[MATH][ANGLE]")
GIVEN("A radian angle of -4pi")
{
Nz::RadianAnglef angle(float(-4 * M_PI));
Nz::RadianAnglef angle(-4.f * Nz::Pi<float>);
WHEN("We normalize it")
{