From bd53245f4274e2f4917add8a0b809fc473d24e05 Mon Sep 17 00:00:00 2001 From: SirLynix Date: Thu, 24 Aug 2023 08:23:14 +0200 Subject: [PATCH] Core/StringExt: Don't pass string_view by ref https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/ --- include/Nazara/Core/Algorithm.hpp | 2 +- include/Nazara/Core/Algorithm.inl | 2 +- include/Nazara/Core/Log.hpp | 4 +- include/Nazara/Core/ResourceLoader.hpp | 2 +- include/Nazara/Core/ResourceLoader.inl | 2 +- include/Nazara/Core/ResourceSaver.hpp | 4 +- include/Nazara/Core/ResourceSaver.inl | 2 +- include/Nazara/Core/StringExt.hpp | 62 +++++++++---------- include/Nazara/Core/StringExt.inl | 16 ++--- .../OpenGLRenderer/OpenGLCommandBuffer.hpp | 2 +- .../OpenGLRenderer/OpenGLCommandBuffer.inl | 2 +- .../OpenGLCommandBufferBuilder.hpp | 2 +- .../Nazara/OpenGLRenderer/Wrapper/Context.hpp | 2 +- .../OpenGLRenderer/Wrapper/ContextObject.hpp | 2 +- .../OpenGLRenderer/Wrapper/ContextObject.inl | 2 +- .../OpenGLRenderer/Wrapper/DeviceObject.hpp | 2 +- .../OpenGLRenderer/Wrapper/DeviceObject.inl | 2 +- .../Wrapper/EGL/EGLContextBase.hpp | 2 +- .../OpenGLRenderer/Wrapper/EGL/EGLLoader.hpp | 2 +- .../Nazara/OpenGLRenderer/Wrapper/Shader.hpp | 2 +- .../Nazara/OpenGLRenderer/Wrapper/Shader.inl | 2 +- .../OpenGLRenderer/Wrapper/WGL/WGLContext.hpp | 2 +- .../OpenGLRenderer/Wrapper/Web/WebContext.hpp | 2 +- .../OpenGLRenderer/Wrapper/Web/WebLoader.hpp | 2 +- .../Nazara/Renderer/CommandBufferBuilder.hpp | 2 +- include/Nazara/Utility/SimpleTextDrawer.hpp | 4 +- include/Nazara/Utility/SimpleTextDrawer.inl | 2 +- .../VulkanCommandBufferBuilder.hpp | 2 +- src/Nazara/Audio/Formats/drwavLoader.cpp | 2 +- src/Nazara/Audio/Formats/libflacLoader.cpp | 2 +- src/Nazara/Audio/Formats/minimp3Loader.cpp | 2 +- src/Nazara/Core/StringExt.cpp | 50 +++++++-------- .../OpenGLCommandBufferBuilder.cpp | 2 +- .../OpenGLRenderer/OpenGLShaderModule.cpp | 2 +- src/Nazara/OpenGLRenderer/Wrapper/Context.cpp | 2 +- .../Wrapper/EGL/EGLContextBase.cpp | 2 +- .../OpenGLRenderer/Wrapper/EGL/EGLLoader.cpp | 2 +- .../OpenGLRenderer/Wrapper/WGL/WGLContext.cpp | 2 +- src/Nazara/Utility/Formats/DDSLoader.cpp | 2 +- src/Nazara/Utility/Formats/FreeTypeLoader.cpp | 2 +- src/Nazara/Utility/Formats/GIFLoader.cpp | 2 +- src/Nazara/Utility/Formats/MD2Loader.cpp | 2 +- src/Nazara/Utility/Formats/MD5AnimLoader.cpp | 2 +- src/Nazara/Utility/Formats/MD5MeshLoader.cpp | 2 +- src/Nazara/Utility/Formats/OBJLoader.cpp | 2 +- src/Nazara/Utility/Formats/OBJSaver.cpp | 2 +- src/Nazara/Utility/Formats/PCXLoader.cpp | 2 +- src/Nazara/Utility/Formats/STBLoader.cpp | 2 +- src/Nazara/Utility/Formats/STBSaver.cpp | 2 +- src/Nazara/Utility/SimpleTextDrawer.cpp | 2 +- .../VulkanCommandBufferBuilder.cpp | 2 +- 51 files changed, 115 insertions(+), 115 deletions(-) diff --git a/include/Nazara/Core/Algorithm.hpp b/include/Nazara/Core/Algorithm.hpp index 74809f6d8..dadd82d91 100644 --- a/include/Nazara/Core/Algorithm.hpp +++ b/include/Nazara/Core/Algorithm.hpp @@ -26,7 +26,7 @@ namespace Nz template ByteArray ComputeHash(HashType hash, T&& v); template ByteArray ComputeHash(AbstractHash& hash, T&& v); - inline bool HashAppend(AbstractHash* hash, const std::string_view& v); + inline bool HashAppend(AbstractHash* hash, std::string_view v); template bool Serialize(SerializationContext& context, T&& value); diff --git a/include/Nazara/Core/Algorithm.inl b/include/Nazara/Core/Algorithm.inl index c546bf5b4..1f62713c4 100644 --- a/include/Nazara/Core/Algorithm.inl +++ b/include/Nazara/Core/Algorithm.inl @@ -57,7 +57,7 @@ namespace Nz return hash.End(); } - inline bool HashAppend(AbstractHash& hash, const std::string_view& v) + inline bool HashAppend(AbstractHash& hash, std::string_view v) { hash.Append(reinterpret_cast(v.data()), v.size()); return true; diff --git a/include/Nazara/Core/Log.hpp b/include/Nazara/Core/Log.hpp index 8c009eb9d..66423c32e 100644 --- a/include/Nazara/Core/Log.hpp +++ b/include/Nazara/Core/Log.hpp @@ -43,8 +43,8 @@ namespace Nz template static void Write(std::string_view str, Args&&... args); static void WriteError(ErrorType type, std::string_view error, unsigned int line = 0, const char* file = nullptr, const char* function = nullptr); - NazaraStaticSignal(OnLogWrite, const std::string_view& /*string*/); - NazaraStaticSignal(OnLogWriteError, ErrorType /*type*/, const std::string_view& /*error*/, unsigned int /*line*/, const char* /*file*/, const char* /*function*/); + NazaraStaticSignal(OnLogWrite, std::string_view /*string*/); + NazaraStaticSignal(OnLogWriteError, ErrorType /*type*/, std::string_view /*error*/, unsigned int /*line*/, const char* /*file*/, const char* /*function*/); private: static bool Initialize(); diff --git a/include/Nazara/Core/ResourceLoader.hpp b/include/Nazara/Core/ResourceLoader.hpp index 19e48a796..03f2e5c78 100644 --- a/include/Nazara/Core/ResourceLoader.hpp +++ b/include/Nazara/Core/ResourceLoader.hpp @@ -43,7 +43,7 @@ namespace Nz void Clear(); - bool IsExtensionSupported(const std::string_view& extension) const; + bool IsExtensionSupported(std::string_view extension) const; std::shared_ptr LoadFromFile(const std::filesystem::path& filePath, const Parameters& parameters = Parameters()) const; std::shared_ptr LoadFromMemory(const void* data, std::size_t size, const Parameters& parameters = Parameters()) const; diff --git a/include/Nazara/Core/ResourceLoader.inl b/include/Nazara/Core/ResourceLoader.inl index 7ed86aa47..b002a071e 100644 --- a/include/Nazara/Core/ResourceLoader.inl +++ b/include/Nazara/Core/ResourceLoader.inl @@ -34,7 +34,7 @@ namespace Nz * \param extension Extension of the file (ex: ".png") */ template - bool ResourceLoader::IsExtensionSupported(const std::string_view& extension) const + bool ResourceLoader::IsExtensionSupported(std::string_view extension) const { NazaraAssert(extension.size() >= 2 || extension.front() != '.', "extension should start with a ."); diff --git a/include/Nazara/Core/ResourceSaver.hpp b/include/Nazara/Core/ResourceSaver.hpp index 4c84f5f72..abc912827 100644 --- a/include/Nazara/Core/ResourceSaver.hpp +++ b/include/Nazara/Core/ResourceSaver.hpp @@ -29,7 +29,7 @@ namespace Nz public: struct Entry; - using FormatSupport = std::function; + using FormatSupport = std::function; using FileSaver = std::function; using StreamSaver = std::function; @@ -40,7 +40,7 @@ namespace Nz void Clear(); - bool IsExtensionSupported(const std::string_view& extension) const; + bool IsExtensionSupported(std::string_view extension) const; bool SaveToFile(const Type& resource, const std::filesystem::path& filePath, const Parameters& parameters = Parameters()) const; bool SaveToStream(const Type& resource, Stream& stream, const std::string& format, const Parameters& parameters = Parameters()) const; diff --git a/include/Nazara/Core/ResourceSaver.inl b/include/Nazara/Core/ResourceSaver.inl index 629383aee..5466bd616 100644 --- a/include/Nazara/Core/ResourceSaver.inl +++ b/include/Nazara/Core/ResourceSaver.inl @@ -34,7 +34,7 @@ namespace Nz * \param extension Extension of the file */ template - bool ResourceSaver::IsExtensionSupported(const std::string_view& extension) const + bool ResourceSaver::IsExtensionSupported(std::string_view extension) const { NazaraAssert(extension.size() >= 2 || extension.front() != '.', "extension should start with a ."); diff --git a/include/Nazara/Core/StringExt.hpp b/include/Nazara/Core/StringExt.hpp index ae167ad7e..3e8473306 100644 --- a/include/Nazara/Core/StringExt.hpp +++ b/include/Nazara/Core/StringExt.hpp @@ -18,55 +18,55 @@ namespace Nz struct UnicodeAware {}; // std::string is assumed to contains UTF-8 - NAZARA_CORE_API std::size_t ComputeCharacterCount(const std::string_view& str); + NAZARA_CORE_API std::size_t ComputeCharacterCount(std::string_view str); - inline bool EndsWith(const std::string_view& str, const std::string_view& s); - NAZARA_CORE_API bool EndsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent); - NAZARA_CORE_API bool EndsWith(const std::string_view& lhs, const std::string_view& rhs, UnicodeAware); - NAZARA_CORE_API bool EndsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent, UnicodeAware); + inline bool EndsWith(std::string_view str, std::string_view s); + NAZARA_CORE_API bool EndsWith(std::string_view lhs, std::string_view rhs, CaseIndependent); + NAZARA_CORE_API bool EndsWith(std::string_view lhs, std::string_view rhs, UnicodeAware); + NAZARA_CORE_API bool EndsWith(std::string_view lhs, std::string_view rhs, CaseIndependent, UnicodeAware); - NAZARA_CORE_API std::string FromUtf16String(const std::u16string_view& u16str); - NAZARA_CORE_API std::string FromUtf32String(const std::u32string_view& u32str); - NAZARA_CORE_API std::string FromWideString(const std::wstring_view& str); + NAZARA_CORE_API std::string FromUtf16String(std::u16string_view u16str); + NAZARA_CORE_API std::string FromUtf32String(std::u32string_view u32str); + NAZARA_CORE_API std::string FromWideString(std::wstring_view str); - NAZARA_CORE_API std::size_t GetCharacterPosition(const std::string_view& str, std::size_t characterIndex); - NAZARA_CORE_API std::string_view GetWord(const std::string_view& str, std::size_t wordIndex); - NAZARA_CORE_API std::string_view GetWord(const std::string_view& str, std::size_t wordIndex, UnicodeAware); + NAZARA_CORE_API std::size_t GetCharacterPosition(std::string_view str, std::size_t characterIndex); + NAZARA_CORE_API std::string_view GetWord(std::string_view str, std::size_t wordIndex); + NAZARA_CORE_API std::string_view GetWord(std::string_view str, std::size_t wordIndex, UnicodeAware); inline bool IsNumber(std::string_view str); - NAZARA_CORE_API bool MatchPattern(const std::string_view& str, const std::string_view& pattern); + NAZARA_CORE_API bool MatchPattern(std::string_view str, std::string_view pattern); inline std::string NumberToString(long long number, UInt8 radix = 10); NAZARA_CORE_API std::string PointerToString(const void* ptr); - inline std::string& ReplaceStr(std::string& str, const std::string_view& from, const std::string_view& to); + inline std::string& ReplaceStr(std::string& str, std::string_view from, std::string_view to); - inline bool StartsWith(const std::string_view& str, const std::string_view& s); - NAZARA_CORE_API bool StartsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent); - NAZARA_CORE_API bool StartsWith(const std::string_view& lhs, const std::string_view& rhs, UnicodeAware); - NAZARA_CORE_API bool StartsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent, UnicodeAware); + inline bool StartsWith(std::string_view str, std::string_view s); + NAZARA_CORE_API bool StartsWith(std::string_view lhs, std::string_view rhs, CaseIndependent); + NAZARA_CORE_API bool StartsWith(std::string_view lhs, std::string_view rhs, UnicodeAware); + NAZARA_CORE_API bool StartsWith(std::string_view lhs, std::string_view rhs, CaseIndependent, UnicodeAware); - template bool SplitString(const std::string_view& str, const std::string_view& token, F&& func); - template bool SplitStringAny(const std::string_view& str, const std::string_view& token, F&& func); + template bool SplitString(std::string_view str, std::string_view token, F&& func); + template bool SplitStringAny(std::string_view str, std::string_view token, F&& func); - inline bool StringEqual(const std::string_view& lhs, const std::string_view& rhs); - inline bool StringEqual(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent); - NAZARA_CORE_API bool StringEqual(const std::string_view& lhs, const std::string_view& rhs, UnicodeAware); - NAZARA_CORE_API bool StringEqual(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent, UnicodeAware); + inline bool StringEqual(std::string_view lhs, std::string_view rhs); + inline bool StringEqual(std::string_view lhs, std::string_view rhs, CaseIndependent); + NAZARA_CORE_API bool StringEqual(std::string_view lhs, std::string_view rhs, UnicodeAware); + NAZARA_CORE_API bool StringEqual(std::string_view lhs, std::string_view rhs, CaseIndependent, UnicodeAware); - inline long long StringToNumber(const std::string_view& str, UInt8 radix = 10, bool* ok = nullptr); + inline long long StringToNumber(std::string_view str, UInt8 radix = 10, bool* ok = nullptr); - NAZARA_CORE_API std::string ToLower(const std::string_view& str); - NAZARA_CORE_API std::string ToLower(const std::string_view& str, UnicodeAware); + NAZARA_CORE_API std::string ToLower(std::string_view str); + NAZARA_CORE_API std::string ToLower(std::string_view str, UnicodeAware); - NAZARA_CORE_API std::string ToUpper(const std::string_view& str); - NAZARA_CORE_API std::string ToUpper(const std::string_view& str, UnicodeAware); + NAZARA_CORE_API std::string ToUpper(std::string_view str); + NAZARA_CORE_API std::string ToUpper(std::string_view str, UnicodeAware); - NAZARA_CORE_API std::u16string ToUtf16String(const std::string_view& str); - NAZARA_CORE_API std::u32string ToUtf32String(const std::string_view& str); - NAZARA_CORE_API std::wstring ToWideString(const std::string_view& str); + NAZARA_CORE_API std::u16string ToUtf16String(std::string_view str); + NAZARA_CORE_API std::u32string ToUtf32String(std::string_view str); + NAZARA_CORE_API std::wstring ToWideString(std::string_view str); inline std::string_view Trim(std::string_view str); inline std::string_view Trim(std::string_view str, char c); diff --git a/include/Nazara/Core/StringExt.inl b/include/Nazara/Core/StringExt.inl index dab1f668f..89cc89307 100644 --- a/include/Nazara/Core/StringExt.inl +++ b/include/Nazara/Core/StringExt.inl @@ -10,7 +10,7 @@ namespace Nz { - inline bool EndsWith(const std::string_view& str, const std::string_view& s) + inline bool EndsWith(std::string_view str, std::string_view s) { #if NAZARA_CPP_VER >= NAZARA_CPP20 // C++20 @@ -77,7 +77,7 @@ namespace Nz return str; } - inline std::string& ReplaceStr(std::string& str, const std::string_view& from, const std::string_view& to) + inline std::string& ReplaceStr(std::string& str, std::string_view from, std::string_view to) { if (str.empty()) return str; @@ -92,7 +92,7 @@ namespace Nz return str; } - inline bool StartsWith(const std::string_view& str, const std::string_view& s) + inline bool StartsWith(std::string_view str, std::string_view s) { #if NAZARA_CPP_VER >= NAZARA_CPP20 // C++20 @@ -103,7 +103,7 @@ namespace Nz } template - bool SplitString(const std::string_view& str, const std::string_view& token, F&& func) + bool SplitString(std::string_view str, std::string_view token, F&& func) { std::size_t pos = 0; std::size_t previousPos = 0; @@ -123,7 +123,7 @@ namespace Nz } template - bool SplitStringAny(const std::string_view& str, const std::string_view& token, F&& func) + bool SplitStringAny(std::string_view str, std::string_view token, F&& func) { std::size_t pos = 0; std::size_t previousPos = 0; @@ -139,12 +139,12 @@ namespace Nz return func(str.substr(previousPos)); } - inline bool StringEqual(const std::string_view& lhs, const std::string_view& rhs) + inline bool StringEqual(std::string_view lhs, std::string_view rhs) { return lhs == rhs; } - inline bool StringEqual(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent) + inline bool StringEqual(std::string_view lhs, std::string_view rhs, CaseIndependent) { if (lhs.size() != rhs.size()) return false; @@ -170,7 +170,7 @@ namespace Nz * \remark radix is meant to be between 2 and 36, other values are potentially undefined behavior * \remark With NAZARA_MATH_SAFE, a NazaraError is produced and 0 is returned */ - inline long long StringToNumber(const std::string_view& str, UInt8 radix, bool* ok) + inline long long StringToNumber(std::string_view str, UInt8 radix, bool* ok) { NazaraAssert(radix >= 2 && radix <= 36, "base must be between 2 and 36"); diff --git a/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.hpp b/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.hpp index a92be58f6..fb45ad7d8 100644 --- a/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.hpp +++ b/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.hpp @@ -38,7 +38,7 @@ namespace Nz OpenGLCommandBuffer(OpenGLCommandBuffer&&) = delete; ~OpenGLCommandBuffer() = default; - inline void BeginDebugRegion(const std::string_view& regionName, const Color& color); + inline void BeginDebugRegion(std::string_view regionName, const Color& color); inline void BindComputePipeline(const OpenGLComputePipeline* pipeline); inline void BindComputeShaderBinding(const OpenGLRenderPipelineLayout& pipelineLayout, UInt32 set, const OpenGLShaderBinding* binding); diff --git a/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.inl b/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.inl index 8459506e5..599ecd692 100644 --- a/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.inl +++ b/include/Nazara/OpenGLRenderer/OpenGLCommandBuffer.inl @@ -23,7 +23,7 @@ namespace Nz { } - inline void OpenGLCommandBuffer::BeginDebugRegion(const std::string_view& regionName, const Color& color) + inline void OpenGLCommandBuffer::BeginDebugRegion(std::string_view regionName, const Color& color) { BeginDebugRegionCommand beginDebugRegion; beginDebugRegion.color = color; diff --git a/include/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.hpp b/include/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.hpp index 3e12962d4..f8f09355b 100644 --- a/include/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.hpp +++ b/include/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.hpp @@ -24,7 +24,7 @@ namespace Nz OpenGLCommandBufferBuilder(OpenGLCommandBufferBuilder&&) noexcept = default; ~OpenGLCommandBufferBuilder() = default; - void BeginDebugRegion(const std::string_view& regionName, const Color& color) override; + void BeginDebugRegion(std::string_view regionName, const Color& color) override; void BeginRenderPass(const Framebuffer& framebuffer, const RenderPass& renderPass, const Recti& renderRect, const ClearValues* clearValues, std::size_t clearValueCount) override; void BindComputePipeline(const ComputePipeline& pipeline) override; diff --git a/include/Nazara/OpenGLRenderer/Wrapper/Context.hpp b/include/Nazara/OpenGLRenderer/Wrapper/Context.hpp index f6a74f520..be77ff4a2 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/Context.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/Context.hpp @@ -208,7 +208,7 @@ namespace Nz::GL virtual const Loader& GetLoader() = 0; void OnContextRelease(); - virtual bool ImplementFallback(const std::string_view& function); + virtual bool ImplementFallback(std::string_view function); static void NotifyContextDestruction(Context* context); diff --git a/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.hpp b/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.hpp index c41c97f5b..ebdc1a483 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.hpp @@ -34,7 +34,7 @@ namespace Nz::GL const Context* GetContext() const; GLuint GetObjectId() const; - void SetDebugName(const std::string_view& name); + void SetDebugName(std::string_view name); ContextObject& operator=(const ContextObject&) = delete; ContextObject& operator=(ContextObject&& object) noexcept = default; diff --git a/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.inl b/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.inl index 42fcf28db..5712d349e 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.inl +++ b/include/Nazara/OpenGLRenderer/Wrapper/ContextObject.inl @@ -85,7 +85,7 @@ namespace Nz::GL } template - void ContextObject::SetDebugName(const std::string_view& name) + void ContextObject::SetDebugName(std::string_view name) { EnsureContext(); diff --git a/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.hpp b/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.hpp index 80356df1f..0b862f7fa 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.hpp @@ -35,7 +35,7 @@ namespace Nz::GL OpenGLDevice* GetDevice() const; GLuint GetObjectId() const; - void SetDebugName(const std::string_view& name); + void SetDebugName(std::string_view name); DeviceObject& operator=(const DeviceObject&) = delete; DeviceObject& operator=(DeviceObject&& object) noexcept = default; diff --git a/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.inl b/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.inl index c7281354b..4f78ea9d3 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.inl +++ b/include/Nazara/OpenGLRenderer/Wrapper/DeviceObject.inl @@ -91,7 +91,7 @@ namespace Nz::GL } template - void DeviceObject::SetDebugName(const std::string_view& name) + void DeviceObject::SetDebugName(std::string_view name) { const Context& context = EnsureDeviceContext(); diff --git a/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.hpp b/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.hpp index 54dd7a45a..58745eae8 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.hpp @@ -57,7 +57,7 @@ namespace Nz::GL EGLSurface m_surface; private: - bool ImplementFallback(const std::string_view& function) override; + bool ImplementFallback(std::string_view function) override; bool Activate() const override; void Desactivate() const override; diff --git a/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.hpp b/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.hpp index 33c12749f..b14caf4f6 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.hpp @@ -41,7 +41,7 @@ namespace Nz::GL static const char* TranslateError(EGLint errorId); private: - bool ImplementFallback(const std::string_view& function); + bool ImplementFallback(std::string_view function); ContextType m_preferredContextType; EGLDisplay m_defaultDisplay; diff --git a/include/Nazara/OpenGLRenderer/Wrapper/Shader.hpp b/include/Nazara/OpenGLRenderer/Wrapper/Shader.hpp index 9713ed4d3..6e1a9667a 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/Shader.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/Shader.hpp @@ -31,7 +31,7 @@ namespace Nz::GL inline void SetBinarySource(GLenum binaryFormat, const void* binary, GLsizei length); inline void SetSource(const char* source, GLint length); - inline void SetSource(const std::string_view& source); + inline void SetSource(std::string_view source); // GL_ARB_gl_spirv inline void SpecializeShader(const GLchar* pEntryPoint, GLuint numSpecializationConstants, const GLuint* pConstantIndex, const GLuint* pConstantValue); diff --git a/include/Nazara/OpenGLRenderer/Wrapper/Shader.inl b/include/Nazara/OpenGLRenderer/Wrapper/Shader.inl index 68b054324..871557a5c 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/Shader.inl +++ b/include/Nazara/OpenGLRenderer/Wrapper/Shader.inl @@ -80,7 +80,7 @@ namespace Nz::GL m_device->GetReferenceContext().glShaderSource(m_objectId, 1U, &source, &length); } - inline void Shader::SetSource(const std::string_view& source) + inline void Shader::SetSource(std::string_view source) { return SetSource(source.data(), GLint(source.size())); } diff --git a/include/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.hpp b/include/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.hpp index 31b825402..c0f970fae 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.hpp @@ -47,7 +47,7 @@ namespace Nz::GL private: bool CreateInternal(const WGLContext* baseContext, const ContextParams& params, const WGLContext* shareContext = nullptr); - bool ImplementFallback(const std::string_view& function) override; + bool ImplementFallback(std::string_view function) override; bool Activate() const override; void Desactivate() const override; diff --git a/include/Nazara/OpenGLRenderer/Wrapper/Web/WebContext.hpp b/include/Nazara/OpenGLRenderer/Wrapper/Web/WebContext.hpp index 9d4ace249..df9b236c9 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/Web/WebContext.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/Web/WebContext.hpp @@ -51,7 +51,7 @@ namespace Nz::GL const WebLoader& m_loader; private: - bool ImplementFallback(const std::string_view& function) override; + bool ImplementFallback(std::string_view function) override; bool Activate() const override; void Desactivate() const override; diff --git a/include/Nazara/OpenGLRenderer/Wrapper/Web/WebLoader.hpp b/include/Nazara/OpenGLRenderer/Wrapper/Web/WebLoader.hpp index 9b9d4d70f..7609ffcb7 100644 --- a/include/Nazara/OpenGLRenderer/Wrapper/Web/WebLoader.hpp +++ b/include/Nazara/OpenGLRenderer/Wrapper/Web/WebLoader.hpp @@ -31,7 +31,7 @@ namespace Nz::GL static const char* TranslateError(EMSCRIPTEN_RESULT errorId); private: - bool ImplementFallback(const std::string_view& function); + bool ImplementFallback(std::string_view function); }; } diff --git a/include/Nazara/Renderer/CommandBufferBuilder.hpp b/include/Nazara/Renderer/CommandBufferBuilder.hpp index 2ac4032d8..6c3086011 100644 --- a/include/Nazara/Renderer/CommandBufferBuilder.hpp +++ b/include/Nazara/Renderer/CommandBufferBuilder.hpp @@ -38,7 +38,7 @@ namespace Nz CommandBufferBuilder(CommandBufferBuilder&&) = default; virtual ~CommandBufferBuilder(); - virtual void BeginDebugRegion(const std::string_view& regionName, const Color& color) = 0; + virtual void BeginDebugRegion(std::string_view regionName, const Color& color) = 0; virtual void BeginRenderPass(const Framebuffer& framebuffer, const RenderPass& renderPass, const Recti& renderRect, const ClearValues* clearValues, std::size_t clearValueCount) = 0; inline void BeginRenderPass(const Framebuffer& framebuffer, const RenderPass& renderPass, const Recti& renderRect); inline void BeginRenderPass(const Framebuffer& framebuffer, const RenderPass& renderPass, const Recti& renderRect, std::initializer_list clearValues); diff --git a/include/Nazara/Utility/SimpleTextDrawer.hpp b/include/Nazara/Utility/SimpleTextDrawer.hpp index fd7c9ce61..7501de127 100644 --- a/include/Nazara/Utility/SimpleTextDrawer.hpp +++ b/include/Nazara/Utility/SimpleTextDrawer.hpp @@ -23,7 +23,7 @@ namespace Nz inline SimpleTextDrawer(SimpleTextDrawer&& drawer) noexcept; ~SimpleTextDrawer() = default; - inline void AppendText(const std::string_view& str); + inline void AppendText(std::string_view str); void Clear() override; @@ -75,7 +75,7 @@ namespace Nz inline void DisconnectFontSlots(); bool GenerateGlyph(Glyph& glyph, char32_t character, float outlineThickness, bool lineWrap, Color color, int renderOrder, int* advance) const; - void GenerateGlyphs(const std::string_view& text) const; + void GenerateGlyphs(std::string_view text) const; inline float GetLineHeight(const Font::SizeInfo& sizeInfo) const; diff --git a/include/Nazara/Utility/SimpleTextDrawer.inl b/include/Nazara/Utility/SimpleTextDrawer.inl index f257dd8b6..79524c4c9 100644 --- a/include/Nazara/Utility/SimpleTextDrawer.inl +++ b/include/Nazara/Utility/SimpleTextDrawer.inl @@ -42,7 +42,7 @@ namespace Nz operator=(std::move(drawer)); } - inline void SimpleTextDrawer::AppendText(const std::string_view& str) + inline void SimpleTextDrawer::AppendText(std::string_view str) { m_text.append(str); if (m_glyphUpdated) diff --git a/include/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.hpp b/include/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.hpp index 346f4ec29..89b94124b 100644 --- a/include/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.hpp +++ b/include/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.hpp @@ -24,7 +24,7 @@ namespace Nz VulkanCommandBufferBuilder(VulkanCommandBufferBuilder&&) noexcept = default; ~VulkanCommandBufferBuilder() = default; - void BeginDebugRegion(const std::string_view& regionName, const Color& color) override; + void BeginDebugRegion(std::string_view regionName, const Color& color) override; void BeginRenderPass(const Framebuffer& framebuffer, const RenderPass& renderPass, const Recti& renderRect, const ClearValues* clearValues, std::size_t clearValueCount) override; void BindComputePipeline(const ComputePipeline& pipeline) override; diff --git a/src/Nazara/Audio/Formats/drwavLoader.cpp b/src/Nazara/Audio/Formats/drwavLoader.cpp index bf2e75a78..967128040 100644 --- a/src/Nazara/Audio/Formats/drwavLoader.cpp +++ b/src/Nazara/Audio/Formats/drwavLoader.cpp @@ -49,7 +49,7 @@ namespace Nz } } - bool IsWavSupported(const std::string_view& extension) + bool IsWavSupported(std::string_view extension) { return extension == ".riff" || extension == ".rf64" || extension == ".wav" || extension == ".w64"; } diff --git a/src/Nazara/Audio/Formats/libflacLoader.cpp b/src/Nazara/Audio/Formats/libflacLoader.cpp index 16079772b..174cd3673 100644 --- a/src/Nazara/Audio/Formats/libflacLoader.cpp +++ b/src/Nazara/Audio/Formats/libflacLoader.cpp @@ -136,7 +136,7 @@ namespace Nz return DecodeFlacFrameSamples(frame, buffer, samples, 0, frame->header.blocksize); } - bool IsFlacSupported(const std::string_view& extension) + bool IsFlacSupported(std::string_view extension) { return extension == ".flac"; } diff --git a/src/Nazara/Audio/Formats/minimp3Loader.cpp b/src/Nazara/Audio/Formats/minimp3Loader.cpp index eb01c3468..0466bf0e5 100644 --- a/src/Nazara/Audio/Formats/minimp3Loader.cpp +++ b/src/Nazara/Audio/Formats/minimp3Loader.cpp @@ -51,7 +51,7 @@ namespace Nz return (stream->SetCursorPos(position)) ? 0 : MP3D_E_IOERROR; } - bool IsMP3Supported(const std::string_view& extension) + bool IsMP3Supported(std::string_view extension) { return extension == ".mp3"; } diff --git a/src/Nazara/Core/StringExt.cpp b/src/Nazara/Core/StringExt.cpp index c397d6e4a..1b1c7bace 100644 --- a/src/Nazara/Core/StringExt.cpp +++ b/src/Nazara/Core/StringExt.cpp @@ -61,7 +61,7 @@ namespace Nz return FromUtf16String(std::u16string_view(reinterpret_cast(wstr), size)); } - static std::wstring To(const std::string_view& str) + static std::wstring To(std::string_view str) { std::wstring result; utf8::utf8to16(str.begin(), str.end(), std::back_inserter(result)); @@ -81,7 +81,7 @@ namespace Nz return FromUtf32String(std::u32string_view(reinterpret_cast(wstr), size)); } - static std::wstring To(const std::string_view& str) + static std::wstring To(std::string_view str) { std::wstring result; utf8::utf8to32(str.begin(), str.end(), std::back_inserter(result)); @@ -92,12 +92,12 @@ namespace Nz #endif } - std::size_t ComputeCharacterCount(const std::string_view& str) + std::size_t ComputeCharacterCount(std::string_view str) { return utf8::distance(str.data(), str.data() + str.size()); } - bool EndsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent) + bool EndsWith(std::string_view lhs, std::string_view rhs, CaseIndependent) { NAZARA_USE_ANONYMOUS_NAMESPACE @@ -110,7 +110,7 @@ namespace Nz }); } - bool EndsWith(const std::string_view& lhs, const std::string_view& rhs, UnicodeAware) + bool EndsWith(std::string_view lhs, std::string_view rhs, UnicodeAware) { if (lhs.empty()) return lhs == rhs; @@ -136,7 +136,7 @@ namespace Nz return true; } - bool EndsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent, UnicodeAware) + bool EndsWith(std::string_view lhs, std::string_view rhs, CaseIndependent, UnicodeAware) { if (lhs.empty()) return lhs == rhs; @@ -162,7 +162,7 @@ namespace Nz return true; } - std::string FromUtf16String(const std::u16string_view& u16str) + std::string FromUtf16String(std::u16string_view u16str) { std::string result; utf8::utf16to8(u16str.begin(), u16str.end(), std::back_inserter(result)); @@ -170,7 +170,7 @@ namespace Nz return result; } - std::string FromUtf32String(const std::u32string_view& u32str) + std::string FromUtf32String(std::u32string_view u32str) { std::string result; utf8::utf32to8(u32str.begin(), u32str.end(), std::back_inserter(result)); @@ -178,14 +178,14 @@ namespace Nz return result; } - std::string FromWideString(const std::wstring_view& wstr) + std::string FromWideString(std::wstring_view wstr) { NAZARA_USE_ANONYMOUS_NAMESPACE return WideConverter::From(wstr.data(), wstr.size()); } - std::size_t GetCharacterPosition(const std::string_view& str, std::size_t characterIndex) + std::size_t GetCharacterPosition(std::string_view str, std::size_t characterIndex) { const char* ptr = str.data(); const char* end = ptr + str.size(); @@ -212,7 +212,7 @@ namespace Nz return std::string::npos; } - std::string_view GetWord(const std::string_view& str, std::size_t wordIndex) + std::string_view GetWord(std::string_view str, std::size_t wordIndex) { std::size_t pos = 0; std::size_t previousPos = 0; @@ -228,7 +228,7 @@ namespace Nz return {}; } - std::string_view GetWord(const std::string_view& str, std::size_t wordIndex, UnicodeAware) + std::string_view GetWord(std::string_view str, std::size_t wordIndex, UnicodeAware) { NAZARA_USE_ANONYMOUS_NAMESPACE @@ -259,7 +259,7 @@ namespace Nz return {}; } - bool MatchPattern(const std::string_view& str, const std::string_view& pattern) + bool MatchPattern(std::string_view str, std::string_view pattern) { if (str.empty() || pattern.empty()) return false; @@ -321,7 +321,7 @@ namespace Nz return str; } - bool StartsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent) + bool StartsWith(std::string_view lhs, std::string_view rhs, CaseIndependent) { NAZARA_USE_ANONYMOUS_NAMESPACE @@ -334,7 +334,7 @@ namespace Nz }); } - bool StartsWith(const std::string_view& lhs, const std::string_view& rhs, UnicodeAware) + bool StartsWith(std::string_view lhs, std::string_view rhs, UnicodeAware) { if (lhs.empty()) return lhs == rhs; @@ -358,7 +358,7 @@ namespace Nz return true; } - bool StartsWith(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent, UnicodeAware) + bool StartsWith(std::string_view lhs, std::string_view rhs, CaseIndependent, UnicodeAware) { if (lhs.empty()) return lhs == rhs; @@ -382,7 +382,7 @@ namespace Nz return true; } - bool StringEqual(const std::string_view& lhs, const std::string_view& rhs, UnicodeAware) + bool StringEqual(std::string_view lhs, std::string_view rhs, UnicodeAware) { if (lhs.empty() || rhs.empty()) return lhs == rhs; @@ -399,7 +399,7 @@ namespace Nz return true; } - bool StringEqual(const std::string_view& lhs, const std::string_view& rhs, CaseIndependent, UnicodeAware) + bool StringEqual(std::string_view lhs, std::string_view rhs, CaseIndependent, UnicodeAware) { if (lhs.empty() || rhs.empty()) return lhs == rhs; @@ -416,7 +416,7 @@ namespace Nz return true; } - std::string ToLower(const std::string_view& str) + std::string ToLower(std::string_view str) { NAZARA_USE_ANONYMOUS_NAMESPACE @@ -427,7 +427,7 @@ namespace Nz return result; } - std::string ToLower(const std::string_view& str, UnicodeAware) + std::string ToLower(std::string_view str, UnicodeAware) { if (str.empty()) return std::string(); @@ -443,7 +443,7 @@ namespace Nz return result; } - std::string ToUpper(const std::string_view& str) + std::string ToUpper(std::string_view str) { NAZARA_USE_ANONYMOUS_NAMESPACE @@ -454,7 +454,7 @@ namespace Nz return result; } - std::string ToUpper(const std::string_view& str, UnicodeAware) + std::string ToUpper(std::string_view str, UnicodeAware) { if (str.empty()) return std::string(); @@ -470,7 +470,7 @@ namespace Nz return result; } - std::u16string ToUtf16String(const std::string_view& str) + std::u16string ToUtf16String(std::string_view str) { std::u16string result; utf8::utf8to16(str.begin(), str.end(), std::back_inserter(result)); @@ -478,7 +478,7 @@ namespace Nz return result; } - std::u32string ToUtf32String(const std::string_view& str) + std::u32string ToUtf32String(std::string_view str) { std::u32string result; utf8::utf8to32(str.begin(), str.end(), std::back_inserter(result)); @@ -486,7 +486,7 @@ namespace Nz return result; } - std::wstring ToWideString(const std::string_view& str) + std::wstring ToWideString(std::string_view str) { NAZARA_USE_ANONYMOUS_NAMESPACE diff --git a/src/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.cpp b/src/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.cpp index fef6bc711..5e4a969c2 100644 --- a/src/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.cpp +++ b/src/Nazara/OpenGLRenderer/OpenGLCommandBufferBuilder.cpp @@ -17,7 +17,7 @@ namespace Nz { - void OpenGLCommandBufferBuilder::BeginDebugRegion(const std::string_view& regionName, const Color& color) + void OpenGLCommandBufferBuilder::BeginDebugRegion(std::string_view regionName, const Color& color) { m_commandBuffer.BeginDebugRegion(regionName, color); } diff --git a/src/Nazara/OpenGLRenderer/OpenGLShaderModule.cpp b/src/Nazara/OpenGLRenderer/OpenGLShaderModule.cpp index 04c134f7c..c7374efed 100644 --- a/src/Nazara/OpenGLRenderer/OpenGLShaderModule.cpp +++ b/src/Nazara/OpenGLRenderer/OpenGLShaderModule.cpp @@ -88,7 +88,7 @@ namespace Nz env.glES = (contextParams.type == GL::ContextType::OpenGL_ES); env.glMajorVersion = contextParams.glMajorVersion; env.glMinorVersion = contextParams.glMinorVersion; - env.extCallback = [&](const std::string_view& ext) + env.extCallback = [&](std::string_view ext) { return context.IsExtensionSupported(std::string(ext)); }; diff --git a/src/Nazara/OpenGLRenderer/Wrapper/Context.cpp b/src/Nazara/OpenGLRenderer/Wrapper/Context.cpp index 703ee8d8c..09d4f86a4 100644 --- a/src/Nazara/OpenGLRenderer/Wrapper/Context.cpp +++ b/src/Nazara/OpenGLRenderer/Wrapper/Context.cpp @@ -1027,7 +1027,7 @@ namespace Nz::GL m_vaoCache.Clear(); } - bool Context::ImplementFallback(const std::string_view& function) + bool Context::ImplementFallback(std::string_view function) { SymbolLoader loader(*this); diff --git a/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.cpp b/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.cpp index eaa987219..c9b2cb8a4 100644 --- a/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.cpp +++ b/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLContextBase.cpp @@ -296,7 +296,7 @@ namespace Nz::GL return true; } - bool EGLContextBase::ImplementFallback(const std::string_view& function) + bool EGLContextBase::ImplementFallback(std::string_view function) { if (Context::ImplementFallback(function)) return true; diff --git a/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.cpp b/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.cpp index b5f897255..9584da82d 100644 --- a/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.cpp +++ b/src/Nazara/OpenGLRenderer/Wrapper/EGL/EGLLoader.cpp @@ -245,7 +245,7 @@ namespace Nz::GL } } - bool EGLLoader::ImplementFallback(const std::string_view& /*function*/) + bool EGLLoader::ImplementFallback(std::string_view /*function*/) { return false; } diff --git a/src/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.cpp b/src/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.cpp index 48f23e39d..c33408fc6 100644 --- a/src/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.cpp +++ b/src/Nazara/OpenGLRenderer/Wrapper/WGL/WGLContext.cpp @@ -238,7 +238,7 @@ namespace Nz::GL return true; } - bool WGLContext::ImplementFallback(const std::string_view& function) + bool WGLContext::ImplementFallback(std::string_view function) { if (Context::ImplementFallback(function)) return true; diff --git a/src/Nazara/Utility/Formats/DDSLoader.cpp b/src/Nazara/Utility/Formats/DDSLoader.cpp index 696f5b943..83a38813a 100644 --- a/src/Nazara/Utility/Formats/DDSLoader.cpp +++ b/src/Nazara/Utility/Formats/DDSLoader.cpp @@ -18,7 +18,7 @@ namespace Nz DDSLoader() = delete; ~DDSLoader() = delete; - static bool IsSupported(const std::string_view& extension) + static bool IsSupported(std::string_view extension) { return (extension == ".dds"); } diff --git a/src/Nazara/Utility/Formats/FreeTypeLoader.cpp b/src/Nazara/Utility/Formats/FreeTypeLoader.cpp index 0e3957872..685b17301 100644 --- a/src/Nazara/Utility/Formats/FreeTypeLoader.cpp +++ b/src/Nazara/Utility/Formats/FreeTypeLoader.cpp @@ -378,7 +378,7 @@ namespace Nz mutable unsigned int m_characterSize; }; - bool IsFreetypeSupported(const std::string_view& extension) + bool IsFreetypeSupported(std::string_view extension) { constexpr auto s_supportedExtensions = frozen::make_unordered_set({ ".afm", ".bdf", ".cff", ".cid", ".dfont", ".fnt", ".fon", ".otf", ".pfa", ".pfb", ".pfm", ".pfr", ".sfnt", ".ttc", ".tte", ".ttf" }); diff --git a/src/Nazara/Utility/Formats/GIFLoader.cpp b/src/Nazara/Utility/Formats/GIFLoader.cpp index 595688199..612f18c41 100644 --- a/src/Nazara/Utility/Formats/GIFLoader.cpp +++ b/src/Nazara/Utility/Formats/GIFLoader.cpp @@ -704,7 +704,7 @@ namespace Nz bool m_requiresFrameHistory; }; - bool CheckGIFExtension(const std::string_view& extension) + bool CheckGIFExtension(std::string_view extension) { return extension == ".gif"; } diff --git a/src/Nazara/Utility/Formats/MD2Loader.cpp b/src/Nazara/Utility/Formats/MD2Loader.cpp index cf73635df..125189018 100644 --- a/src/Nazara/Utility/Formats/MD2Loader.cpp +++ b/src/Nazara/Utility/Formats/MD2Loader.cpp @@ -21,7 +21,7 @@ namespace Nz { namespace { - bool IsMD2Supported(const std::string_view& extension) + bool IsMD2Supported(std::string_view extension) { return (extension == ".md2"); } diff --git a/src/Nazara/Utility/Formats/MD5AnimLoader.cpp b/src/Nazara/Utility/Formats/MD5AnimLoader.cpp index bd430ff3b..21a159f8b 100644 --- a/src/Nazara/Utility/Formats/MD5AnimLoader.cpp +++ b/src/Nazara/Utility/Formats/MD5AnimLoader.cpp @@ -12,7 +12,7 @@ namespace Nz { namespace { - bool IsMD5AnimSupported(const std::string_view& extension) + bool IsMD5AnimSupported(std::string_view extension) { return extension == ".md5anim"; } diff --git a/src/Nazara/Utility/Formats/MD5MeshLoader.cpp b/src/Nazara/Utility/Formats/MD5MeshLoader.cpp index 48369452e..53337e268 100644 --- a/src/Nazara/Utility/Formats/MD5MeshLoader.cpp +++ b/src/Nazara/Utility/Formats/MD5MeshLoader.cpp @@ -20,7 +20,7 @@ namespace Nz { namespace { - bool IsMD5MeshSupported(const std::string_view& extension) + bool IsMD5MeshSupported(std::string_view extension) { return (extension == ".md5mesh"); } diff --git a/src/Nazara/Utility/Formats/OBJLoader.cpp b/src/Nazara/Utility/Formats/OBJLoader.cpp index fcf4ab2dd..ad572bc27 100644 --- a/src/Nazara/Utility/Formats/OBJLoader.cpp +++ b/src/Nazara/Utility/Formats/OBJLoader.cpp @@ -22,7 +22,7 @@ namespace Nz { namespace { - bool IsOBJSupported(const std::string_view& extension) + bool IsOBJSupported(std::string_view extension) { return (extension == ".obj"); } diff --git a/src/Nazara/Utility/Formats/OBJSaver.cpp b/src/Nazara/Utility/Formats/OBJSaver.cpp index 007736def..94c1f3b82 100644 --- a/src/Nazara/Utility/Formats/OBJSaver.cpp +++ b/src/Nazara/Utility/Formats/OBJSaver.cpp @@ -52,7 +52,7 @@ namespace Nz T* m_buffer; }; - bool IsOBJSupportedSave(const std::string_view& extension) + bool IsOBJSupportedSave(std::string_view extension) { return (extension == ".obj"); } diff --git a/src/Nazara/Utility/Formats/PCXLoader.cpp b/src/Nazara/Utility/Formats/PCXLoader.cpp index 0edd36665..28da0c042 100644 --- a/src/Nazara/Utility/Formats/PCXLoader.cpp +++ b/src/Nazara/Utility/Formats/PCXLoader.cpp @@ -40,7 +40,7 @@ namespace Nz static_assert(sizeof(PCXHeader) == (6+48+54)*sizeof(UInt8) + 10*sizeof(UInt16), "pcx_header struct must be packed"); - bool IsPCXSupported(const std::string_view& extension) + bool IsPCXSupported(std::string_view extension) { return (extension == ".pcx"); } diff --git a/src/Nazara/Utility/Formats/STBLoader.cpp b/src/Nazara/Utility/Formats/STBLoader.cpp index 7f478323a..ce5a70ee3 100644 --- a/src/Nazara/Utility/Formats/STBLoader.cpp +++ b/src/Nazara/Utility/Formats/STBLoader.cpp @@ -41,7 +41,7 @@ namespace Nz static stbi_io_callbacks s_stbiCallbacks = { StbiRead, StbiSkip, StbiEof }; - bool IsSTBSupported(const std::string_view& extension) + bool IsSTBSupported(std::string_view extension) { constexpr auto s_supportedExtensions = frozen::make_unordered_set({ ".bmp", ".gif", ".hdr", ".jpg", ".jpeg", ".pic", ".png", ".ppm", ".pgm", ".psd", ".tga" }); diff --git a/src/Nazara/Utility/Formats/STBSaver.cpp b/src/Nazara/Utility/Formats/STBSaver.cpp index 81b19bc97..9133ec337 100644 --- a/src/Nazara/Utility/Formats/STBSaver.cpp +++ b/src/Nazara/Utility/Formats/STBSaver.cpp @@ -230,7 +230,7 @@ namespace Nz { ".tga", &SaveTGA } }); - bool FormatQuerier(const std::string_view& extension) + bool FormatQuerier(std::string_view extension) { return s_formatHandlers.find(extension) != s_formatHandlers.end(); } diff --git a/src/Nazara/Utility/SimpleTextDrawer.cpp b/src/Nazara/Utility/SimpleTextDrawer.cpp index 3e80501d5..b0aace5ac 100644 --- a/src/Nazara/Utility/SimpleTextDrawer.cpp +++ b/src/Nazara/Utility/SimpleTextDrawer.cpp @@ -182,7 +182,7 @@ namespace Nz return false; }; - void SimpleTextDrawer::GenerateGlyphs(const std::string_view& text) const + void SimpleTextDrawer::GenerateGlyphs(std::string_view text) const { if (text.empty()) return; diff --git a/src/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.cpp b/src/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.cpp index d150f297a..da406b50c 100644 --- a/src/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.cpp +++ b/src/Nazara/VulkanRenderer/VulkanCommandBufferBuilder.cpp @@ -19,7 +19,7 @@ namespace Nz { - void VulkanCommandBufferBuilder::BeginDebugRegion(const std::string_view& regionName, const Color& color) + void VulkanCommandBufferBuilder::BeginDebugRegion(std::string_view regionName, const Color& color) { // Ensure \0 at the end of string StackArray regionNameEOS = NazaraStackArrayNoInit(char, regionName.size() + 1);