State machine as a stack (#123)

* State machine as a stack

* Fix comments linked to code review

* I will think to compile, next time

SDK/include/NDK/StateMachine.hpp

@@ -1,4 +1,4 @@
-// Copyright (C) 2017 Jérôme Leclercq
+// Copyright (C) 2017 Jérôme Leclercq
 // This file is part of the "Nazara Development Kit"
 // For conditions of distribution and use, see copyright notice in Prerequesites.hpp
 
@@ -10,6 +10,7 @@
 #include <NDK/Prerequesites.hpp>
 #include <NDK/State.hpp>
 #include <memory>
+#include <vector>
 
 namespace Ndk
 {
@@ -25,14 +26,21 @@ namespace Ndk
 
 			inline const std::shared_ptr<State>& GetCurrentState() const;
 
+			inline bool IsTopState(const State* state) const;
+
+			inline std::shared_ptr<State> PopState();
+			inline bool PopStatesUntil(std::shared_ptr<State> state);
+			inline void PushState(std::shared_ptr<State> state);
+
+			inline void SetState(std::shared_ptr<State> state);
+
 			inline bool Update(float elapsedTime);
 
 			inline StateMachine& operator=(StateMachine&& fsm) = default;
 			StateMachine& operator=(const StateMachine&) = delete;
 
 		private:
-			std::shared_ptr<State> m_currentState;
+			std::vector<std::shared_ptr<State>> m_states;
-			std::shared_ptr<State> m_nextState;
 	};
 }
 

SDK/include/NDK/StateMachine.inl

@@ -3,7 +3,6 @@
 // For conditions of distribution and use, see copyright notice in Prerequesites.hpp
 
 #include <Nazara/Core/Error.hpp>
-#include <NDK/StateMachine.hpp>
 #include <utility>
 
 namespace Ndk
@@ -11,7 +10,7 @@ namespace Ndk
 	/*!
 	* \ingroup NDK
 	* \class Ndk::StateMachine
-	* \brief NDK class that represents a state machine, to represent the multiple states of your program
+	* \brief NDK class that represents a state machine, to represent the multiple states of your program as a stack
 	*/
 
 	/*!
@@ -23,61 +22,153 @@ namespace Ndk
 	* \remark Produces a NazaraAssert if nullptr is given
 	*/
 
-	inline StateMachine::StateMachine(std::shared_ptr<State> originalState) :
+	inline StateMachine::StateMachine(std::shared_ptr<State> originalState)
-	m_currentState(std::move(originalState))
 	{
-		NazaraAssert(m_currentState, "StateMachine must have a state to begin with");
+		NazaraAssert(originalState, "StateMachine must have a state to begin with");
-		m_currentState->Enter(*this);
+		PushState(std::move(originalState));
 	}
 
 	/*!
 	* \brief Destructs the object
 	*
-	* \remark Calls "Leave" on the state
+	* \remark Calls "Leave" on all the states
 	*/
 
 	inline StateMachine::~StateMachine()
 	{
-		m_currentState->Leave(*this);
+		for (std::shared_ptr<State>& state : m_states)
+			state->Leave(*this);
 	}
 
 	/*!
-	* \brief Changes the current state of the machine
+	* \brief Replaces the current state on the top of the machine
 	*
-	* \param state Next state to represent
+	* \param state State to replace the top one if it is nullptr, no action is performed
 	*/
 
 	inline void StateMachine::ChangeState(std::shared_ptr<State> state)
 	{
-		m_nextState = std::move(state);
+		if (state)
+		{
+			PopState();
+			PushState(std::move(state));
+		}
 	}
 
 	/*!
-	* \brief Gets the current state of the machine
+	* \brief Gets the current state on the top of the machine
 	* \return A constant reference to the state
+	*
+	* \remark The stack is supposed to be non empty, otherwise it is undefined behaviour
+	*
+	* \see PopStatesUntil
 	*/
 
 	inline const std::shared_ptr<State>& StateMachine::GetCurrentState() const
 	{
-		return m_currentState;
+		return m_states.back();
 	}
 
 	/*!
-	* \brief Updates the state 
+	* \brief Checks whether the state is on the top of the machine
-	* \return True if update is successful
+	* \return true If it is the case
+	*
+	* \param state State to compare the top with
+	*/
+
+	inline bool StateMachine::IsTopState(const State* state) const
+	{
+		if (m_states.empty())
+			return false;
+
+		return m_states.back().get() == state;
+	}
+
+	/*!
+	* \brief Pops the state on the top of the machine
+	* \return Old state on the top, nullptr if stack was empty
+	*
+	* \remark This method can completely empty the stack
+	*/
+
+	inline std::shared_ptr<State> StateMachine::PopState()
+	{
+		if (m_states.empty())
+			return nullptr;
+
+		m_states.back()->Leave(*this);
+		std::shared_ptr<State> oldTopState = std::move(m_states.back());
+		m_states.pop_back();
+		return oldTopState;
+	}
+
+	/*!
+	* \brief Pops all the states of the machine until a specific one is reached
+	* \return true If that specific state is on top, false if stack is empty
+	*
+	* \param state State to find on the stack if it is nullptr, no action is performed
+	*
+	* \remark This method can completely empty the stack
+	*/
+
+	inline bool StateMachine::PopStatesUntil(std::shared_ptr<State> state)
+	{
+		if (!state)
+			return false;
+
+		while (!m_states.empty() && !IsTopState(state.get()))
+			PopState();
+
+		return !m_states.empty();
+	}
+
+	/*!
+	* \brief Pushes a new state on the top of the machine
+	*
+	* \param state Next state to represent if it is nullptr, it performs no action
+	*
+	* \remark Produces a NazaraAssert if the same state is pushed two times on the stack
+	*/
+
+	inline void StateMachine::PushState(std::shared_ptr<State> state)
+	{
+		if (state)
+		{
+			NazaraAssert(std::find(m_states.begin(), m_states.end(), state) == m_states.end(), "The same state was pushed two times");
+
+			m_states.push_back(std::move(state));
+			m_states.back()->Enter(*this);
+		}
+	}
+
+	/*!
+	* \brief Pops every states of the machine to put a new one
+	*
+	* \param state State to reset the stack with if it is nullptr, no action is performed
+	*/
+
+	inline void StateMachine::SetState(std::shared_ptr<State> state)
+	{
+		if (state)
+		{
+			while (!m_states.empty())
+				PopState();
+
+			PushState(std::move(state));
+		}
+	}
+
+	/*!
+	* \brief Updates all the states
+	* \return true If update is successful for everyone of them
 	*
 	* \param elapsedTime Delta time used for the update
 	*/
 
 	inline bool StateMachine::Update(float elapsedTime)
 	{
-		if (m_nextState)
+		return std::all_of(m_states.begin(), m_states.end(), [=](std::shared_ptr<State>& state) {
-		{
+			return state->Update(*this, elapsedTime);
-			m_currentState->Leave(*this);
+		});
-			m_currentState = std::move(m_nextState);
-			m_currentState->Enter(*this);
-		}
-
-		return m_currentState->Update(*this, elapsedTime);
 	}
 }

tests/SDK/NDK/StateMachine.cpp

@@ -28,21 +28,79 @@ class TestState : public Ndk::State
 		bool m_isUpdated;
 };
 
+class SecondTestState : public Ndk::State
+{
+	public:
+		void Enter(Ndk::StateMachine& /*fsm*/) override
+		{
+			m_isUpdated = false;
+		}
+
+		bool IsUpdated() const
+		{
+			return m_isUpdated;
+		}
+
+		void Leave(Ndk::StateMachine& /*fsm*/) override
+		{
+		}
+
+		bool Update(Ndk::StateMachine& fsm, float /*elapsedTime*/) override
+		{
+			if (fsm.IsTopState(this))
+				m_isUpdated = true;
+			return true;
+		}
+
+	private:
+		bool m_isUpdated;
+};
+
 SCENARIO("State & StateMachine", "[NDK][STATE]")
 {
-	GIVEN("A statemachine with our TestState")
+	GIVEN("A statemachine with our test states")
 	{
 		std::shared_ptr<TestState> testState = std::make_shared<TestState>();
-		Ndk::StateMachine stateMachine(testState);
+		std::shared_ptr<SecondTestState> secondTestState = std::make_shared<SecondTestState>();
+		Ndk::StateMachine stateMachine(secondTestState);
+		stateMachine.PushState(testState);
 		REQUIRE(!testState->IsUpdated());
+		REQUIRE(!secondTestState->IsUpdated());
 
 		WHEN("We update our machine")
 		{
 			stateMachine.Update(1.f);
 
-			THEN("Our state has been updated")
+			THEN("Our state on the top has been updated but not the bottom one")
 			{
+				REQUIRE(stateMachine.IsTopState(testState.get()));
+				REQUIRE(!stateMachine.IsTopState(secondTestState.get()));
+
 				REQUIRE(testState->IsUpdated());
+				REQUIRE(!secondTestState->IsUpdated());
+			}
+		}
+
+		WHEN("We exchange the states' positions while emptying the stack")
+		{
+			REQUIRE(stateMachine.PopStatesUntil(secondTestState));
+			REQUIRE(stateMachine.IsTopState(secondTestState.get()));
+
+			std::shared_ptr<Ndk::State> oldState = stateMachine.PopState();
+			REQUIRE(stateMachine.PopState() == nullptr);
+
+			stateMachine.SetState(testState);
+			stateMachine.PushState(oldState);
+
+			stateMachine.Update(1.f);
+
+			THEN("Both states should be updated")
+			{
+				REQUIRE(!stateMachine.IsTopState(testState.get()));
+				REQUIRE(stateMachine.IsTopState(secondTestState.get()));
+
+				REQUIRE(testState->IsUpdated());
+				REQUIRE(secondTestState->IsUpdated());
 			}
 		}
 	}