From fe24cc7d2a372bab71c755d3307830ef202edac0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Leclercq?= Date: Sun, 5 Sep 2021 15:48:26 +0200 Subject: [PATCH] VulkanRenderer: Don't enable Vulkan core extensions if they're supported by Vulkan version --- src/Nazara/VulkanRenderer/Vulkan.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Nazara/VulkanRenderer/Vulkan.cpp b/src/Nazara/VulkanRenderer/Vulkan.cpp index 17c38d10e..7d929816e 100644 --- a/src/Nazara/VulkanRenderer/Vulkan.cpp +++ b/src/Nazara/VulkanRenderer/Vulkan.cpp @@ -279,6 +279,7 @@ namespace Nz std::array enabledFeatures = { //VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT, //VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT, + //VK_VALIDATION_FEATURE_ENABLE_BEST_PRACTICES_EXT, VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION_EXT }; @@ -554,8 +555,12 @@ namespace Nz // VMA extensions EnableIfSupported(VK_EXT_MEMORY_BUDGET_EXTENSION_NAME); - EnableIfSupported(VK_KHR_BIND_MEMORY_2_EXTENSION_NAME); - EnableIfSupported(VK_KHR_DEDICATED_ALLOCATION_EXTENSION_NAME); + + if (deviceInfo.properties.apiVersion < VK_API_VERSION_1_1) + { + EnableIfSupported(VK_KHR_BIND_MEMORY_2_EXTENSION_NAME); + EnableIfSupported(VK_KHR_DEDICATED_ALLOCATION_EXTENSION_NAME); + } } std::vector additionalExtensions; // Just to keep the String alive