sid/NazaraEngine
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Core/StringExt: Don't pass string_view by ref

Browse Source 
https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/
This commit is contained in:
SirLynix
2023-08-24 08:23:14 +02:00
parent 1b7a89213d
commit bd53245f42
51 changed files with 115 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/Nazara/Utility/SimpleTextDrawer.hpp
View File

@@ -23,7 +23,7 @@ namespace Nz
inline SimpleTextDrawer(SimpleTextDrawer&& drawer) noexcept;
~SimpleTextDrawer() = default;
inline void AppendText(const std::string_view& str);
inline void AppendText(std::string_view str);
void Clear() override;
@@ -75,7 +75,7 @@ namespace Nz
inline void DisconnectFontSlots();
bool GenerateGlyph(Glyph& glyph, char32_t character, float outlineThickness, bool lineWrap, Color color, int renderOrder, int* advance) const;
void GenerateGlyphs(const std::string_view& text) const;
void GenerateGlyphs(std::string_view text) const;
inline float GetLineHeight(const Font::SizeInfo& sizeInfo) const;

2
include/Nazara/Utility/SimpleTextDrawer.inl
View File

@@ -42,7 +42,7 @@ namespace Nz
operator=(std::move(drawer));
}
inline void SimpleTextDrawer::AppendText(const std::string_view& str)
inline void SimpleTextDrawer::AppendText(std::string_view str)
{
m_text.append(str);
if (m_glyphUpdated)