Core/StringExt: Don't pass string_view by ref

https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/

src/Nazara/Utility/Formats/DDSLoader.cpp

@@ -18,7 +18,7 @@ namespace Nz
 			DDSLoader() = delete;
 			~DDSLoader() = delete;
 
-			static bool IsSupported(const std::string_view& extension)
+			static bool IsSupported(std::string_view extension)
 			{
 				return (extension == ".dds");
 			}

src/Nazara/Utility/Formats/FreeTypeLoader.cpp

@@ -378,7 +378,7 @@ namespace Nz
 				mutable unsigned int m_characterSize;
 		};
 
-		bool IsFreetypeSupported(const std::string_view& extension)
+		bool IsFreetypeSupported(std::string_view extension)
 		{
 			constexpr auto s_supportedExtensions = frozen::make_unordered_set<frozen::string>({ ".afm", ".bdf", ".cff", ".cid", ".dfont", ".fnt", ".fon", ".otf", ".pfa", ".pfb", ".pfm", ".pfr", ".sfnt", ".ttc", ".tte", ".ttf" });
 

src/Nazara/Utility/Formats/GIFLoader.cpp

@@ -704,7 +704,7 @@ namespace Nz
 				bool m_requiresFrameHistory;
 		};
 
-		bool CheckGIFExtension(const std::string_view& extension)
+		bool CheckGIFExtension(std::string_view extension)
 		{
 			return extension == ".gif";
 		}

src/Nazara/Utility/Formats/MD2Loader.cpp

@@ -21,7 +21,7 @@ namespace Nz
 {
 	namespace
 	{
-		bool IsMD2Supported(const std::string_view& extension)
+		bool IsMD2Supported(std::string_view extension)
 		{
 			return (extension == ".md2");
 		}

src/Nazara/Utility/Formats/MD5AnimLoader.cpp

@@ -12,7 +12,7 @@ namespace Nz
 {
 	namespace
 	{
-		bool IsMD5AnimSupported(const std::string_view& extension)
+		bool IsMD5AnimSupported(std::string_view extension)
 		{
 			return extension == ".md5anim";
 		}

src/Nazara/Utility/Formats/MD5MeshLoader.cpp

@@ -20,7 +20,7 @@ namespace Nz
 {
 	namespace
 	{
-		bool IsMD5MeshSupported(const std::string_view& extension)
+		bool IsMD5MeshSupported(std::string_view extension)
 		{
 			return (extension == ".md5mesh");
 		}

src/Nazara/Utility/Formats/OBJLoader.cpp

@@ -22,7 +22,7 @@ namespace Nz
 {
 	namespace
 	{
-		bool IsOBJSupported(const std::string_view& extension)
+		bool IsOBJSupported(std::string_view extension)
 		{
 			return (extension == ".obj");
 		}

src/Nazara/Utility/Formats/OBJSaver.cpp

@@ -52,7 +52,7 @@ namespace Nz
 				T* m_buffer;
 		};
 
-		bool IsOBJSupportedSave(const std::string_view& extension)
+		bool IsOBJSupportedSave(std::string_view extension)
 		{
 			return (extension == ".obj");
 		}

src/Nazara/Utility/Formats/PCXLoader.cpp

@@ -40,7 +40,7 @@ namespace Nz
 
 		static_assert(sizeof(PCXHeader) == (6+48+54)*sizeof(UInt8) + 10*sizeof(UInt16), "pcx_header struct must be packed");
 
-		bool IsPCXSupported(const std::string_view& extension)
+		bool IsPCXSupported(std::string_view extension)
 		{
 			return (extension == ".pcx");
 		}

src/Nazara/Utility/Formats/STBLoader.cpp

@@ -41,7 +41,7 @@ namespace Nz
 
 		static stbi_io_callbacks s_stbiCallbacks = { StbiRead, StbiSkip, StbiEof };
 
-		bool IsSTBSupported(const std::string_view& extension)
+		bool IsSTBSupported(std::string_view extension)
 		{
 			constexpr auto s_supportedExtensions = frozen::make_unordered_set<frozen::string>({ ".bmp", ".gif", ".hdr", ".jpg", ".jpeg", ".pic", ".png", ".ppm", ".pgm", ".psd", ".tga" });
 

src/Nazara/Utility/Formats/STBSaver.cpp

@@ -230,7 +230,7 @@ namespace Nz
 			{ ".tga",  &SaveTGA }
 		});
 		
-		bool FormatQuerier(const std::string_view& extension)
+		bool FormatQuerier(std::string_view extension)
 		{
 			return s_formatHandlers.find(extension) != s_formatHandlers.end();
 		}

src/Nazara/Utility/SimpleTextDrawer.cpp

@@ -182,7 +182,7 @@ namespace Nz
 			return false;
 	};
 
-	void SimpleTextDrawer::GenerateGlyphs(const std::string_view& text) const
+	void SimpleTextDrawer::GenerateGlyphs(std::string_view text) const
 	{
 		if (text.empty())
 			return;